From: Wolfram Sang <wsa@the-dreams.de>
To: alex.williams@ettus.com
Cc: linux-kernel@vger.kernel.org,
Alex Williams <alex.williams@ni.com>,
linux-arm-kernel@lists.infradead.org, mical.simek@xilinx.com,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: cadence: Handle transfer_size rollover
Date: Thu, 30 Jan 2020 09:03:07 +0100 [thread overview]
Message-ID: <20200130080307.GA2208@ninjato> (raw)
In-Reply-To: <20190131213957.11568-1-alex.williams@ettus.com>
[-- Attachment #1.1: Type: text/plain, Size: 770 bytes --]
On Thu, Jan 31, 2019 at 01:39:57PM -0800, alex.williams@ettus.com wrote:
> From: Alex Williams <alex.williams@ni.com>
>
> Under certain conditions, Cadence's I2C controller's transfer_size
> register will roll over and generate invalid read transactions. Before
> this change, the ISR relied solely on the RXDV bit to determine when to
> write more data to the user's buffer. The invalid read data would cause
> overruns, smashing stacks and worse.
>
> This change stops the buffer writes to the requested boundary and
> reports the error. The controller will be reset so normal transactions
> may resume.
>
> Signed-off-by: Alex Williams <alex.williams@ni.com>
Applied to for-next with another Rev-by from Michal given in another
thread, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-30 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 21:39 [PATCH] i2c: cadence: Handle transfer_size rollover alex.williams
[not found] ` <CAKfKVtFM1zPb-MjBwY8WREy4xoHW60JrjZ-LnSzBvJ1Yv_zgsw@mail.gmail.com>
2019-02-15 15:29 ` Alex Williams
2019-11-28 11:54 ` Shubhrajyoti Datta
2020-01-30 8:03 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130080307.GA2208@ninjato \
--to=wsa@the-dreams.de \
--cc=alex.williams@ettus.com \
--cc=alex.williams@ni.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mical.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).