From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62845C33C9E for ; Thu, 30 Jan 2020 11:05:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3222206F0 for ; Thu, 30 Jan 2020 11:05:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fhjHZRo1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3222206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K8ZsmR1liXDNq3Al9omCO+akeqlSYdpknXFPg3MgGqE=; b=fhjHZRo1aPbyMb 3Pm0lkqEy9nNHG/llvZAnbFSnonQtW/F6hM7m1Sn+k2OZbyWeZhujbis4Kspjiq5RUYeQAiWl9HbM 3OpXeV0/9m0EbdLXm72U8HTMpbmUdBoJgUDvQYvBagXCFZtJwpTnB7DnQ2+4nxD08Hqn1F+pRHyea T8KeiPoLAOT7PqupjIBEQ41a0tH/tUxl+EoNv72GnRY7bJZOa1wAcb2iNg0TSAdjE6TWzbSwq4xej HA0CA+PyiBm2x+ZeEn0ldg5O3J+85dlTsUot+wvS8wHXIOL+90InWCcfgmN8WnTjuuQFhoZjzxM5b hEb2us0ly5/SxmLY1EFQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ix7dH-0006KP-GU; Thu, 30 Jan 2020 11:05:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ix7dE-0005us-Ki for linux-arm-kernel@lists.infradead.org; Thu, 30 Jan 2020 11:05:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 20733328; Thu, 30 Jan 2020 03:05:08 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 55DDA3F67D; Thu, 30 Jan 2020 03:05:07 -0800 (PST) Date: Thu, 30 Jan 2020 11:05:05 +0000 From: Sudeep Holla To: Gavin Shan Subject: Re: [PATCH] drivers/firmware/psci: Fix memory leak in alloc_init_cpu_groups() Message-ID: <20200130110505.GD48466@bogus> References: <20200130034938.158504-1-gshan@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200130_030508_728974_DE851FB6 X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 30, 2020 at 03:00:13PM +1100, Gavin Shan wrote: > On 1/30/20 2:49 PM, Gavin Shan wrote: > > The CPU mask (@tmp) should be free'd on failing to allocating the element > > of @cpu_groups[]. Otherwise, it leads to memory leakage because the CPU > > mask variable is allocated with CONFIG_CPUMASK_OFFSTACK. > > > > Signed-off-by: Gavin Shan > > --- > > drivers/firmware/psci/psci_checker.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c > > index 6a445397771c..d1d6d1135fed 100644 > > --- a/drivers/firmware/psci/psci_checker.c > > +++ b/drivers/firmware/psci/psci_checker.c > > @@ -167,6 +167,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups) > > topology_core_cpumask(cpumask_any(tmp)); > > if (!alloc_cpumask_var(&cpu_groups[num_groups], GFP_KERNEL)) { > > + free_cpumask_var(tmp); > > free_cpu_groups(num_groups, &cpu_groups); > > return -ENOMEM; > > } > > > > I think @tmp has to be free'd either when failing to allocate @cpu_groups. > However, I'm holding to post v2 until feedback is received on v1. > Ah sorry, problem with sequential mail reading, ignore my reply as you have already figured this out. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel