From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BA4C2D0DB for ; Fri, 31 Jan 2020 15:30:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2408E20707 for ; Fri, 31 Jan 2020 15:30:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PpljNMbt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2408E20707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CR6lGxcvHRvLJwlv29LZOg75HMt3zP1w2zC4M9kuk/Q=; b=PpljNMbtWJJ54/ lWGjAweYxauFX5CQR9H74GQF0kFBA0+bDVMXsxPoIC5zcbstvjPgKwOuGEIuyA7mkWFp6s00tu04Y yBxFYg1NB6Tjac4QM/u+L4R5UZJ5RLptfd6oYrS+F7R4nTRNZXcx3FZkXRZzxyzl5RLr6UzkIYr2g JofKMBJfQXBJlxtLkO9N1Hf1HWezWxtsISrrf/uk50stzgkx5IVIBVkfVBWy8LG13vqpFBa2Lrgq8 v3E4eKniQYuC+lGDz5hnPXCiRDWvQpwYbFTDDGVLG08dXSSfHBRecwSTpT0dpFF6apliRtwrev3qf mq2j6AXchN0ghipgsiqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixYFa-0000RP-Ve; Fri, 31 Jan 2020 15:30:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixYFY-0000R8-2Y for linux-arm-kernel@lists.infradead.org; Fri, 31 Jan 2020 15:30:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 56675FEC; Fri, 31 Jan 2020 07:30:27 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8D30C3F67D; Fri, 31 Jan 2020 07:30:26 -0800 (PST) Date: Fri, 31 Jan 2020 15:30:24 +0000 From: Sudeep Holla To: Gavin Shan Subject: Re: [PATCH v2] drivers/firmware/psci: Fix memory leakage in alloc_init_cpu_groups() Message-ID: <20200131153024.GB54178@bogus> References: <20200130215148.191953-1-gshan@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200130215148.191953-1-gshan@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200131_073028_160409_802473CA X-CRM114-Status: UNSURE ( 7.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 31, 2020 at 08:51:48AM +1100, Gavin Shan wrote: > The CPU mask (@tmp) should be free'd on failing to allocate @cpu_groups > or any of its elements. Otherwise, it leads to memory leakage because the > CPU mask variable is dynamically allocated with CONFIG_CPUMASK_OFFSTACK. > Reviewed-by: Sudeep Holla -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel