From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C869C35247 for ; Wed, 5 Feb 2020 22:08:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1A2320730 for ; Wed, 5 Feb 2020 22:08:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ntz4ufTL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QlaOB0m9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1A2320730 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CkfxwMdqy9X6JuGwPWQoD1V8u7QVQ93HwRM3zvOFgPE=; b=ntz4ufTLgdr6np h9kuFQtjEtxutRPEXmo1vZpSCqkAZKXHfAxnUdOTF+25wUgAJGtIqGrhkJW2KDVg9z2dPr8eYrvKj Kf1sy0jlIY9NSdDfh8M1y2zvsGnWMfcRf5E6PjTenrj48qOW7Jj6M99ToGut7kNAFGSrKrZcX8Fx+ HfxHLhycqRFSGvXSLIUr3431yQ3nYnjL+MNW23+bQEbwNzTepv3M1Kqg6l3+UwcE5la01LX3A9kBm nuzYZAui4a+ZC60t6vnxsoi31gyPnxws8cHLu4XU7S0leng84Ede0IVD3DxTXKwBDmHXb+hSzSHFJ QXqRAO2oAOmmDUdMKxzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izSqa-0008Ta-Iu; Wed, 05 Feb 2020 22:08:36 +0000 Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izSqV-0008SL-OJ for linux-arm-kernel@lists.infradead.org; Wed, 05 Feb 2020 22:08:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580940509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qcqAII0Mla+8J9XCC2F7t68zZyPiZF4YHjS+Fi7LYLQ=; b=QlaOB0m99x6nb569DwpCk45XjQzNRfENqyQG8AGqVU6vJvFJqKZraqdcwX0om/+yLKy0GA 6hzJ+Loyc8kQES3tyZYoqcWGnAKKQLc8AK4qB1BTeIWfjaWklvxpTwGw0YDbyxZfa6NS4q rLzMTNjRJEiJ5gh3s6+fEX6EsTJhRHc= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-evxyBP1iNACS5RF3yzopMw-1; Wed, 05 Feb 2020 17:08:27 -0500 Received: by mail-qv1-f69.google.com with SMTP id g6so2444827qvp.0 for ; Wed, 05 Feb 2020 14:08:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6bIsTUAiuk9WkuPnamAI4/KWATTYkjxm0pqVjMTg08w=; b=blnMkJJ3EiJfNofoXMy2wWrQtcXTEHbhDHeUlaR7HjATxHSRsIH7D/Zflh4AKXbSsa ripZ2arbEmW2ZVBORvv0K7an0rVbSEZwNip37unK7aQqFhBi0VtR8WqBcya/7ZxHkGP8 Y0Xd+6zPVq8idhwU0HQFSXknCi4FidFha9JI6OV5sfDt8UK+U5Zz/FVBAxeagPgvMAn6 rMPnv2r4NBEfErzs/Yy2eAYyDz7EbadPtqZPbmgpyvwwDbo7sNe7pXTbFoJX/Z1KqmQ7 MO4NJtpgTDDavU2sMJbFAYhTdtPEzn84aRMKS4BYk1W+k3VPkiJ0+vJGLRN3fyKCF55w HMvg== X-Gm-Message-State: APjAAAXzAaKe47+iH9BPvwbUIXOgSOl8saz44x3hpa6dbDQtjaG8O/RA zen+is1uU/306RO09XpZoN+I6tPTXQ+lIZ6pAJ80DxCnsh6k7qfCVuK5ZCxNflBgk6e09Fq1+30 r54YHguCN2kyDtkFr5R1ZNOPGIhl1n9oNjLw= X-Received: by 2002:ac8:4e94:: with SMTP id 20mr35228162qtp.335.1580940506681; Wed, 05 Feb 2020 14:08:26 -0800 (PST) X-Google-Smtp-Source: APXvYqxhvNH1iy5q/tis+s7hwuGT0ebc3dkr1uSM1KA4FQeWbspaaAJT384pUzbSiV9AUE83qayDAQ== X-Received: by 2002:ac8:4e94:: with SMTP id 20mr35228131qtp.335.1580940506464; Wed, 05 Feb 2020 14:08:26 -0800 (PST) Received: from xz-x1 ([2607:9880:19c8:32::2]) by smtp.gmail.com with ESMTPSA id t16sm458993qkg.96.2020.02.05.14.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2020 14:08:25 -0800 (PST) Date: Wed, 5 Feb 2020 17:08:22 -0500 From: Peter Xu To: Sean Christopherson Subject: Re: [PATCH v5 02/19] KVM: Reinstall old memslots if arch preparation fails Message-ID: <20200205220822.GE387680@xz-x1> References: <20200121223157.15263-1-sean.j.christopherson@intel.com> <20200121223157.15263-3-sean.j.christopherson@intel.com> MIME-Version: 1.0 In-Reply-To: <20200121223157.15263-3-sean.j.christopherson@intel.com> X-MC-Unique: evxyBP1iNACS5RF3yzopMw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200205_140831_881090_2874D549 X-CRM114-Status: GOOD ( 10.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , linux-mips@vger.kernel.org, Paul Mackerras , kvmarm@lists.cs.columbia.edu, Janosch Frank , Marc Zyngier , Joerg Roedel , Christian Borntraeger , Julien Thierry , Suzuki K Poulose , kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jim Mattson , Cornelia Huck , Christoffer Dall , linux-kernel@vger.kernel.org, James Morse , Paolo Bonzini , Vitaly Kuznetsov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 21, 2020 at 02:31:40PM -0800, Sean Christopherson wrote: > Reinstall the old memslots if preparing the new memory region fails > after invalidating a to-be-{re}moved memslot. > > Remove the superfluous 'old_memslots' variable so that it's somewhat > clear that the error handling path needs to free the unused memslots, > not simply the 'old' memslots. > > Fixes: bc6678a33d9b9 ("KVM: introduce kvm->srcu and convert kvm_set_memory_region to SRCU update") > Reviewed-by: Christoffer Dall > Signed-off-by: Sean Christopherson Reviewed-by: Peter Xu -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel