From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 137FEC35247 for ; Wed, 5 Feb 2020 23:08:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C449F2072B for ; Wed, 5 Feb 2020 23:08:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RxueRb7V"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U4u2/Wr2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C449F2072B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PSBTOSWuLMKEDNMGSORvZEj9hwwHciUnn5cGDLO9XGI=; b=RxueRb7VZMq287 uhn5kjktPjQmirKW73Dg8dtXXRomNo98MRYBvuiQzKJQRp/Wvv+Z+vs+41XgBcAsDT40C0pYXWI34 2pJ7j0Nk0OQFJiuO4vuipiLsZnemjgzw2vdXKhyKqYWf4sjOPkSt9NuXFdTvroG1k5rflNMk/NKcs XLuB5tKsCHcpqqrVRrqI0NhjA3/L98MVQmZ9euJW75wnNj71sv2gaG2xUh3U1EzYCroqG7FjxRM4t D9LCZ/2NnZ18frl9e0YBQkBr25c39gLpoySWtDaM/8Sxsr/r18TOckyRa+INbpQQpqavl7w8vEZlO iTwU/+1612Gu++0jvNVQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izTmk-0003iC-R0; Wed, 05 Feb 2020 23:08:42 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izTmh-0003hk-WC for linux-arm-kernel@lists.infradead.org; Wed, 05 Feb 2020 23:08:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580944117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=29ZTjJBKR+L3bx4WS0f/voo5oahzOM1U9ASFLBeMp4o=; b=U4u2/Wr2nhEmeVzD7ha2K7Qt/l81zFGahMXLY8WIH+Maa1Thb+X8raPBBbRmZucen2T3nX 4BQIK18yiBWMy0pZQaJEXgMH3HTPIqZSn1G4Y922FHs/fMYXL4hiBr2O9ZtQopo/We/qDM vmF1x0VN+sRO1gy0jc45Sd+kq/WvbIo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-127-aW0bz0YAODSSJOPBtHmibQ-1; Wed, 05 Feb 2020 18:08:35 -0500 X-MC-Unique: aW0bz0YAODSSJOPBtHmibQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 44D17800D54; Wed, 5 Feb 2020 23:08:33 +0000 (UTC) Received: from localhost (ovpn-12-19.pek2.redhat.com [10.72.12.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ABEAA8DC12; Wed, 5 Feb 2020 23:08:29 +0000 (UTC) Date: Thu, 6 Feb 2020 07:08:26 +0800 From: Baoquan He To: Wei Yang Subject: Re: [PATCH v6 08/10] mm/memory_hotplug: Don't check for "all holes" in shrink_zone_span() Message-ID: <20200205230826.GF8965@MiWiFi-R3L-srv> References: <20191006085646.5768-1-david@redhat.com> <20191006085646.5768-9-david@redhat.com> <20200205095924.GC24162@richard> <20200205144811.GF26758@MiWiFi-R3L-srv> <20200205225633.GA28446@richard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200205225633.GA28446@richard> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200205_150840_111934_DC35FFB1 X-CRM114-Status: GOOD ( 16.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, x86@kernel.org, linux-ia64@vger.kernel.org, Pavel Tatashin , David Hildenbrand , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Dan Williams , linux-arm-kernel@lists.infradead.org, Oscar Salvador Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/06/20 at 06:56am, Wei Yang wrote: > On Wed, Feb 05, 2020 at 10:48:11PM +0800, Baoquan He wrote: > >Hi Wei Yang, > > > >On 02/05/20 at 05:59pm, Wei Yang wrote: > >> >diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > >> >index f294918f7211..8dafa1ba8d9f 100644 > >> >--- a/mm/memory_hotplug.c > >> >+++ b/mm/memory_hotplug.c > >> >@@ -393,6 +393,9 @@ static void shrink_zone_span(struct zone *zone, unsigned long start_pfn, > >> > if (pfn) { > >> > zone->zone_start_pfn = pfn; > >> > zone->spanned_pages = zone_end_pfn - pfn; > >> >+ } else { > >> >+ zone->zone_start_pfn = 0; > >> >+ zone->spanned_pages = 0; > >> > } > >> > } else if (zone_end_pfn == end_pfn) { > >> > /* > >> >@@ -405,34 +408,11 @@ static void shrink_zone_span(struct zone *zone, unsigned long start_pfn, > >> > start_pfn); > >> > if (pfn) > >> > zone->spanned_pages = pfn - zone_start_pfn + 1; > >> >+ else { > >> >+ zone->zone_start_pfn = 0; > >> >+ zone->spanned_pages = 0; > >> >+ } > >> > } > >> > >> If it is me, I would like to take out these two similar logic out. > > > >I also like this style. > >> > >> For example: > >> > >> if () { > >> } else if () { > >> } else { > >> goto out; > >Here the last else is unnecessary, right? > > > > I am afraid not. > > If the range is not the first or last, we would leave pfn not initialized. Ah, you are right. I forgot that one. Then pfn can be assigned the zone_start_pfn as the old code. Then the following logic is the same as the original code, find_smallest_section_pfn()/find_biggest_section_pfn() have done the iteration the old for loop was doing. unsigned long pfn = zone_start_pfn; if () { } else if () { } /* The zone has no valid section */ if (!pfn) { zone->zone_start_pfn = 0; zone->spanned_pages = 0; } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel