From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C1EAC35247 for ; Wed, 5 Feb 2020 23:56:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2473D20672 for ; Wed, 5 Feb 2020 23:56:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oOcl+K6M"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="IHSaNrlX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2473D20672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rdbHviQ4NfWw/wHrtXEzQSWswTX4XITUUV5pnA8CQvM=; b=oOcl+K6MVXPRCU mlYcadp+klnYCRWipB3pTUWcDq8yYwSUjcYQrGnilxSphP4xNYz5dfz6vWQEvhn5oqwCCR1/Ib4Kg pcgz6XbUjN93gioOTGbix9oxfol4VZCfpcYTK49iJTdN4dZcGs0plxowjNM29eSfJ0fiyteoGgSA9 nr5+bKamEE3tRQICWcJlXDJ6oLnn3mH5k19dl1RW17cRiUOSkTmM3NC/UYHp15nC4FwSWXgIl8LPR 20kelvu8JWaO2F2OflhPY9sqKt0ZJfC71McTmxaHHaIOhJSJXlOleu4Kur3mSyE6i2+Gb63t8q7R1 XYIPgFTyS3g6MQp5PZfA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izUXO-0003ea-QH; Wed, 05 Feb 2020 23:56:54 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izUXM-0001t5-6D for linux-arm-kernel@lists.infradead.org; Wed, 05 Feb 2020 23:56:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5aXRAu4MuUd1u+UkGWrwGKaLApXhm4yXkzsV9CVJjT0=; b=IHSaNrlX76PEvKY68PALvoF2i vdyQP4DzsFi59MzqPOMbeJKzjuWk6iMOAzGYIzNaCWxNlqkOFSzxj6lmw2bI8eWlYHqDGdcZHYJax hBa9FbdRBI16SgV1JE9UOz9M/4nAfYder1jTv6XjvVzIBFp8fQljmMbMAC7v1xYQUd4hH4OSbnPHl qv+aU2pmxRmIPELvvWP2BG/9mxvu7iVjoBhpDVV6bJF7TShe5ZmrdnyjemRqtCqWp9fhygFekoX4x zvZh2owVVzNYp1HUoaKuWJWoCxTuJPHjVht4yOxucSNgFHho6c/QO31WQ/I/kLdcG88rLjGpwp+3X Dc7WiGa9g==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:43988) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1izUVE-0003jc-VF; Wed, 05 Feb 2020 23:54:43 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1izUVE-0002If-5d; Wed, 05 Feb 2020 23:54:40 +0000 Date: Wed, 5 Feb 2020 23:54:40 +0000 From: Russell King - ARM Linux admin To: Stefan Agner Subject: Re: [PATCH] ARM: kexec: drop invalid assembly argument Message-ID: <20200205235440.GW25745@shell.armlinux.org.uk> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200205_155652_231618_F27A72B3 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 05, 2020 at 11:59:26PM +0100, Stefan Agner wrote: > The tst menomic has only a single # argument in Thumb mode. There > is an ARM variant which allows to write # as #, # > which probably is where the current syntax comes from. > > It seems that binutils does not care about the additional parameter. > Clang however complains in Thumb2 mode: > arch/arm/kernel/relocate_kernel.S:28:12: error: too many operands for > instruction > tst r3,#1,0 > ^ > > Drop the unnecessary parameter. This fixes building this file in Thumb2 > mode with the Clang integrated assembler. > > Link: https://github.com/ClangBuiltLinux/linux/issues/770 > Signed-off-by: Stefan Agner Please drop it in the patch system, thanks. > --- > arch/arm/kernel/relocate_kernel.S | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/kernel/relocate_kernel.S b/arch/arm/kernel/relocate_kernel.S > index 7eaa2ae7aff5..72a08786e16e 100644 > --- a/arch/arm/kernel/relocate_kernel.S > +++ b/arch/arm/kernel/relocate_kernel.S > @@ -25,26 +25,26 @@ ENTRY(relocate_new_kernel) > ldr r3, [r0],#4 > > /* Is it a destination page. Put destination address to r4 */ > - tst r3,#1,0 > + tst r3,#1 > beq 1f > bic r4,r3,#1 > b 0b > 1: > /* Is it an indirection page */ > - tst r3,#2,0 > + tst r3,#2 > beq 1f > bic r0,r3,#2 > b 0b > 1: > > /* are we done ? */ > - tst r3,#4,0 > + tst r3,#4 > beq 1f > b 2f > > 1: > /* is it source ? */ > - tst r3,#8,0 > + tst r3,#8 > beq 0b > bic r3,r3,#8 > mov r6,#1024 > -- > 2.25.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel