From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDD5C352A2 for ; Thu, 6 Feb 2020 16:14:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B135821775 for ; Thu, 6 Feb 2020 16:14:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CihFsGdp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EnjYedFp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B135821775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2wAociuTZTuBIk115zoXxzwpXc0HEFAtzCbi23jxYVg=; b=CihFsGdpJp40Hj n3RvondZipe8L9of9HMQ1agIYvjoyo0c1Ye/Cep0iJHZgKXVjmPUa7vjSh2qMD/g2OIfrNh+n6fLo /WRBtBjc/uwGmtpJ8gwiEFB92QzlxMMRAtmN7EhbJ7itf0psVR+qGMO51ak+m/Sjr7Y02tD6R4LXg zLRtjMDoKOEzcVY4J6jkZr492yf4x/DRWXCz57vhBlc81wkWiKio+dpQ9oh8B+GOwgOJNpoOVWcu5 zNkw4EpvQEn9CwBpZLbp3lNMbtYPBtZAT8koOYXh/GwYwQkO7r6MuR3QKNDC5+vxU8Ws7yC571VCi YAo/lu496VGEkQ96B5Og==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izjnP-0001zs-Iq; Thu, 06 Feb 2020 16:14:27 +0000 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izjnM-0001zL-22 for linux-arm-kernel@lists.infradead.org; Thu, 06 Feb 2020 16:14:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581005662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mNaIfC8axAPc5ot635/t+73YbS91NIurqIIFBQVX1is=; b=EnjYedFpc5VYwVKNABbbH6m767eDrMsIkXj+VEuqLBt58TETuDKR8YgSKNqEvW5Q7KIZFy NIJ7m3qY8OVc26/ig4be0lUg2y/7ZyHzk+G2zm5TZPH/eJloaFsHwV3mxL2e4e+ekXTbM0 sXSkWMjbDsKw49dfyFpzpzfXEujktzA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-jFze07mWNi6qCr0oQV8d9Q-1; Thu, 06 Feb 2020 11:14:21 -0500 Received: by mail-qv1-f69.google.com with SMTP id l1so3981085qvu.13 for ; Thu, 06 Feb 2020 08:14:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zD2zZ3ak+8ZDNOjl3NQ0JmucKO3t2SwHGRlR5dLOuQs=; b=XanqPmriwWaY8pSXyBsnh/8IEJdqujkcXKp2eH5m6Z8vbH9zaCAGRW1H7CxfjKN3FV TI93803XY+p7/4UhuoBUKF6XBYS900VRQbICASof2b3NwYY2RD7eLsxvgeXbROjZN6Mg pZIeVvqsx3iPOSlb1ZqCBEWrLUREhdwW2WqN3LPLYTLH8Ekocjz6CnflepoOkKAqHrDT xmrKj7kQBXefa0kb3z5aaYVC+CdyOn62n9v5gez5cziSc8rIoeNUayF+B+CrwEa/BlXR Xwotv5Fcco+ZKkh8IN0AfciD1HwG0M9bDt9Dl60NstvOF1cqGelwhSb3Ha/pIdJ+iKN8 FATw== X-Gm-Message-State: APjAAAV51VPHWoyCFMr2ckLFI6LFfPHjRjFB0W7fNUDLS7ua3gp8dMNW Q3FpQ4hPT6L6MZ4qPshbuSrU5rcuEx81BMsi28aAXeHP0eGbI+Q7WOVBSTSA8nHtUWB3LdwpLai IvZqxgtJHI6IC8oq6ZWpqX9D+4+JNkaIwnBY= X-Received: by 2002:ac8:6f27:: with SMTP id i7mr3235329qtv.253.1581005660655; Thu, 06 Feb 2020 08:14:20 -0800 (PST) X-Google-Smtp-Source: APXvYqzCPmrX47EJacBvj/8AwtDA4K9i5Vm/4QY2t/yuwCUp2i98pBnWQFyP1cxUVQ9RQgxjF7p4Wg== X-Received: by 2002:ac8:6f27:: with SMTP id i7mr3235285qtv.253.1581005660385; Thu, 06 Feb 2020 08:14:20 -0800 (PST) Received: from xz-x1 ([2607:9880:19c8:32::2]) by smtp.gmail.com with ESMTPSA id 136sm1590227qkn.109.2020.02.06.08.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 08:14:19 -0800 (PST) Date: Thu, 6 Feb 2020 11:14:15 -0500 From: Peter Xu To: Sean Christopherson Subject: Re: [PATCH v5 12/19] KVM: Move memslot deletion to helper function Message-ID: <20200206161415.GA695333@xz-x1> References: <20200121223157.15263-1-sean.j.christopherson@intel.com> <20200121223157.15263-13-sean.j.christopherson@intel.com> MIME-Version: 1.0 In-Reply-To: <20200121223157.15263-13-sean.j.christopherson@intel.com> X-MC-Unique: jFze07mWNi6qCr0oQV8d9Q-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200206_081424_176698_1FF89CAF X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , linux-mips@vger.kernel.org, Paul Mackerras , kvmarm@lists.cs.columbia.edu, Janosch Frank , Marc Zyngier , Joerg Roedel , Christian Borntraeger , Julien Thierry , Suzuki K Poulose , kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jim Mattson , Cornelia Huck , Christoffer Dall , linux-kernel@vger.kernel.org, James Morse , Paolo Bonzini , Vitaly Kuznetsov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 21, 2020 at 02:31:50PM -0800, Sean Christopherson wrote: > Move memslot deletion into its own routine so that the success path for > other memslot updates does not need to use kvm_free_memslot(), i.e. can > explicitly destroy the dirty bitmap when necessary. This paves the way > for dropping @dont from kvm_free_memslot(), i.e. all callers now pass > NULL for @dont. > > Add a comment above the code to make a copy of the existing memslot > prior to deletion, it is not at all obvious that the pointer will become > stale during sorting and/or installation of new memslots. Could you help explain a bit on this explicit comment? I can follow up with the patch itself which looks all correct to me, but I failed to catch what this extra comment wants to emphasize... Thanks, > > Note, kvm_arch_commit_memory_region() allows an architecture to free > resources when moving a memslot or changing its flags, e.g. x86 frees > its arch specific memslot metadata during commit_memory_region(). -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel