* [PATCH] drivers base/arch_topology: Remove 'struct sched_domain' forward declaration
@ 2020-02-07 11:49 Dietmar Eggemann
2020-02-07 15:48 ` Sudeep Holla
0 siblings, 1 reply; 5+ messages in thread
From: Dietmar Eggemann @ 2020-02-07 11:49 UTC (permalink / raw)
To: Sudeep Holla, linux-kernel; +Cc: Juri Lelli, linux-arm-kernel
The sched domain pointer argument from topology_get_freq_scale() and
topology_get_cpu_scale() got removed by commit 7673c8a4c75d
("sched/cpufreq: Remove arch_scale_freq_capacity()'s 'sd' parameter")
and commit 8ec59c0f5f49 ("sched/topology: Remove unused 'sd' parameter
from arch_scale_cpu_capacity()").
So the 'struct sched_domain' forward declaration is no longer needed.
Remove it.
W/o the sched domain pointer argument the storage class and inline
definition as well as the return type, function name and parameter list
fit all into one line.
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
---
include/linux/arch_topology.h | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
index 3015ecbb90b1..c507e9ddd909 100644
--- a/include/linux/arch_topology.h
+++ b/include/linux/arch_topology.h
@@ -16,9 +16,7 @@ bool topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu);
DECLARE_PER_CPU(unsigned long, cpu_scale);
-struct sched_domain;
-static inline
-unsigned long topology_get_cpu_scale(int cpu)
+static inline unsigned long topology_get_cpu_scale(int cpu)
{
return per_cpu(cpu_scale, cpu);
}
@@ -27,8 +25,7 @@ void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity);
DECLARE_PER_CPU(unsigned long, freq_scale);
-static inline
-unsigned long topology_get_freq_scale(int cpu)
+static inline unsigned long topology_get_freq_scale(int cpu)
{
return per_cpu(freq_scale, cpu);
}
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers base/arch_topology: Remove 'struct sched_domain' forward declaration
2020-02-07 11:49 [PATCH] drivers base/arch_topology: Remove 'struct sched_domain' forward declaration Dietmar Eggemann
@ 2020-02-07 15:48 ` Sudeep Holla
2020-02-10 15:20 ` Dietmar Eggemann
0 siblings, 1 reply; 5+ messages in thread
From: Sudeep Holla @ 2020-02-07 15:48 UTC (permalink / raw)
To: Dietmar Eggemann; +Cc: Juri Lelli, linux-kernel, linux-arm-kernel, Sudeep Holla
On Fri, Feb 07, 2020 at 12:49:13PM +0100, Dietmar Eggemann wrote:
> The sched domain pointer argument from topology_get_freq_scale() and
> topology_get_cpu_scale() got removed by commit 7673c8a4c75d
> ("sched/cpufreq: Remove arch_scale_freq_capacity()'s 'sd' parameter")
> and commit 8ec59c0f5f49 ("sched/topology: Remove unused 'sd' parameter
> from arch_scale_cpu_capacity()").
>
> So the 'struct sched_domain' forward declaration is no longer needed.
> Remove it.
>
> W/o the sched domain pointer argument the storage class and inline
> definition as well as the return type, function name and parameter list
> fit all into one line.
Looks simple and good to me. I don't want to ask you split the patch as
$subject indicates only one of the 2 changes in the patch. I am fine with
it as it but if anyone else shout for that, go for the split.
Either way,
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
You have not added Greg who generally picks up the patch. Can you repost
with him in cc and my reviewed-by so that he can pick it up.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers base/arch_topology: Remove 'struct sched_domain' forward declaration
2020-02-07 15:48 ` Sudeep Holla
@ 2020-02-10 15:20 ` Dietmar Eggemann
0 siblings, 0 replies; 5+ messages in thread
From: Dietmar Eggemann @ 2020-02-10 15:20 UTC (permalink / raw)
To: Sudeep Holla; +Cc: Juri Lelli, linux-kernel, linux-arm-kernel
On 07/02/2020 16:48, Sudeep Holla wrote:
> On Fri, Feb 07, 2020 at 12:49:13PM +0100, Dietmar Eggemann wrote:
>> The sched domain pointer argument from topology_get_freq_scale() and
>> topology_get_cpu_scale() got removed by commit 7673c8a4c75d
>> ("sched/cpufreq: Remove arch_scale_freq_capacity()'s 'sd' parameter")
>> and commit 8ec59c0f5f49 ("sched/topology: Remove unused 'sd' parameter
>> from arch_scale_cpu_capacity()").
>>
>> So the 'struct sched_domain' forward declaration is no longer needed.
>> Remove it.
>>
>> W/o the sched domain pointer argument the storage class and inline
>> definition as well as the return type, function name and parameter list
>> fit all into one line.
>
> Looks simple and good to me. I don't want to ask you split the patch as
> $subject indicates only one of the 2 changes in the patch. I am fine with
> it as it but if anyone else shout for that, go for the split.
>
> Either way,
>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
>
> You have not added Greg who generally picks up the patch. Can you repost
> with him in cc and my reviewed-by so that he can pick it up.
Will do. I'll keep the patch like it is. Thanks for the review!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drivers base/arch_topology: Remove 'struct sched_domain' forward declaration
@ 2020-02-10 15:24 Dietmar Eggemann
2020-02-10 16:02 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Dietmar Eggemann @ 2020-02-10 15:24 UTC (permalink / raw)
To: Sudeep Holla, Greg Kroah-Hartman, linux-kernel, linux-arm-kernel
Cc: Juri Lelli
The sched domain pointer argument from topology_get_freq_scale() and
topology_get_cpu_scale() got removed by commit 7673c8a4c75d
("sched/cpufreq: Remove arch_scale_freq_capacity()'s 'sd' parameter")
and commit 8ec59c0f5f49 ("sched/topology: Remove unused 'sd' parameter
from arch_scale_cpu_capacity()").
So the 'struct sched_domain' forward declaration is no longer needed.
Remove it.
W/o the sched domain pointer argument the storage class and inline
definition as well as the return type, function name and parameter list
fit all into one line.
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
---
include/linux/arch_topology.h | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
index 3015ecbb90b1..c507e9ddd909 100644
--- a/include/linux/arch_topology.h
+++ b/include/linux/arch_topology.h
@@ -16,9 +16,7 @@ bool topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu);
DECLARE_PER_CPU(unsigned long, cpu_scale);
-struct sched_domain;
-static inline
-unsigned long topology_get_cpu_scale(int cpu)
+static inline unsigned long topology_get_cpu_scale(int cpu)
{
return per_cpu(cpu_scale, cpu);
}
@@ -27,8 +25,7 @@ void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity);
DECLARE_PER_CPU(unsigned long, freq_scale);
-static inline
-unsigned long topology_get_freq_scale(int cpu)
+static inline unsigned long topology_get_freq_scale(int cpu)
{
return per_cpu(freq_scale, cpu);
}
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers base/arch_topology: Remove 'struct sched_domain' forward declaration
2020-02-10 15:24 Dietmar Eggemann
@ 2020-02-10 16:02 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-02-10 16:02 UTC (permalink / raw)
To: Dietmar Eggemann; +Cc: Juri Lelli, linux-kernel, linux-arm-kernel, Sudeep Holla
On Mon, Feb 10, 2020 at 04:24:20PM +0100, Dietmar Eggemann wrote:
> The sched domain pointer argument from topology_get_freq_scale() and
> topology_get_cpu_scale() got removed by commit 7673c8a4c75d
> ("sched/cpufreq: Remove arch_scale_freq_capacity()'s 'sd' parameter")
> and commit 8ec59c0f5f49 ("sched/topology: Remove unused 'sd' parameter
> from arch_scale_cpu_capacity()").
>
> So the 'struct sched_domain' forward declaration is no longer needed.
> Remove it.
>
> W/o the sched domain pointer argument the storage class and inline
> definition as well as the return type, function name and parameter list
> fit all into one line.
>
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> include/linux/arch_topology.h | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
> index 3015ecbb90b1..c507e9ddd909 100644
> --- a/include/linux/arch_topology.h
> +++ b/include/linux/arch_topology.h
> @@ -16,9 +16,7 @@ bool topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu);
>
> DECLARE_PER_CPU(unsigned long, cpu_scale);
>
> -struct sched_domain;
> -static inline
> -unsigned long topology_get_cpu_scale(int cpu)
> +static inline unsigned long topology_get_cpu_scale(int cpu)
> {
> return per_cpu(cpu_scale, cpu);
> }
> @@ -27,8 +25,7 @@ void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity);
>
> DECLARE_PER_CPU(unsigned long, freq_scale);
>
> -static inline
> -unsigned long topology_get_freq_scale(int cpu)
> +static inline unsigned long topology_get_freq_scale(int cpu)
You are doing two different things in this patch :(
Reformatting the function names are fine, but that has nothing to do
with dropping the "struct sched_domain;" line. Please split into 2
different patches.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-10 16:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-07 11:49 [PATCH] drivers base/arch_topology: Remove 'struct sched_domain' forward declaration Dietmar Eggemann
2020-02-07 15:48 ` Sudeep Holla
2020-02-10 15:20 ` Dietmar Eggemann
-- strict thread matches above, loose matches on Subject: below --
2020-02-10 15:24 Dietmar Eggemann
2020-02-10 16:02 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).