From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B74FC352A3 for ; Mon, 10 Feb 2020 12:07:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E2C7208C3 for ; Mon, 10 Feb 2020 12:07:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fFZMuQ1S"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V3x3tAoU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E2C7208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KF6vHKjbBiFUDFliezOX8LNE4Njnmim0ViqGSBEqzGQ=; b=fFZMuQ1SwlWYG4 RJO7+Y7daj9qsngYiwp15gGMqS2ho1J/c7xvn39q6ynLGoqI/4YINSTEUlTOr013RbkOpd6QqL1rE XlRjeium0LOllMxBf2kmYAf50bU6MjqQPZ2pOZ/3WobjcfJ0Aqxj7fjaNNqcTULr/HIVWedHEMdl9 lTsVSNr6bEpTvhvJHBdizC62bWYDG3/xNsoER9vyZ255Y9tUpQFnhscknoL3eWnHGvjnaYkViUJ6E Hbcs7KQhAh9pxx0yq5/NHTFWIPxmNMvcXB580cp8PNcHkjP/I+qi4eJ7OeJiCrbd49YhmbDyP9YJJ 8q81EXD8oeALLZVDETAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j17qi-0007iw-Vg; Mon, 10 Feb 2020 12:07:36 +0000 Received: from us-smtp-1.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j17qe-0007hN-R9 for linux-arm-kernel@lists.infradead.org; Mon, 10 Feb 2020 12:07:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581336450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4M76XTB9sAOomIvEeEdwDoPllW+ZIvVf68kWvwXXC6A=; b=V3x3tAoU1zZI6Y+McQcyRPEdPcY19iP5GbqZMryRStoErSBnhhHxNtX7SZqpZMgInIBqiR Xgp+pmkCARSPUcnvIyB5tdH64fitF+lNRYrDuIPAiVasqo0ZwwZC+jaCs/32+73LWIyA80 0T7vZf656JP3fXc+vO6Ga+PSKIIyJH0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-YSv7_ONjOOiohpLZfF_7Qg-1; Mon, 10 Feb 2020 07:07:25 -0500 X-MC-Unique: YSv7_ONjOOiohpLZfF_7Qg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 20659477; Mon, 10 Feb 2020 12:07:23 +0000 (UTC) Received: from krava (unknown [10.43.17.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 521CD5C1D4; Mon, 10 Feb 2020 12:07:17 +0000 (UTC) Date: Mon, 10 Feb 2020 13:07:15 +0100 From: Jiri Olsa To: John Garry Subject: Re: [PATCH RFC 4/7] perf pmu: Rename uncore symbols to include system PMUs Message-ID: <20200210120715.GC1907700@krava> References: <1579876505-113251-1-git-send-email-john.garry@huawei.com> <1579876505-113251-5-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1579876505-113251-5-git-send-email-john.garry@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200210_040733_004492_C9DAE4BE X-CRM114-Status: GOOD ( 13.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, ak@linux.intel.com, suzuki.poulose@arm.com, peterz@infradead.org, robin.murphy@arm.com, linuxarm@huawei.com, acme@kernel.org, linux-kernel@vger.kernel.org, zhangshaokun@hisilicon.com, alexander.shishkin@linux.intel.com, mingo@redhat.com, james.clark@arm.com, namhyung@kernel.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 24, 2020 at 10:35:02PM +0800, John Garry wrote: SNIP > /* Only split the uncore group which members use alias */ > - if (!evsel->use_uncore_alias) > + if (!evsel->use_uncore_or_system_alias) > goto out; > > /* The events must be from the same uncore block */ > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > index 8b99fd312aae..569aba4cec89 100644 > --- a/tools/perf/util/pmu.c > +++ b/tools/perf/util/pmu.c > @@ -623,7 +623,7 @@ static struct perf_cpu_map *pmu_cpumask(const char *name) > return NULL; > } > > -static bool pmu_is_uncore(const char *name) > +static bool pmu_is_uncore_or_sys(const char *name) so we detect uncore PMU by checking for cpumask file I don't see the connection here with the sysid or '_sys' checking, that's just telling which ID to use when looking for an alias, no? shouldn't that be separated? jirka _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel