From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-arm-kernel@lists.infradead.org, mripard@kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: hwlock: Document A64 hwspinlock bindings
Date: Mon, 10 Feb 2020 10:59:35 -0800 [thread overview]
Message-ID: <20200210185935.GM955802@ripper> (raw)
In-Reply-To: <20200210170143.20007-4-nborisov@suse.com>
On Mon 10 Feb 09:01 PST 2020, Nikolay Borisov wrote:
> Add binding for the hwspinlock found on Allwinner A64 SoC.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
This does look good, but could you please rewrite this in YAML instead?
We will need review feedback from the devicetree guys, so please include
Rob and devicetree@ on your next post (i.e. run get_maintainers.pl).
Regards,
jorn
> ---
> .../bindings/hwlock/sunxi-hwspinlock.txt | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwlock/sunxi-hwspinlock.txt
>
> diff --git a/Documentation/devicetree/bindings/hwlock/sunxi-hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/sunxi-hwspinlock.txt
> new file mode 100644
> index 000000000000..af1fbf8fc9f0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwlock/sunxi-hwspinlock.txt
> @@ -0,0 +1,27 @@
> +Allwinner HwSpinlock for A64 SoC
> +=========================================
> +
> +Required properties:
> +- compatible: Should be "allwinner,sun50i-a64-hwspinlock"
> +- reg: Contains the hwspinlock module register address space
> + (base address and length)
> +- resets: phandle to the reset control for the hwspinlock
> +- clocks: phandle to the clock feeding the hwspinlock
> +- #hwlock-cells: Should be 1. The A64 hwspinlock users will use a
> + 0-indexed relative hwlock number as the argument
> + specifier value for requesting a specific hwspinlock
> + within a hwspinlock bank.
> +
> +Please look at the generic hwlock binding for usage information for consumers,
> +"Documentation/devicetree/bindings/hwlock/hwlock.txt"
> +
> +Example:
> +
> +1. Allwinner A64
> +hwspinlock: spinlock@1c18000 {
> + compatible = "allwinner,sun50i-a64-hwspinlock";
> + reg = <0x01c18000 0x1000>;
> + clocks = <&ccu CLK_BUS_SPINLOCK>;
> + resets = <&ccu RST_BUS_SPINLOCK>;
> + #hwlock-cells = <1>;
> +};
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-02-10 19:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 17:01 [PATCH 0/3] Add support for hwspinlock on A64 SoC Nikolay Borisov
2020-02-10 17:01 ` [PATCH 1/3] hwspinlock: sunxi: Implement support for Allwinner's " Nikolay Borisov
2020-02-10 18:57 ` Bjorn Andersson
2020-02-10 19:06 ` Nikolay Borisov
2020-02-10 20:05 ` Bjorn Andersson
2020-02-11 7:46 ` Maxime Ripard
2020-02-11 8:08 ` Nikolay Borisov
2020-02-11 12:34 ` Maxime Ripard
2020-02-11 13:17 ` Nikolay Borisov
2020-02-12 12:06 ` Maxime Ripard
2020-02-12 14:32 ` Nikolay Borisov
2020-02-12 19:10 ` Maxime Ripard
2020-02-10 17:01 ` [PATCH 2/3] arm64: dts: allwinner: a64: Add hwspinlock node Nikolay Borisov
2020-02-11 7:55 ` Maxime Ripard
2020-02-11 8:09 ` Nikolay Borisov
2020-02-11 12:36 ` Maxime Ripard
2020-02-10 17:01 ` [PATCH 3/3] dt-bindings: hwlock: Document A64 hwspinlock bindings Nikolay Borisov
2020-02-10 18:59 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210185935.GM955802@ripper \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mripard@kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox