From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8797FC35254 for ; Mon, 10 Feb 2020 19:00:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 479AF2085B for ; Mon, 10 Feb 2020 19:00:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n9zu9Kb9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F1E7OG0+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 479AF2085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DHcvHlnjtozXNE1kspJzI4z8wtsxpjM+3R+JJxlhfQo=; b=n9zu9Kb9Cb0/AJ LUnG1NE7Fybh9wsniXKjQrs/U/G5b7uSFGZ7wGk1HwbU0vipfVXyoacrCbFImwDlmLsGtd9NyZtZa oDGdeNMg98Z4PiwaZGx9dInCfd4OdHsVbbF6BO9rv+Kbx2d0Q97cDMwYB21QF27RM7W3aXj3sIKn8 dG0lz3zg12mfQRR18yV8Mi8HGd4WqW6EUqhB0Q/J6DLue/SZnn510tBI6WaQ3SfDg9ldK/hCn3h+i VtMydm4byoeIIGi2Q9fCTqLQxBPAZysSdFAhxj0p0HKMRCr9wwnOX2KxuIgtuC4qMKNjWtv6r2mkG beocnZt37W4NqJpNlW5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1EIF-0001Jp-4V; Mon, 10 Feb 2020 19:00:27 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1EIC-0001JO-JG for linux-arm-kernel@lists.infradead.org; Mon, 10 Feb 2020 19:00:25 +0000 Received: by mail-pj1-x1043.google.com with SMTP id m13so146212pjb.2 for ; Mon, 10 Feb 2020 11:00:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IP2SLBX7s7oABfDZ2PXfVL2aB19T/X0Xcl9B0P8WT/Q=; b=F1E7OG0+N4r9lV4soTCK3KCNKIRp+9TJO/MEoZpO8ct1N+fq6IVDt5ExeOm/qLsNLm bn3wWAX45eZopYAbVyJZ9hg+YpNQx4pDWwtLmFkI8Qj+Ijh6BEXiu467s+t+VSdY+EdT BhTMRTyB9h3Bat5sqftflJkXjNTjnXBx3rXcu4rlsWAgbAkTaCNTzhsxQsgJHq/IMW+7 pkqDRdjSqt9DH7xX4T4crvTb3DsQUxT95v6Cqv2ToQL+ve3LIHyIe5s9QCCyum9eZSOG AsgT3+GxZQbQlCX24lKOesnLKCcBFepSb+gd3fdtkGblyojJee3nv/oRXvyL7USDWFS4 hPeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IP2SLBX7s7oABfDZ2PXfVL2aB19T/X0Xcl9B0P8WT/Q=; b=lcAFNpYCHcPfOgNgc8D3uOnkAFjyf3YFFHnnVTTFnSBr64zh6MR1eytvPUFqrgvL7s kWLt+oLQTz3s+R87GDWi03oLkezd4aFmp8fo5cLbh3FmUxYG7bBraznShb38rUrLqFmR r6pBw0+c4TnKZ3KA/C8J2qG6z/fsvnUJsNS4kVCpQYlrwlwh97aaR9+50474dciLIWrg 84xpU8tBrIRrq2FVCrWeNIiboOVzNI44UsnED035Zrgywq90xBlFbUnPsxAZEFc/2cnf tDhXjVrX53Cvxdwxcj5aZsZkXrhUZ3P3V2UM8gSV4aliZShcAbQpUIIvSTMl15dwcOp5 U5hQ== X-Gm-Message-State: APjAAAVrEFNxXYUGZfd/fngVmx6/xJPZ7KcVGjy4WWO3iu5Br9OakYIs x/u2z1iw6kgfA2e+8hU+NOn05XCVtPk= X-Google-Smtp-Source: APXvYqxNY3QEOF0KJ5KimOYFaujRMyvRqJdxrh7IcsIQ2G7TQVmjP7rxLxwX2xkjWKQBZWbYMN5eDQ== X-Received: by 2002:a17:90a:3745:: with SMTP id u63mr497634pjb.123.1581361223658; Mon, 10 Feb 2020 11:00:23 -0800 (PST) Received: from ripper (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id p21sm1114597pfn.103.2020.02.10.11.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2020 11:00:22 -0800 (PST) Date: Mon, 10 Feb 2020 10:59:35 -0800 From: Bjorn Andersson To: Nikolay Borisov Subject: Re: [PATCH 3/3] dt-bindings: hwlock: Document A64 hwspinlock bindings Message-ID: <20200210185935.GM955802@ripper> References: <20200210170143.20007-1-nborisov@suse.com> <20200210170143.20007-4-nborisov@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200210170143.20007-4-nborisov@suse.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200210_110024_633603_730B7B5E X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, mripard@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 10 Feb 09:01 PST 2020, Nikolay Borisov wrote: > Add binding for the hwspinlock found on Allwinner A64 SoC. > > Signed-off-by: Nikolay Borisov This does look good, but could you please rewrite this in YAML instead? We will need review feedback from the devicetree guys, so please include Rob and devicetree@ on your next post (i.e. run get_maintainers.pl). Regards, jorn > --- > .../bindings/hwlock/sunxi-hwspinlock.txt | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwlock/sunxi-hwspinlock.txt > > diff --git a/Documentation/devicetree/bindings/hwlock/sunxi-hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/sunxi-hwspinlock.txt > new file mode 100644 > index 000000000000..af1fbf8fc9f0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwlock/sunxi-hwspinlock.txt > @@ -0,0 +1,27 @@ > +Allwinner HwSpinlock for A64 SoC > +========================================= > + > +Required properties: > +- compatible: Should be "allwinner,sun50i-a64-hwspinlock" > +- reg: Contains the hwspinlock module register address space > + (base address and length) > +- resets: phandle to the reset control for the hwspinlock > +- clocks: phandle to the clock feeding the hwspinlock > +- #hwlock-cells: Should be 1. The A64 hwspinlock users will use a > + 0-indexed relative hwlock number as the argument > + specifier value for requesting a specific hwspinlock > + within a hwspinlock bank. > + > +Please look at the generic hwlock binding for usage information for consumers, > +"Documentation/devicetree/bindings/hwlock/hwlock.txt" > + > +Example: > + > +1. Allwinner A64 > +hwspinlock: spinlock@1c18000 { > + compatible = "allwinner,sun50i-a64-hwspinlock"; > + reg = <0x01c18000 0x1000>; > + clocks = <&ccu CLK_BUS_SPINLOCK>; > + resets = <&ccu RST_BUS_SPINLOCK>; > + #hwlock-cells = <1>; > +}; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel