From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B11DBC352A3 for ; Tue, 11 Feb 2020 14:47:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F3BA206DB for ; Tue, 11 Feb 2020 14:47:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Sl1KQLbe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PVTfC144" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F3BA206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XJ8b/dOKAUOujjOnX/RjCGc2dZHfgdcG6CS9oynO1CI=; b=Sl1KQLbe2DJmFH bibWwoRjxlS7Ov9SPLL/690h0jrZa/I6lCxIF6mZsxrsVSHiyZ2mv2PaVorg0RqKqcVPO3Upv727l eY1SY+WFN13SLaNw44ZGMBttS9bxz/8+F/5KmlAQ3iGWs/sS9gUHY1nh0Il9ebHB+xEOrlOD8XcwN Z/yZFAQRsSC6XjAH8jqTon+4+cfNKS+dijR4+XeBRPZk2ZW7D9s5V93cbIfaeCXxguzT2mu+slx8V xlm6emfa+3pXfwxhum5mK9qU5weyDUjXBXgHHblUOt+m7tMkU4yOoz0QbiBiPtMcdexIVhpTuER5W 6cz/Z7L98Srn36wxlqBQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1Wog-0003En-2H; Tue, 11 Feb 2020 14:47:10 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1Woc-0003E5-Om for linux-arm-kernel@lists.infradead.org; Tue, 11 Feb 2020 14:47:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581432425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AREW9gFLm5gusZ2z//TUVRAYCVObZ/wwLl56roh1D+s=; b=PVTfC144B4GMKc+1mqqmEnQrIIZS2ktOCjYLqCTi4QS401ZAoJ4JhfGZ5VNriXIBSMoQbO lMuo8lXstqeVATX6zHOfu/bydLrCqjmtHtoQQDsRQI4aHVSLFIwDbmGF3OHjH213pWNNO3 1LuiAdYsZlSLqg0trNIcA95baHlR+R0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-241-JvW_ZqV2OTyZrIbkaNku0g-1; Tue, 11 Feb 2020 09:47:01 -0500 X-MC-Unique: JvW_ZqV2OTyZrIbkaNku0g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C5EB10054E3; Tue, 11 Feb 2020 14:46:58 +0000 (UTC) Received: from krava (ovpn-206-93.brq.redhat.com [10.40.206.93]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47FE55C240; Tue, 11 Feb 2020 14:46:54 +0000 (UTC) Date: Tue, 11 Feb 2020 15:46:51 +0100 From: Jiri Olsa To: John Garry Subject: Re: [PATCH RFC 3/7] perf jevents: Add support for a system events PMU Message-ID: <20200211144651.GD93194@krava> References: <1579876505-113251-1-git-send-email-john.garry@huawei.com> <1579876505-113251-4-git-send-email-john.garry@huawei.com> <20200210120749.GF1907700@krava> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_064706_881541_BF6B0134 X-CRM114-Status: GOOD ( 21.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, ak@linux.intel.com, suzuki.poulose@arm.com, peterz@infradead.org, robin.murphy@arm.com, linuxarm@huawei.com, acme@kernel.org, linux-kernel@vger.kernel.org, zhangshaokun@hisilicon.com, alexander.shishkin@linux.intel.com, mingo@redhat.com, james.clark@arm.com, namhyung@kernel.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 10, 2020 at 03:55:00PM +0000, John Garry wrote: > On 10/02/2020 12:07, Jiri Olsa wrote: > > On Fri, Jan 24, 2020 at 10:35:01PM +0800, John Garry wrote: > > > > SNIP > > > > > - Set of 'PMU events tables' for all known CPUs in the architecture, > > > @@ -83,11 +93,11 @@ NOTES: > > > 2. The 'pmu-events.h' has an extern declaration for the mapping table > > > and the generated 'pmu-events.c' defines this table. > > > - 3. _All_ known CPU tables for architecture are included in the perf > > > - binary. > > > + 3. _All_ known CPU and system tables for architecture are included in > > > + the perf binary. > > > -At run time, perf determines the actual CPU it is running on, finds the > > > -matching events table and builds aliases for those events. This allows > > > +At run time, perf determines the actual CPU or system it is running on, finds > > > +the matching events table and builds aliases for those events. This allows > > > users to specify events by their name: > > > $ perf stat -e pm_1plus_ppc_cmpl sleep 1 > > > @@ -150,3 +160,18 @@ where: > > > i.e the three CPU models use the JSON files (i.e PMU events) listed > > > in the directory 'tools/perf/pmu-events/arch/x86/silvermont'. > > > + > > > +The mapfile_sys.csv format is slightly different, in that it contains a SYSID > > > +instead of the CPUID: > > > + > > > + Header line > > > + SYSID,Version,Dir/path/name,Type > > > > Hi jirka, > > > can't we just add prefix to SYSID types? like: > > > > SYSID-HIP08,v1,hisilicon/hip08/sys,sys > > 0x00000000480fd010,v1,hisilicon/hip08/cpu,core > > 0x00000000500f0000,v1,ampere/emag,core > > > > because the rest of the line is the same, right? > > I did consider that already. It should be workable. > > > > > seems to me that having one mapfile type would be less confusing > > I thought that having it all in a single file would be more confusing :) hum, I think that if we keep it separated like: SYSID-HIP08,v1,hisilicon/hip08/sys,sys SYSID-krava,v1,hisilicon/krava/sys,sys 0x00000000480fd010,v1,hisilicon/hip08/cpu,core 0x00000000500f0000,v1,ampere/emag,core then we should be fine.. not too many humans read that file anyway ;-) jirka _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel