From: Will Deacon <will@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel
Date: Wed, 12 Feb 2020 10:49:03 +0000 [thread overview]
Message-ID: <20200212104902.GA3664@willie-the-truck> (raw)
In-Reply-To: <1581467841-25397-1-git-send-email-leoyang.li@nxp.com>
On Tue, Feb 11, 2020 at 06:37:20PM -0600, Li Yang wrote:
> Commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module")
> introduced a side effect that changed the module name from arm-smmu to
> arm-smmu-mod. This breaks the users of kernel parameters for the driver
> (e.g. arm-smmu.disable_bypass). This patch changes the module name back
> to be consistent.
>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> ---
> drivers/iommu/Makefile | 4 ++--
> drivers/iommu/{arm-smmu.c => arm-smmu-common.c} | 0
> 2 files changed, 2 insertions(+), 2 deletions(-)
> rename drivers/iommu/{arm-smmu.c => arm-smmu-common.c} (100%)
Can't we just override MODULE_PARAM_PREFIX instead of renaming the file?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-12 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 0:37 [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel Li Yang
2020-02-12 10:49 ` Will Deacon [this message]
2020-02-12 19:59 ` Li Yang
2020-02-13 9:16 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212104902.GA3664@willie-the-truck \
--to=will@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox