From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D425C2BA83 for ; Thu, 13 Feb 2020 09:16:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2B3F20848 for ; Thu, 13 Feb 2020 09:16:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FthviDoa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tl6c66Z/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2B3F20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2V5MTm08x26TD4MDUUsAf6UTRRZKHFZPeHFKGe+ALZU=; b=FthviDoawo+Az+ OM+GINgB9o+gbHfZxAFFezwoJ8OsK3ip78+y/k0jFE9mq8xEg5GW8u+fm2TpGdYx538r2URF4B15e HTVDjshgGUsYfWDCDjGclDmTxQjTKRtQ0qHCujiqIA4jNxMCr1UVcXkA1pVx5KNaQfs8Wrz/Q3Kky knYlZXokDaobouMQMTbd1Ih9R76srDshLqD+IeQU2xhMMV9ZlNSBtFyxpWHlpeOh7vuyUWbhys6wT o6B7jj+dwIbq5ejTgzjXZo+/7YEaVFBTYWAA0agf48IjV4cgsNb3oX4LeSxipBLPBPotIEhbKioFH B30JovgUZqZmgEGgPWtg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2Ac0-00040P-Lm; Thu, 13 Feb 2020 09:16:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2Abv-0003w3-L5 for linux-arm-kernel@lists.infradead.org; Thu, 13 Feb 2020 09:16:41 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4556620848; Thu, 13 Feb 2020 09:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581585398; bh=GiebtmJpNzAk9Qikj9svaXnffKSNLaoVx4iZEJ1f9R8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tl6c66Z/muXXGGsR8OFmt//7oEMoFMLpSOdMqTmIZMcSapkUUhJ5KhzDiPIeGnuRs s6L05Zr2yBZTqQxPgrTxwf/vJZuS09jUreCa650odBkGyci7sfrn50FK2D+S/FgaEJ hzkiirULO+oY9fiFM996uGnX90vfzqRz2rcR9e4g= Date: Thu, 13 Feb 2020 09:16:33 +0000 From: Will Deacon To: Li Yang Subject: Re: [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel Message-ID: <20200213091633.GA849@willie-the-truck> References: <1581467841-25397-1-git-send-email-leoyang.li@nxp.com> <20200212104902.GA3664@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200213_011639_736953_8D23D0CB X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg Roedel , Will Deacon , lkml , Russell King - ARM Linux admin , Linux IOMMU , Robin Murphy , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 12, 2020 at 01:59:46PM -0600, Li Yang wrote: > On Wed, Feb 12, 2020 at 4:50 AM Will Deacon wrote: > > > > On Tue, Feb 11, 2020 at 06:37:20PM -0600, Li Yang wrote: > > > Commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module") > > > introduced a side effect that changed the module name from arm-smmu to > > > arm-smmu-mod. This breaks the users of kernel parameters for the driver > > > (e.g. arm-smmu.disable_bypass). This patch changes the module name back > > > to be consistent. > > > > > > Signed-off-by: Li Yang > > > --- > > > drivers/iommu/Makefile | 4 ++-- > > > drivers/iommu/{arm-smmu.c => arm-smmu-common.c} | 0 > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > rename drivers/iommu/{arm-smmu.c => arm-smmu-common.c} (100%) > > > > Can't we just override MODULE_PARAM_PREFIX instead of renaming the file? > > I can do that. But on the other hand, the "mod" in the module name > arm-smmu-mod.ko seems to be redundant and looks a little bit weird. > Wouldn't it be cleaner to make it just arm-smmu.ko? I just didn't fancy renaming the file because it's a pain for backports and why does the name of the module matter? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel