From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A02C2BA83 for ; Fri, 14 Feb 2020 13:09:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56D852086A for ; Fri, 14 Feb 2020 13:09:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rcyvMLDd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ew9lNr98" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56D852086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rvgQcc7w41K+3Hl0/iLYFf3xfdmZWoQhf08FgzdXPv8=; b=rcyvMLDdGC1gtC OJVY+E6uu4/uE3kUOL4FdwZvtnJRqIFz3ULAkSRONMbdvGysjM+uTRA7FQESXS6dOlQ9I+N007cMD X5Yyf9VyzwZ+6CHOhL5LDUurlGYEIJbfVXuEThdz3l6qX8Egc8GlHw/mwy6oRjHJtupP6ErGVR4h5 QdO2cDt40pb+iLEFNgv5m+GjZoJjbdSKj7XcCRHngbpJGX7PJtzslbZ6Jfc9waipoxDl85GS+S/SI YBkJ2M3hskyRl+lqIccRHAvVZJGUqgiXmRxaKArZRdRn8XPOVCV/skA2KiQvn+vV3GJ8kOFRzKDtc qltWU8uov4V7XuQ1wPEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2aiq-0004BN-LE; Fri, 14 Feb 2020 13:09:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2ain-0004B3-Nd for linux-arm-kernel@lists.infradead.org; Fri, 14 Feb 2020 13:09:31 +0000 Received: from localhost (unknown [106.201.58.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D02F02086A; Fri, 14 Feb 2020 13:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581685769; bh=S1KcqlRgaFv8iW8vw5VXuHf37fRz7NJhUiPg/24MFmM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ew9lNr986QqTsMdVyURhpqV13JrXJfHXSDcBF5HSqYvPETinKZMV+FMEHTwrmmt3U EIcpnBgGSAfUYY4ClcqTE+zYekP6sLxR/JYKRQEhz3TmEIqTSzBlWZuK7Ypjmj4uXs ukwSWiU+C5n8Je0aDM44pz4T1WHEwJoU6Ig29yDk= Date: Fri, 14 Feb 2020 18:39:23 +0530 From: Vinod Koul To: Stephen Boyd Subject: Re: [PATCH v2 6/7] clk: qcom: gcc: Add global clock controller driver for SM8250 Message-ID: <20200214130923.GV2618@vkoul-mobl> References: <1579905147-12142-1-git-send-email-vnkgutta@codeaurora.org> <1579905147-12142-7-git-send-email-vnkgutta@codeaurora.org> <20200205194022.C5E8C20730@mail.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200205194022.C5E8C20730@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_050929_812222_E688DA0F X-CRM114-Status: GOOD ( 13.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, tdas@codeaurora.org, jshriram@codeaurora.org, linux-arm-msm@vger.kernel.org, mturquette@baylibre.com, tsoni@codeaurora.org, vnkgutta@codeaurora.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, psodagud@codeaurora.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05-02-20, 11:40, Stephen Boyd wrote: > > +static const struct clk_parent_data gcc_parent_data_2[] = { > > + { .fw_name = "bi_tcxo" }, > > + { .fw_name = "sleep_clk", .name = "sleep_clk" }, > > Please drop .name Yup, will do > > +static const struct clk_parent_data gcc_parent_data_5[] = { > > + { .fw_name = "bi_tcxo" }, > > + { .hw = &gpll0.clkr.hw }, > > + { .fw_name = "aud_ref_clk", .name = "aud_ref_clk" }, > > Why have .name? Pleas remove it. Dropped... > > + { .hw = &gpll0_out_even.clkr.hw }, > > + { .fw_name = "core_bi_pll_test_se", .name = "core_bi_pll_test_se" }, > > Please drop these test inputs. I don't see any reason why they're listed. Dropped this and rest. > > +static struct clk_branch gcc_sys_noc_cpuss_ahb_clk = { > > + .halt_reg = 0x48198, > > + .halt_check = BRANCH_HALT_VOTED, > > + .clkr = { > > + .enable_reg = 0x52000, > > + .enable_mask = BIT(0), > > + .hw.init = &(struct clk_init_data){ > > + .name = "gcc_sys_noc_cpuss_ahb_clk", > > + .parent_data = &(const struct clk_parent_data){ > > + .hw = &gcc_cpuss_ahb_postdiv_clk_src.clkr.hw, > > + }, > > + .num_parents = 1, > > + .flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, > > + .ops = &clk_branch2_ops, > > + }, > > + }, > > +}; > > Is there a need for this clk to be exposed? Why can't we just turn the > bit on in probe and ignore it after that? I'd prefer to not have > CLK_IS_CRITICAL in this driver unless necessary. yeah moved it as setting a bit in probe.. > > + /* > > + * Keep the clocks always-ON > > + * GCC_VIDEO_AHB_CLK, GCC_CAMERA_AHB_CLK, GCC_DISP_AHB_CLK, > > + * GCC_CPUSS_DVM_BUS_CLK, GCC_GPU_CFG_AHB_CLK > > + */ > > + regmap_update_bits(regmap, 0x0b004, BIT(0), BIT(0)); > > + regmap_update_bits(regmap, 0x0b008, BIT(0), BIT(0)); > > + regmap_update_bits(regmap, 0x0b00c, BIT(0), BIT(0)); > > + regmap_update_bits(regmap, 0x4818c, BIT(0), BIT(0)); > > + regmap_update_bits(regmap, 0x71004, BIT(0), BIT(0)); > > These look like the AHB clks above that we just enabled and then ignore. right, I think these are rest of the always-on clocks -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel