From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF90AC2BA83 for ; Fri, 14 Feb 2020 18:04:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C28E20848 for ; Fri, 14 Feb 2020 18:04:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OFpe0SFD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C28E20848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q4Hoo5KUNk5MQJj8hJVYbQI7STM8gDrrBhT+PEV+Gnc=; b=OFpe0SFDrenHtU ZE2hPzhfJoNWxxQ0K9z+h9VC7JtHHbqC3JHISGn/TWFjsGeHUC5E7nPqgcYKNE44d1e1Y53ZAJchV 2NKUXPGO3WHtp6DcatThCc1leP/M2AQnhs33ULpu5wY0wo4BborNf13sujA1xzE2Frqwqt7qRCrwT 6N25sEVSp0pWriBAhfHaNC5W222xce8ZnLBVmZvQ55bQQz72SJBSZ709RecI0drYqx2Bj4vTxooqd fSXu5tz9DD+2RCWrmNS2hRsxFoUPRq5UUROaUpBb9quwyF5NgWh/gwTXR0qgiWnC2f9JHd1vpYoOe SoBdzdeB3n3/mW4PJ94w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2fK0-0005RY-Vl; Fri, 14 Feb 2020 18:04:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2fJx-0005QZ-KH for linux-arm-kernel@lists.infradead.org; Fri, 14 Feb 2020 18:04:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A21F328; Fri, 14 Feb 2020 10:04:08 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 344FD3F68E; Fri, 14 Feb 2020 10:04:07 -0800 (PST) Date: Fri, 14 Feb 2020 18:04:04 +0000 From: Andre Przywara To: Maxime Ripard , Mark Rutland , Rob Herring Subject: Re: [PATCH 1/2] arm64: dts: allwinner: h5: Fix PMU compatible Message-ID: <20200214180404.24d67f86@donnerap.cambridge.arm.com> In-Reply-To: <20200210095600.77894-1-maxime@cerno.tech> References: <20200210095600.77894-1-maxime@cerno.tech> Organization: ARM X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_100409_710672_FBC3383E X-CRM114-Status: GOOD ( 20.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, Maxime Ripard Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 10 Feb 2020 10:55:59 +0100 Maxime Ripard wrote: Hi, > The commit c35a516a4618 ("arm64: dts: allwinner: H5: Add PMU node") > introduced support for the PMU found on the Allwinner H5. However, the > binding only allows for a single compatible, while the patch was adding > two. Maxime, thanks for bringing this up, was that found by some validation tool? And while this is true, I wonder if this was intentional? I see several other combinations of PMU compatibles in the tree. Mark, Rob, can you shed any light on this? Actually I am wondering why we would need the PMU type in the first place, isn't that discoverable via the MIDR? And all we actually need from the DT is the interrupts and maybe some quirk info? It looks like ACPI is always using the generic PMUv3 map, so wouldn't it actually be better to replace the compatible string matching with MIDR matching? Or are those core specific maps somewhat obsolete anyway? Since I don't see any newer cores in there? Cheers, Andre > Make sure we follow the binding. > > Fixes: c35a516a4618 ("arm64: dts: allwinner: H5: Add PMU node") > Signed-off-by: Maxime Ripard > --- > arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > index 9893aa64dd0b..4462a68c0681 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > @@ -38,8 +38,7 @@ cpu3: cpu@3 { > }; > > pmu { > - compatible = "arm,cortex-a53-pmu", > - "arm,armv8-pmuv3"; > + compatible = "arm,cortex-a53-pmu"; > interrupts = , > , > , _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel