From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA31C3B1BF for ; Sat, 15 Feb 2020 00:58:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2404C2073A for ; Sat, 15 Feb 2020 00:58:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H+lhKKfE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LJ7VCwPE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2404C2073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZjKbqk9JRlGTGG/J0ruca7C2c2gEm16F8FNJmOmvvNo=; b=H+lhKKfEKdCKzh N83i7qO5edF7gkMYzR9MfctNtJlBbBZtlYWvlYlWkqXCtFEQBlXYVankrLHDdRY42M2mqUVE7KLpX akGmCfe+B6gIZAaV6lmMxjjFPL36aMG/4+63AuzpfGT7x5j3Dzn9AO2NmnJZZzSyHpajXuHN3U+j/ qKXfIjxN5aUQLHUJ4+FJqFebi5LBgQVjQ4hpNCbab8pzHsu7ItwBUQJAfm5fTijrHrZ3gDJuUx2Ug r5B8DQhEZk5J6TyBwgKbQRNp3naKL5eR2LeqQF3tJhp2q6aRPy45YKRdWCG7BwZNVHQiEFIz7921j 7LfK8fxaYDaH3qS2Hp4A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2ln9-0007ha-O7; Sat, 15 Feb 2020 00:58:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2ln6-0007h6-1a for linux-arm-kernel@lists.infradead.org; Sat, 15 Feb 2020 00:58:41 +0000 Received: from localhost (unknown [38.98.37.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9BFF720726; Sat, 15 Feb 2020 00:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581728318; bh=epAipassIVTXLEk61xbPswQ/wJFZR8JeHH7+aNFL18w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LJ7VCwPEWnIEAj+lS8iPopr8Gi5FgFwj1wdOvOdgCLWp/8gK/V4Ij8yF6l734w1Cf n0D+VkC39CWrj1swmFEjR1TCM2g9XODsAG9y930H/cSJzSGIvYyyXCTw1obME+cKus SU8s68S+0oKLyV1ne3cxnSsHAmp0LQX5c6pSXhaE= Date: Fri, 14 Feb 2020 19:52:35 -0500 From: 'Greg KH' To: Jolly Shah Subject: Re: [PATCH v2 1/4] firmware: xilinx: Add sysfs interface Message-ID: <20200215005235.GA32359@kroah.com> References: <20200124060339.GB2906795@kroah.com> <2D4B924A-D10C-4A90-A8E6-507BF6C30654@xilinx.com> <20200128062814.GA2097606@kroah.com> <4EF659A1-2844-46B9-9ED6-5A6A20401D9D@xilinx.com> <20200131061038.GA2180358@kroah.com> <20200131093646.GA2271937@kroah.com> <3ef20e9d-052f-665c-7fc8-69a1f8bc9bd2@xilinx.com> <20200214171005.GB4034785@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_165840_106896_1AABB785 X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "keescook@chromium.org" , "ard.biesheuvel@linaro.org" , "matt@codeblueprint.co.uk" , "dmitry.torokhov@gmail.com" , "linux-kernel@vger.kernel.org" , Rajan Vaja , Michal Simek , "sudeep.holla@arm.com" , "mingo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "hkallweit1@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 14, 2020 at 04:37:16PM -0800, Jolly Shah wrote: > > Just make the direct call to the firmware driver, no need to muck around > > with tables of function pointers. In fact, with the spectre changes, > > you just made things slower than needed, and you can get back a bunch of > > throughput by removing that whole middle layer. > > > > arm,scpi is doing the same way and we thought this approach will be more > acceptable than direct function calls but happy to change as suggested. Just because one random tiny thing does it the wrong way does not mean to focus on that design pattern and ignore the thousands of other apis/interfaces in the kernel that do not do it that way :) > > So go do that first please, before adding any new stuff. > > > > Now for the ioctl, yeah, that's not a "normal" pattern either. But > > right now you only have 2 "different" ioctls that you call. So why not > > just turn those 2 into real function calls as well that then makes the > > "ioctl" call to the hardware? That makes things a lot more obvious on > > the kernel driver side exactly what is going on. > > > > Sure as i understand firmware driver will provide real function calls to be > used by user drivers and underneath it will call ioctl for desired > operation. Please correct if I misunderstood. You do not misunderstand. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel