From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3735DC35242 for ; Mon, 17 Feb 2020 07:42:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09A36206D5 for ; Mon, 17 Feb 2020 07:42:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qIBj49NU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ie061spF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ehZecdFb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09A36206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/IQ2tUmnzFTb5Rz3tO4Ut6yzhJeyZIwTWrM0YwOfz4s=; b=qIBj49NUbeUoVI +9GgNOSxi4ZCZNnSAHnF7RtG5MFks2GM3Pe4sY1XZ2bKRGI6ShjCddxXmcQjChI+EZZZVfgBJLkyN /obhB9/cvqAOM1IgZLVwo3a2pJ/JAeVWSCdtqMecj456WK9/PDTYXeH67JBTNYMvBgajA8oLQMd/5 lFHs6MDrrEti69g8uDlI2esJH5ZFWwsdonUcVbILY/2DxnBd24xTKmP4woPz9KckGOMdZbNRnaKJz voUacnu5UYhFLVPl9jIz6K0Svy7pw5m9akEh8Gy5W3NtNiN01+RPke+mYzsivHoGWgaPcOtRKlpY+ fZfjlmVUIWdy7POhsURA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3b2r-0004Vk-09; Mon, 17 Feb 2020 07:42:21 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3b2o-0004Vc-Sq for linux-arm-kernel@bombadil.infradead.org; Mon, 17 Feb 2020 07:42:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description; bh=hqMNovNPLBTkcDZOPcJd85GoyTDK28xkZ5YRxHDZcBM=; b=ie061spF1JdJmwzdGZphceeSIP xs23p8a4AxWOA7drUweshdqOm6j8bm2qZzM/SueJa4le0XIWNzOQCEwDTmENqgdLB1LMIQdacWqyl GeC2N4T7fnNVebt/IWJ+3p9m3A4YvSjmBuFKI3DSDge0PgVL/ZTgb6kJ337PgC3tcZtRts7z2y+mn YuKX7sKZ7JxoH92WxyZX2WgaRWEFGQGflO9y9hEZBDLXOJunppN3faA1CADSgXDH/K8skhc4W8Qbn T6lZsskiw8Rt7XFSPm1Z2Mp7Ga/y+VoGsHp2jGhFntil6tSV1rQ6bdFqyubbdPwI/Leanc/IL4tGE 4UK9r11g==; Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3b2l-0005oH-OL for linux-arm-kernel@lists.infradead.org; Mon, 17 Feb 2020 07:42:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581925313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hqMNovNPLBTkcDZOPcJd85GoyTDK28xkZ5YRxHDZcBM=; b=ehZecdFbhkDmpuogn/fGY4Hn7cl2Mq+ft82DOojzr8RiU2EyV3LVGsa31VVQ2w/OnqcI7f ei9tOexGAoMJnjy5S8EXAokTScG1mr7MtqWPPmPYwdnatQCbHb+J3673J7H+kZE6FhXu8K LCLgl7kyKdVTrcKKjBRCOv7QIhBgjp8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-tvWotQ_rP52F4XbMwzS7ew-1; Mon, 17 Feb 2020 02:41:50 -0500 X-MC-Unique: tvWotQ_rP52F4XbMwzS7ew-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 94405800D53; Mon, 17 Feb 2020 07:41:47 +0000 (UTC) Received: from carbon (ovpn-200-41.brq.redhat.com [10.40.200.41]) by smtp.corp.redhat.com (Postfix) with ESMTP id 299292CC39; Mon, 17 Feb 2020 07:41:35 +0000 (UTC) Date: Mon, 17 Feb 2020 08:41:33 +0100 From: Jesper Dangaard Brouer To: Ilias Apalodimas Subject: Re: [PATCH net-next v2] net: page_pool: API cleanup and comments Message-ID: <20200217084133.1a67ae63@carbon> In-Reply-To: <20200217062850.133121-1-ilias.apalodimas@linaro.org> References: <20200217062850.133121-1-ilias.apalodimas@linaro.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Coquelin , Jakub Kicinski , Alexandre Torgue , Daniel Borkmann , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, toke@redhat.com, John Fastabend , brouer@redhat.com, Alexei Starovoitov , Jassi Brar , Jose Abreu , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , jonathan.lemon@gmail.com, Giuseppe Cavallaro , bpf@vger.kernel.org, lorenzo@kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org, Jesper Dangaard Brouer Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 17 Feb 2020 08:28:49 +0200 Ilias Apalodimas wrote: > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > index cfbed00ba7ee..7c1f23930035 100644 > --- a/include/net/page_pool.h > +++ b/include/net/page_pool.h > @@ -162,39 +162,33 @@ static inline void page_pool_use_xdp_mem(struct page_pool *pool, > } > #endif > > -/* Never call this directly, use helpers below */ > -void __page_pool_put_page(struct page_pool *pool, struct page *page, > - unsigned int dma_sync_size, bool allow_direct); > +void page_pool_release_page(struct page_pool *pool, struct page *page); > > -static inline void page_pool_put_page(struct page_pool *pool, > - struct page *page, bool allow_direct) > +/* If the page refcnt == 1, this will try to recycle the page. > + * if PP_FLAG_DMA_SYNC_DEV is set, it will try to sync the DMA area for > + * the configured size min(dma_sync_size, pool->max_len). > + * If the page refcnt != page will be returned Is this last comment line fully formed? > + */ > +void page_pool_put_page(struct page_pool *pool, struct page *page, > + unsigned int dma_sync_size, bool allow_direct); > + > +/* Same as above but will try to sync the entire area pool->max_len */ > +static inline void page_pool_put_full_page(struct page_pool *pool, > + struct page *page, bool allow_direct) -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel