* [PATCH] arm64: dts: imx8qxp-mek: Remove unexisting Ethernet PHY
@ 2020-02-17 19:15 Fabio Estevam
2020-02-17 20:09 ` Leonard Crestez
2020-02-19 2:13 ` Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Fabio Estevam @ 2020-02-17 19:15 UTC (permalink / raw)
To: shawnguo; +Cc: linux-arm-kernel, robh, Fabio Estevam, linux-imx, kernel
There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek.
Remove the unexisting ethphy1 port.
This fixes a run-time warning:
mdio_bus 5b040000.ethernet-1: MDIO device at address 1 is missing.
Fixes: fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index d3d26cca7d52..13460a360c6a 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -52,11 +52,6 @@
compatible = "ethernet-phy-ieee802.3-c22";
reg = <0>;
};
-
- ethphy1: ethernet-phy@1 {
- compatible = "ethernet-phy-ieee802.3-c22";
- reg = <1>;
- };
};
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: imx8qxp-mek: Remove unexisting Ethernet PHY
2020-02-17 19:15 [PATCH] arm64: dts: imx8qxp-mek: Remove unexisting Ethernet PHY Fabio Estevam
@ 2020-02-17 20:09 ` Leonard Crestez
2020-02-18 4:55 ` Andy Duan
2020-02-19 2:13 ` Shawn Guo
1 sibling, 1 reply; 5+ messages in thread
From: Leonard Crestez @ 2020-02-17 20:09 UTC (permalink / raw)
To: Fabio Estevam, shawnguo@kernel.org, Andy Duan
Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org,
dl-linux-imx, kernel@pengutronix.de
On 17.02.2020 21:15, Fabio Estevam wrote:
> There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek.
>
> Remove the unexisting ethphy1 port.
>
> This fixes a run-time warning:
>
> mdio_bus 5b040000.ethernet-1: MDIO device at address 1 is missing.
>
> Fixes: fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
+Andy
I remember that it's possible to get a second ethernet port through a
baseboard on imx8qxp. It's not a default option but it's real.
Unless I'm missing something?
> ---
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> index d3d26cca7d52..13460a360c6a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -52,11 +52,6 @@
> compatible = "ethernet-phy-ieee802.3-c22";
> reg = <0>;
> };
> -
> - ethphy1: ethernet-phy@1 {
> - compatible = "ethernet-phy-ieee802.3-c22";
> - reg = <1>;
> - };
> };
> };
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] arm64: dts: imx8qxp-mek: Remove unexisting Ethernet PHY
2020-02-17 20:09 ` Leonard Crestez
@ 2020-02-18 4:55 ` Andy Duan
2020-02-18 13:06 ` Leonard Crestez
0 siblings, 1 reply; 5+ messages in thread
From: Andy Duan @ 2020-02-18 4:55 UTC (permalink / raw)
To: Leonard Crestez, Fabio Estevam, shawnguo@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org,
dl-linux-imx, kernel@pengutronix.de
From: Leonard Crestez <leonard.crestez@nxp.com> Sent: Tuesday, February 18, 2020 4:10 AM
> On 17.02.2020 21:15, Fabio Estevam wrote:
> > There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek.
> >
> > Remove the unexisting ethphy1 port.
> >
> > This fixes a run-time warning:
> >
> > mdio_bus 5b040000.ethernet-1: MDIO device at address 1 is missing.
> >
> > Fixes: fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support")
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> +Andy
>
> I remember that it's possible to get a second ethernet port through a
> baseboard on imx8qxp. It's not a default option but it's real.
>
> Unless I'm missing something?
Yes, the phy is attached to second net device that is on baseboard.
Because there have pin conflict with esai0, there have another extra
dts file for it.
Andy
>
> > ---
> > arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> > b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> > index d3d26cca7d52..13460a360c6a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> > @@ -52,11 +52,6 @@
> > compatible = "ethernet-phy-ieee802.3-c22";
> > reg = <0>;
> > };
> > -
> > - ethphy1: ethernet-phy@1 {
> > - compatible = "ethernet-phy-ieee802.3-c22";
> > - reg = <1>;
> > - };
> > };
> > };
> >
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: imx8qxp-mek: Remove unexisting Ethernet PHY
2020-02-18 4:55 ` Andy Duan
@ 2020-02-18 13:06 ` Leonard Crestez
0 siblings, 0 replies; 5+ messages in thread
From: Leonard Crestez @ 2020-02-18 13:06 UTC (permalink / raw)
To: Andy Duan, Fabio Estevam, shawnguo@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org,
dl-linux-imx, kernel@pengutronix.de
On 18.02.2020 06:55, Andy Duan wrote:
> From: Leonard Crestez <leonard.crestez@nxp.com> Sent: Tuesday, February 18, 2020 4:10 AM
>> On 17.02.2020 21:15, Fabio Estevam wrote:
>>> There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek.
>>>
>>> Remove the unexisting ethphy1 port.
>>>
>>> This fixes a run-time warning:
>>>
>>> mdio_bus 5b040000.ethernet-1: MDIO device at address 1 is missing.
>>>
>>> Fixes: fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support")
>>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
>>
>> +Andy
>>
>> I remember that it's possible to get a second ethernet port through a
>> baseboard on imx8qxp. It's not a default option but it's real.
>>
>> Unless I'm missing something?
>
> Yes, the phy is attached to second net device that is on baseboard.
> Because there have pin conflict with esai0, there have another extra
> dts file for it.
Then it would be reasonable to remove ethphy1 from main dts and add it
back in -enet2.dts (which is not yet in upstream)
So Fabio's patch is correct.
Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
>>> ---
>>> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 -----
>>> 1 file changed, 5 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
>>> b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
>>> index d3d26cca7d52..13460a360c6a 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
>>> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
>>> @@ -52,11 +52,6 @@
>>> compatible = "ethernet-phy-ieee802.3-c22";
>>> reg = <0>;
>>> };
>>> -
>>> - ethphy1: ethernet-phy@1 {
>>> - compatible = "ethernet-phy-ieee802.3-c22";
>>> - reg = <1>;
>>> - };
>>> };
>>> };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: imx8qxp-mek: Remove unexisting Ethernet PHY
2020-02-17 19:15 [PATCH] arm64: dts: imx8qxp-mek: Remove unexisting Ethernet PHY Fabio Estevam
2020-02-17 20:09 ` Leonard Crestez
@ 2020-02-19 2:13 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2020-02-19 2:13 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel, robh, linux-imx, kernel
On Mon, Feb 17, 2020 at 04:15:03PM -0300, Fabio Estevam wrote:
> There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek.
>
> Remove the unexisting ethphy1 port.
>
> This fixes a run-time warning:
>
> mdio_bus 5b040000.ethernet-1: MDIO device at address 1 is missing.
>
> Fixes: fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-19 2:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-17 19:15 [PATCH] arm64: dts: imx8qxp-mek: Remove unexisting Ethernet PHY Fabio Estevam
2020-02-17 20:09 ` Leonard Crestez
2020-02-18 4:55 ` Andy Duan
2020-02-18 13:06 ` Leonard Crestez
2020-02-19 2:13 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).