From: Will Deacon <will@kernel.org>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
amit.kachhap@arm.com,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: lse: Fix LSE atomics with LLVM
Date: Tue, 18 Feb 2020 18:05:15 +0000 [thread overview]
Message-ID: <20200218180514.GA2655@willie-the-truck> (raw)
In-Reply-To: <CABCJKufJemUuh2SH_wBRe_g1HUA7mzOu696yLPj0KRCxD=DXcQ@mail.gmail.com>
On Tue, Feb 18, 2020 at 10:02:24AM -0800, Sami Tolvanen wrote:
> On Tue, Feb 18, 2020 at 8:54 AM Will Deacon <will@kernel.org> wrote:
> > > -#define __LSE_PREAMBLE ".arch armv8-a+lse\n"
> > > +#define __LSE_PREAMBLE ".arch_extension lse\n"
> >
> > I'm ok with this, but Sami assumedly changed this for a reason in
> > e0d5896bd356cd ("arm64: lse: fix LSE atomics with LLVM's integrated
> > assembler").
>
> Correct, I changed this because clang's integrated assembler wasn't
> happy with .arch_extension lse at the time. However, it looks like
> current versions of clang don't have this problem, so this change
> looks good to me.
>
> Tested-by: Sami Tolvanen <samitolvanen@google.com>
Cheers, I'll queue this with your tag.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-18 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 16:49 [PATCH] arm64: lse: Fix LSE atomics with LLVM Vincenzo Frascino
2020-02-18 16:54 ` Will Deacon
2020-02-18 17:42 ` Vincenzo Frascino
2020-02-18 18:03 ` Sami Tolvanen
2020-02-18 18:02 ` Sami Tolvanen
2020-02-18 18:05 ` Will Deacon [this message]
2020-02-18 18:11 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218180514.GA2655@willie-the-truck \
--to=will@kernel.org \
--cc=amit.kachhap@arm.com \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=samitolvanen@google.com \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox