Re: [PATCH net-next] net: page_pool: API cleanup and comments

From: kbuild test robot <lkp@intel.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	kbuild-all@lists.01.org,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	John Fastabend <john.fastabend@gmail.com>,
	Alexei Starovoitov <ast@kernel.org>,
	linux-kernel@vger.kernel.org,
	Jassi Brar <jaswinder.singh@linaro.org>,
	Jose Abreu <joabreu@synopsys.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	jonathan.lemon@gmail.com,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	bpf@vger.kernel.org, lorenzo@kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	Jesper Dangaard Brouer <hawk@kernel.org>
Subject: Re: [PATCH net-next] net: page_pool: API cleanup and comments
Date: Tue, 18 Feb 2020 18:47:43 +0800	[thread overview]
Message-ID: <202002181837.oBAZq2w3%lkp@intel.com> (raw)
In-Reply-To: <20200216094056.8078-1-ilias.apalodimas@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 2750 bytes --]

Hi Ilias,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.6-rc1]
[also build test ERROR on next-20200217]
[cannot apply to net-next/master net/master linus/master ipvs/master v5.6-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Ilias-Apalodimas/net-page_pool-API-cleanup-and-comments/20200218-163634
base:    bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9
config: i386-randconfig-b002-20200218 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: net/core/xdp.o: in function `__xdp_release_frame':
>> net/core/xdp.c:426: undefined reference to `page_pool_release_page'

vim +426 net/core/xdp.c

05296620f6d14d Jakub Kicinski         2018-07-11  415  
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  416  /* Only called for MEM_TYPE_PAGE_POOL see xdp.h */
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  417  void __xdp_release_frame(void *data, struct xdp_mem_info *mem)
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  418  {
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  419  	struct xdp_mem_allocator *xa;
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  420  	struct page *page;
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  421  
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  422  	rcu_read_lock();
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  423  	xa = rhashtable_lookup(mem_id_ht, &mem->id, mem_id_rht_params);
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  424  	page = virt_to_head_page(data);
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  425  	if (xa)
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 @426  		page_pool_release_page(xa->page_pool, page);
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  427  	rcu_read_unlock();
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  428  }
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  429  EXPORT_SYMBOL_GPL(__xdp_release_frame);
6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18  430  

:::::: The code at line 426 was first introduced by commit
:::::: 6bf071bf09d4b2ff3ee8783531e2ce814f0870cb xdp: page_pool related fix to cpumap

:::::: TO: Jesper Dangaard Brouer <brouer@redhat.com>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28439 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel