From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F41A8C34047 for ; Tue, 18 Feb 2020 19:03:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC0B224655 for ; Tue, 18 Feb 2020 19:03:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uKf4XO3w"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dQJS5bca" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC0B224655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6xpR7tCibm0c/eCgUGAqpE+4UyXN9QCmLc3YtE4MykY=; b=uKf4XO3wC7LAbgV6osf+SyNO9 522FeMmcSnZx7DmdBhZ1XDD84WIjNwPG2NMpFeP06VVocyjHo5/hpm93rFKetV9C+t0W2OTrVuBLN S2PMdNtfWs7n9f88aAZg9Z2TVc9wS9/O6E3/X4g9clAqjZti6jaewfVAHknaAEj+3CDB4+JGsqRk3 RjRy6Mqb5AQcvqtqxoYkCnF8cweX8zzJsouHmLxsOy7p6GWO/qW3GFlsqw99HiDqc5ujLueknx/EV jlkRaQxUDPUroAwMEvz68dXCqkEVmG+FqQBn0cSyjv85eszyxUp/Xs2IWu3Q04rEdeLfexNsgA5eV IRx0ECwpw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4895-0002Cp-JB; Tue, 18 Feb 2020 19:02:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4892-0002C4-Pf for linux-arm-kernel@lists.infradead.org; Tue, 18 Feb 2020 19:02:58 +0000 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1B0324655; Tue, 18 Feb 2020 19:02:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582052575; bh=yGg6yNRaAc7iDhwPELABRLvrPSnaAFrFM+ijBgVtWoo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dQJS5bcavE0VoZy3dS/+CN4EqnAgMsL2HFP6co6j0tfwA/VryfUjJD+jLWGKNgP/s 7QO45qSnZKAlxcLswZk8QyTW0yHgO6D+IZvIOhyIhkmq9+QCOiyce6wE7ufDXvGxU2 pRuXmqKCuzRTX4I3uR6QSvrSq7TyLtxmGr0TfG/w= Date: Tue, 18 Feb 2020 14:02:53 -0500 From: Sasha Levin To: Leonard Crestez Subject: Re: [PATCH] firmware: imx: Align imx SC msg structs to 4 Message-ID: <20200218190253.GW1734@sasha-vm> References: <3a8b6772a1edffdd7cdb54d6d50030b03ba0bebb.1581455751.git.leonard.crestez@nxp.com> <20200217062129.GB6790@dragon> <20200218091831.GB6075@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200218_110256_855869_3A0BB844 X-CRM114-Status: GOOD ( 10.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Alessandro Zummo , Alexandre Belloni , Abel Vesa , Anson Huang , Stephen Boyd , Michael Turquette , Stefan Agner , "open list:COMMON CLK FRAMEWORK" , Franck Lenormand , "open list:PIN CONTROLLER - FREESCALE" , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , Shawn Guo , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , "open list:REAL TIME CLOCK \(RTC\) SUBSYSTEM" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 18, 2020 at 05:48:50PM +0000, Leonard Crestez wrote: >On 18.02.2020 11:18, Shawn Guo wrote: >> On Mon, Feb 17, 2020 at 08:37:45PM +0000, Leonard Crestez wrote: >>> On 17.02.2020 08:21, Shawn Guo wrote: >>>> On Tue, Feb 11, 2020 at 11:24:33PM +0200, Leonard Crestez wrote: >>>>> The imx SC api strongly assumes that messages are composed out of >>>>> 4-bytes words but some of our message structs have sizeof "6" and "7". >>>>> >>>>> This produces many oopses with CONFIG_KASAN=y: >>>>> >>>>> BUG: KASAN: stack-out-of-bounds in imx_mu_send_data+0x108/0x1f0 >>>>> >>>>> It shouldn't cause an issues in normal use because these structs are >>>>> always allocated on the stack. >>>>> >>>>> Cc: stable@vger.kernel.org >>>> >>>> Should we have a fixes tag and send it for -rc? >>> >>> I haven't check but this would probably have to be split into multiple >>> patches because the structs were not added all at once. >> >> Or maybe we can just drop the stable tag, as it addresses a corner >> case issue which could concern very few people? > >I think that "kernel does not boot with KASAN=y" is an issue worth fixing. > >I will split and resend with appropriate Fixes: tags. > >It seems likely that this will be picked up for -stable anyway via >Sasha's automation scripts and those scripts benefit from Fixes: tags. Even if not, we realy very much on KASAN working on stable kernels, so please do fix this :) -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel