From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DC2C34047 for ; Wed, 19 Feb 2020 09:18:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1481321D56 for ; Wed, 19 Feb 2020 09:18:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KBt51lE3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CIXfl5SD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1481321D56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lDoJl3AD8jgNHYjOdA4kOZuDZUnGklNmQ6XHKXyq1qw=; b=KBt51lE304eOBA UYiU6AtzcjwwG5YThzw6fXGFKPccNT/TfzR2JMo22qn0CX798Q/S5Pzyz7ibHfoRBWqOKQEVkyE8Z 72HYeAhgMe6ghG4O6nTPr5eULlKB4oJPeoUUZhRXYw5FiLJVR3ivdPSgDKpk0IAhfFiqPDYaR92I8 p27lwfWaq4eXZj8Fa9ydcaZZDsgMFLrgeMEseCkUJMHLfaQtoF3xaKL7vk/TW1bpsl5tQzNVCgbpM CbmdrRdwBj2cgo+76kOFYuej1MpTQBTV0KdUpSrngEtvI21XC/n4q0EwxLcyHfEZYMNAAoS+nudTe ypvDC0nXDhOvR0h85f+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4LUZ-00082B-0U; Wed, 19 Feb 2020 09:18:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4LUV-00081P-D6 for linux-arm-kernel@lists.infradead.org; Wed, 19 Feb 2020 09:18:00 +0000 Received: from localhost (unknown [106.201.32.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4DE721D56; Wed, 19 Feb 2020 09:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582103878; bh=ryVYryIobjSVx+pW5LLK3jBFpRtMoBclGB/Qtjpwt50=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CIXfl5SDg41ZN+XnQWii24UwvPYahnAiB2YtjcP82LkH/oPN2mGKXD7mWbshweBCg RxrkqewZvqYYpeDWTrIUMCL+ogeyBS7gPSwdzvlikwGXX/X+Z8C6yOcCf6x8ON0uXU 7r507UQVbro9oQ/Gykr82vkDdUBycSuBbXEncAY8= Date: Wed, 19 Feb 2020 14:47:54 +0530 From: Vinod Koul To: Geert Uytterhoeven , Linus Walleij Subject: Re: [PATCH] dmaengine: coh901318: Fix a double lock bug in dma_tc_handle() Message-ID: <20200219091754.GE2618@vkoul-mobl> References: <20200217144050.3i4ymbytogod4ijn@kili.mountain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_011759_466137_A0FDDAC1 X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, Jia-Ju Bai , Dan Carpenter , dmaengine , Dan Williams , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17-02-20, 23:24, Geert Uytterhoeven wrote: > Hi Dan, > > On Mon, Feb 17, 2020 at 3:41 PM Dan Carpenter wrote: > > The caller is already holding the lock so this will deadlock. > > > > Fixes: 0b58828c923e ("DMAENGINE: COH 901 318 remove irq counting") > > Signed-off-by: Dan Carpenter > > --- > > This is the second double lock bug found using static analysis. The > > previous one was commit 627469e4445b ("dmaengine: coh901318: Fix a > > double-lock bug"). > > > > The fact that this has been broken for ten years suggests that no one > > has the hardware. > > Or this only runs CONFIG_SMP=n kernels? > This seems to be used in arch/arm/boot/dts/ste-u300.dts only, and > CONFIG_ARCH_U300 is a ARCH_MULTI_V5 platform, which looks like > it doesn't support SMP? Should we drop the driver then..? -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel