From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD911C11D05 for ; Thu, 20 Feb 2020 14:17:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CC21206E2 for ; Thu, 20 Feb 2020 14:17:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="InSbJvoI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KGwHxUG7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CC21206E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IzN+ABaKsUUH4Gw0uJE0oQOYy//h5R7xq5Z+eAly0x8=; b=InSbJvoIfzBnRj a9VC+NWRJxkSS29xdIBHPRUKAd4rQ5aDB9m1UsDrmNUbd86oAJmtKnbCmE11gfiMorgIowGAIvb3a VqqnFRUntcTPSvIxuyFNLQ8OXZuDjKcPM3vTAJk3wf1xMXer9+W/rVozPB5hjnADufaeFUp6ubdGM Q3ev0sMT0MpDjin+xtBOI48W4u43FA7P/zFhz/qwmF+p0bhG1jAArwVnQTgwP6ETI9or5ruNWmcJX fPJaUALbnTKtpeQBug+ug+T9CiYlmDytZ4dQ5f4Kcdq0DYg+OK+gBhEpGQ80r02g2vAPKznKqfaIr b0AxpQGV8x6gud/x9tiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4meF-00031A-4A; Thu, 20 Feb 2020 14:17:51 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4meC-00030H-0F for linux-arm-kernel@lists.infradead.org; Thu, 20 Feb 2020 14:17:49 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B7561563; Thu, 20 Feb 2020 15:17:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582208263; bh=bI53Zug+890prNNaPfPGhR8GpYv+Klbg8yJ37Qnbv4A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KGwHxUG7b/Z2UkYUp9M/oxLXj3mb0DpKs8DSFQyfN6VrcdC9FiYW/vH3DHE9hKJiM qtAGmy5/ZUui2EMb2r4xc911A8o4H9PS8FCT7JlsTFVzthx1bNVc/UHvri25X+ueKc abTm7XDPazs+OtI+5sUlO+NXZFjNOd/npqA+0alY= Date: Thu, 20 Feb 2020 16:17:25 +0200 From: Laurent Pinchart To: Vasily Khoruzhick Subject: Re: [PATCH 6/6] arm64: allwinner: a64: enable LCD-related hardware for Pinebook Message-ID: <20200220141725.GG4998@pendragon.ideasonboard.com> References: <20200220083508.792071-1-anarsoul@gmail.com> <20200220083508.792071-7-anarsoul@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200220083508.792071-7-anarsoul@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200220_061748_192823_B516DCD8 X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Sam Ravnborg , Stephen Rothwell , Samuel Holland , Heiko Stuebner , Chen-Yu Tsai , Icenowy Zheng , Stephan Gerhold , Jonas Karlman , Torsten Duwe , Rob Herring , Maxime Ripard , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , linux-kernel@vger.kernel.org, Mark Brown , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vasily, Thank you for the patch. On Thu, Feb 20, 2020 at 12:35:08AM -0800, Vasily Khoruzhick wrote: > From: Icenowy Zheng > > Pinebook has an ANX6345 bridge connected to the RGB666 LCD output and > eDP panel input. The bridge is controlled via I2C that's connected to > R_I2C bus. > > Enable all this hardware in device tree. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Vasily Khoruzhick > --- > .../dts/allwinner/sun50i-a64-pinebook.dts | 69 ++++++++++++++++++- > 1 file changed, 68 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts > index c06c540e6c08..f5633f550d8a 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts > @@ -48,6 +48,18 @@ lid_switch { > }; > }; > > + panel_edp: panel-edp { > + compatible = "neweast,wjfh116008a"; > + backlight = <&backlight>; > + power-supply = <®_dc1sw>; > + > + port { > + panel_edp_in: endpoint { > + remote-endpoint = <&anx6345_out_edp>; > + }; > + }; > + }; > + > reg_vbklt: vbklt { > compatible = "regulator-fixed"; > regulator-name = "vbklt"; > @@ -109,6 +121,10 @@ &dai { > status = "okay"; > }; > > +&de { > + status = "okay"; > +}; > + > &ehci0 { > phys = <&usbphy 0>; > phy-names = "usb"; > @@ -119,6 +135,10 @@ &ehci1 { > status = "okay"; > }; > > +&mixer0 { > + status = "okay"; > +}; > + > &mmc0 { > pinctrl-names = "default"; > pinctrl-0 = <&mmc0_pins>; > @@ -177,12 +197,45 @@ &pwm { > status = "okay"; > }; > > -/* The ANX6345 eDP-bridge is on r_i2c */ > &r_i2c { > clock-frequency = <100000>; > pinctrl-names = "default"; > pinctrl-0 = <&r_i2c_pl89_pins>; > status = "okay"; > + > + anx6345: anx6345@38 { > + compatible = "analogix,anx6345"; > + reg = <0x38>; > + reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 */ > + dvdd25-supply = <®_dldo2>; > + dvdd12-supply = <®_fldo1>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + anx6345_in: port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + anx6345_in_tcon0: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&tcon0_out_anx6345>; > + }; As there's a single endpoint, you can drop the reg property, the @0 suffix, and the #address-cells and #size-cells property in the port@0 node (but not in the ports node). > + }; > + > + anx6345_out: port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + anx6345_out_edp: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&panel_edp_in>; > + }; Same here. Reviewed-by: Laurent Pinchart > + }; > + }; > + }; > }; > > &r_pio { > @@ -357,6 +410,20 @@ &sound { > "MIC2", "Internal Microphone Right"; > }; > > +&tcon0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&lcd_rgb666_pins>; > + > + status = "okay"; > +}; > + > +&tcon0_out { > + tcon0_out_anx6345: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&anx6345_in_tcon0>; > + }; > +}; > + > &uart0 { > pinctrl-names = "default"; > pinctrl-0 = <&uart0_pb_pins>; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel