From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 029AAC11D0C for ; Thu, 20 Feb 2020 16:37:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB693207FD for ; Thu, 20 Feb 2020 16:37:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CTYNzWmK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB693207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NpSObAlbRf8JDL4jj3VmdriI/397fN3qGAHOX5AlMmI=; b=CTYNzWmKO8djN+ 4dCeGSVguBuwmlSoI8VvKaZdVbXf6t82IkglRJPmae4CezhW4O8Xn+AjXQ+LxnE7gvzNsOJ+BfA9Z 6KaBkW49GIScGvwjJTKqUDPMeQ1N8VsASK0MIvd7t5SlSe2ceGSsCDjSckIAdk5f7EMFmaXvQjOhZ F4SK/o/7wj0wR7Z7iH/JSTcGQJmtXO3KRmqkV5U49wRY5b3Usd1gsCY9uXgH/1TtTB5MhvOT1T6L+ RiD79gcwd4Hnn4TFbHU38plFI4BiWwNbu37ttDulmLjw3RBthtKKkWK4vqOGn+wUIEiO4jmbpSAcR qd1eJG+Dbej3Obouq4GA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4op9-0005Qt-GE; Thu, 20 Feb 2020 16:37:15 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4op5-0005Q1-Vn for linux-arm-kernel@lists.infradead.org; Thu, 20 Feb 2020 16:37:13 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C21028080; Thu, 20 Feb 2020 16:37:50 +0000 (UTC) Date: Thu, 20 Feb 2020 08:37:03 -0800 From: Tony Lindgren To: "Andrew F. Davis" Subject: Re: omap-secure.c:undefined reference to `__arm_smccc_smc' Message-ID: <20200220163703.GK37466@atomide.com> References: <202002131856.VeW4PhBJ%lkp@intel.com> <20200220155429.GH37466@atomide.com> <55ddcd29-ed8b-529e-dd54-cbac5cf74e42@ti.com> <20200220162012.GI37466@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200220_083712_059781_BE75FF87 X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, kbuild test robot , Aaro Koskinen , Marc Zyngier , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Andrew F. Davis [200220 16:24]: > On 2/20/20 11:20 AM, Tony Lindgren wrote: > > * Andrew F. Davis [200220 16:04]: > >> On 2/20/20 10:54 AM, Tony Lindgren wrote: > >>> Andrew, > >>> > >>> * kbuild test robot [200213 10:27]: > >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > >>>> head: 0bf999f9c5e74c7ecf9dafb527146601e5c848b9 > >>>> commit: c37baa06f8a970e4a533d41f7d33e5e57de5ad25 ARM: OMAP2+: Fix undefined reference to omap_secure_init > >>>> date: 3 weeks ago > >>>> config: arm-randconfig-a001-20200213 (attached as .config) > >>>> compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0 > >>>> reproduce: > >>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > >>>> chmod +x ~/bin/make.cross > >>>> git checkout c37baa06f8a970e4a533d41f7d33e5e57de5ad25 > >>>> # save the attached .config to linux build tree > >>>> GCC_VERSION=7.5.0 make.cross ARCH=arm > >>>> > >>>> If you fix the issue, kindly add following tag > >>>> Reported-by: kbuild test robot > >>>> > >>>> All errors (new ones prefixed by >>): > >>>> > >>>> arch/arm/mach-omap2/omap-secure.o: In function `omap_smccc_smc': > >>>>>> omap-secure.c:(.text+0x94): undefined reference to `__arm_smccc_smc' > >>> > >>> Have you looked at this one? Looks like there's still an unhandled > >>> randconfig build case. > >>> > >> > >> > >> I've had a quick look, all the ARM config does: > >> > >> select HAVE_ARM_SMCCC if CPU_V7 > >> > >> so I don't think this will happen in any real config, but if we want to > >> prevent randconfig issue this we could force ARCH_OMAP2PLUS to "depend" > >> on it. > > > > Seems to happen at least with omap2 only config where we don't have > > CPU_V7. Something like below seems to fix it. > > > > If that looks OK to you, I'll send out a proper fix. > > > > > This looks fine to me. > > A better later fix might be to later stub out the actual __arm_smccc_smc > in common code if CONFIG_HAVE_ARM_SMCCC is not set, so any platform will > get the fix. Yeah seems that might be better. Adding Aaro and Marc to Cc. Regards, Tony > > 8< ----------------------- > > diff --git a/arch/arm/mach-omap2/omap-secure.c b/arch/arm/mach-omap2/omap-secure.c > > --- a/arch/arm/mach-omap2/omap-secure.c > > +++ b/arch/arm/mach-omap2/omap-secure.c > > @@ -77,6 +77,7 @@ u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 nargs, u32 arg1, u32 arg2, > > return ret; > > } > > > > +#ifdef CONFIG_HAVE_ARM_SMCCC > > void omap_smccc_smc(u32 fn, u32 arg) > > { > > struct arm_smccc_res res; > > @@ -85,6 +86,11 @@ void omap_smccc_smc(u32 fn, u32 arg) > > 0, 0, 0, 0, 0, 0, &res); > > WARN(res.a0, "Secure function call 0x%08x failed\n", fn); > > } > > +#else > > +void omap_smccc_smc(u32 fn, u32 arg) > > +{ > > +} > > +#endif > > > > void omap_smc1(u32 fn, u32 arg) > > { > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel