From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9796EC11D1A for ; Thu, 20 Feb 2020 18:11:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 730802467A for ; Thu, 20 Feb 2020 18:11:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XHvmW90X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 730802467A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EU4G+b1KTK/VuaDqeBenQVnfbzy+jgiDFjvasdHLpt8=; b=XHvmW90Xw81ISE 0vG4aVqMOAggRfExXIfrF4iKZGU5UAD6Sp8YDkAXQLPnZepEZVXI80C25ED90VNkfdBV+8Axi5Y0v POmX1mC2sxGodZ3a4WyzIyMTpMeQ3/nuBLxVNii/cGeo2Gl4HcCBCQwA3hKyaVG/sHbo+bgqFUT56 AgfwkCY8G2kww44Tt5meCmPJPC6p4vBNKmwqrjgtXGI+XGgxH0nDclcbCj1s2rm3UXq0VP+OccGyT B9X2PLUhywX7f40biDKk4R/kojCds0+v3j5ed2FhGsTFAqTPoUJObs/jMwFbmkL5i6dmLlp/RW/aM ZfQYYWuO6Ih7Nsmkm9gg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4qIe-0008Mo-1X; Thu, 20 Feb 2020 18:11:48 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4qIb-0008MS-4r for linux-arm-kernel@lists.infradead.org; Thu, 20 Feb 2020 18:11:46 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 951498080; Thu, 20 Feb 2020 18:12:28 +0000 (UTC) Date: Thu, 20 Feb 2020 10:11:41 -0800 From: Tony Lindgren To: "Andrew F. Davis" Subject: Re: omap-secure.c:undefined reference to `__arm_smccc_smc' Message-ID: <20200220181141.GR37466@atomide.com> References: <202002131856.VeW4PhBJ%lkp@intel.com> <20200220155429.GH37466@atomide.com> <55ddcd29-ed8b-529e-dd54-cbac5cf74e42@ti.com> <20200220162012.GI37466@atomide.com> <20200220163703.GK37466@atomide.com> <20200220171305.GL37466@atomide.com> <281e895b-720d-5bab-63cf-8b3e389dc767@ti.com> <20200220175744.GQ37466@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200220175744.GQ37466@atomide.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200220_101145_226501_3E686E66 X-CRM114-Status: GOOD ( 21.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , kbuild-all@lists.01.org, kbuild test robot , Arnd Bergmann , Aaro Koskinen , Marc Zyngier , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Tony Lindgren [200220 17:58]: > * Andrew F. Davis [200220 17:39]: > > On 2/20/20 12:13 PM, Tony Lindgren wrote: > > > * Tony Lindgren [200220 16:37]: > > >> * Andrew F. Davis [200220 16:24]: > > >>> On 2/20/20 11:20 AM, Tony Lindgren wrote: > > >>>> * Andrew F. Davis [200220 16:04]: > > >>>>> On 2/20/20 10:54 AM, Tony Lindgren wrote: > > >>>>>> Andrew, > > >>>>>> > > >>>>>> * kbuild test robot [200213 10:27]: > > >>>>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > >>>>>>> head: 0bf999f9c5e74c7ecf9dafb527146601e5c848b9 > > >>>>>>> commit: c37baa06f8a970e4a533d41f7d33e5e57de5ad25 ARM: OMAP2+: Fix undefined reference to omap_secure_init > > >>>>>>> date: 3 weeks ago > > >>>>>>> config: arm-randconfig-a001-20200213 (attached as .config) > > >>>>>>> compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0 > > >>>>>>> reproduce: > > >>>>>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > >>>>>>> chmod +x ~/bin/make.cross > > >>>>>>> git checkout c37baa06f8a970e4a533d41f7d33e5e57de5ad25 > > >>>>>>> # save the attached .config to linux build tree > > >>>>>>> GCC_VERSION=7.5.0 make.cross ARCH=arm > > >>>>>>> > > >>>>>>> If you fix the issue, kindly add following tag > > >>>>>>> Reported-by: kbuild test robot > > >>>>>>> > > >>>>>>> All errors (new ones prefixed by >>): > > >>>>>>> > > >>>>>>> arch/arm/mach-omap2/omap-secure.o: In function `omap_smccc_smc': > > >>>>>>>>> omap-secure.c:(.text+0x94): undefined reference to `__arm_smccc_smc' > > >>>>>> > > >>>>>> Have you looked at this one? Looks like there's still an unhandled > > >>>>>> randconfig build case. > > >>>>>> > > >>>>> > > >>>>> > > >>>>> I've had a quick look, all the ARM config does: > > >>>>> > > >>>>> select HAVE_ARM_SMCCC if CPU_V7 > > >>>>> > > >>>>> so I don't think this will happen in any real config, but if we want to > > >>>>> prevent randconfig issue this we could force ARCH_OMAP2PLUS to "depend" > > >>>>> on it. > > >>>> > > >>>> Seems to happen at least with omap2 only config where we don't have > > >>>> CPU_V7. Something like below seems to fix it. > > >>>> > > >>>> If that looks OK to you, I'll send out a proper fix. > > >>>> > > >>> > > >>> > > >>> This looks fine to me. > > >>> > > >>> A better later fix might be to later stub out the actual __arm_smccc_smc > > >>> in common code if CONFIG_HAVE_ARM_SMCCC is not set, so any platform will > > >>> get the fix. > > >> > > >> Yeah seems that might be better. Adding Aaro and Marc to Cc. > > > > > > But if we can in theory have some arm11 machine with smccc, then this > > > local ifdef below is probably the way to go. > > > > > > > If the machine has SMCCC then it will also have the > > CONFIG_HAVE_ARM_SMCCC set and so nothing would change. > > Hmm yeah good point. So the patch below seems like the way to go then. Anybody have issues with the patch below? Regards, Tony 8< ------------------------- diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h --- a/include/linux/arm-smccc.h +++ b/include/linux/arm-smccc.h @@ -121,6 +121,7 @@ struct arm_smccc_quirk { } state; }; +#ifdef CONFIG_HAVE_ARM_SMCCC /** * __arm_smccc_smc() - make SMC calls * @a0-a7: arguments passed in registers 0 to 7 @@ -137,6 +138,14 @@ asmlinkage void __arm_smccc_smc(unsigned long a0, unsigned long a1, unsigned long a2, unsigned long a3, unsigned long a4, unsigned long a5, unsigned long a6, unsigned long a7, struct arm_smccc_res *res, struct arm_smccc_quirk *quirk); +#else +static inline void __arm_smccc_smc(unsigned long a0, unsigned long a1, + unsigned long a2, unsigned long a3, unsigned long a4, + unsigned long a5, unsigned long a6, unsigned long a7, + struct arm_smccc_res *res, struct arm_smccc_quirk *quirk) +{ +} +#endif /** * __arm_smccc_hvc() - make HVC calls _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel