From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E3CC35646 for ; Fri, 21 Feb 2020 11:06:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA1CF24653 for ; Fri, 21 Feb 2020 11:06:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TyAGvU07" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA1CF24653 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=opDLdg07pV2nr7QrWs2VQlNWWfPpiUwfhI1YW8Kpn+U=; b=TyAGvU07limx4Z EMVYmuoeWqFI8WIuvMkZzdxbJOQ5xsLGMkdwoC28ob8JF6bxCEeutPKecGCEr265PtuqJ1w7l/toI NG8S3kUfmUdxf7+1Fga9Yilmte+5brOY2ikKIzkBcT5ZO6ohOTszNWm7B6QGqF0F2qYql6fqvmCbJ 2bkP5Qc600XXvS52uu6OqwP/XEajlJ41JJZxMYPNJpfTFHAb7svCsEiJBrFozFB+QRPVfdA3OGSlJ LiP6nzhjdA6B+E/6OpBPEKgKxWs9SmurswHTeD6YQ5c7Ia+Y68xPSXRei7F8rXkyb77q6A1B3AuEe pgYvNkykr9aJMqgHhAIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j5680-0001Md-B3; Fri, 21 Feb 2020 11:05:52 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j567w-0001Lo-UN for linux-arm-kernel@lists.infradead.org; Fri, 21 Feb 2020 11:05:50 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id F03F2AE17; Fri, 21 Feb 2020 11:05:43 +0000 (UTC) Date: Fri, 21 Feb 2020 12:05:41 +0100 From: Torsten Duwe To: Neil Armstrong Subject: Re: [PATCH 1/6] drm/bridge: anx6345: Fix getting anx6345 regulators Message-ID: <20200221110541.GA28948@suse.de> References: <20200220083508.792071-1-anarsoul@gmail.com> <20200220083508.792071-2-anarsoul@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200221_030549_125577_830E9B36 X-CRM114-Status: GOOD ( 20.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Laurent Pinchart , Sam Ravnborg , Stephen Rothwell , Samuel Holland , Heiko Stuebner , Chen-Yu Tsai , Icenowy Zheng , Stephan Gerhold , Jonas Karlman , Rob Herring , Maxime Ripard , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , linux-kernel@vger.kernel.org, Mark Brown , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 21, 2020 at 09:32:01AM +0100, Neil Armstrong wrote: > On 20/02/2020 09:35, Vasily Khoruzhick wrote: > > From: Samuel Holland > > > > We don't need to pass '-supply' suffix to devm_get_regulator() > > > > Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support") > > Signed-off-by: Samuel Holland > > Signed-off-by: Vasily Khoruzhick > > --- > > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > > index 56f55c53abfd..0d8d083b0207 100644 > > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > > @@ -712,14 +712,14 @@ static int anx6345_i2c_probe(struct i2c_client *client, > > DRM_DEBUG("No panel found\n"); > > > > /* 1.2V digital core power regulator */ > > - anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply"); > > + anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12"); > > if (IS_ERR(anx6345->dvdd12)) { > > DRM_ERROR("dvdd12-supply not found\n"); > > return PTR_ERR(anx6345->dvdd12); > > } > > > > /* 2.5V digital core power regulator */ > > - anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply"); > > + anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25"); > > if (IS_ERR(anx6345->dvdd25)) { > > DRM_ERROR("dvdd25-supply not found\n"); > > return PTR_ERR(anx6345->dvdd25); > > > > This is a duplicate of "drm/bridge: analogix-anx6345: Avoid duplicate -supply suffix" (20200218155440.BEFB968C65@verein.lst.de) > > But this one has fixes and review from laurent, so I'll push this one when the serie is ready I really don't mind, as long as it gets fixed. The change is pretty obvious when you look at commit 69511a452e6dc. Signed-off-by: Torsten Duwe Reviewed-by: Mark Brown (broonie had replied to my submission back in November) There's one other fix required for the anx6345 and, while at it, I had also fixed the code I copied in that hurry as well. What about these? All 3 fixes can go in independently, so I wouldn't tie them to this series. Torsten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel