From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF3DC35E01 for ; Tue, 25 Feb 2020 20:42:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76371222C2 for ; Tue, 25 Feb 2020 20:42:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n8u5zBOK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oyQo5IPJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76371222C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3QnkoxIiF/IHRMj8803rbKtnsPdoI4+bSb4BOnxKp60=; b=n8u5zBOKIfWK/M qDB8OGaKiAOGpXNcJ4XjC+M6vMZ8NjpT4Fw7vL2AV0h6tVmq8I0S7sTZ/KXMTgklIhZzQeCsbAsyO A8p0JDtLtutBPFXsSxovoI9QL1WS+9DP+6dO0GmnmBbPG66Sb+JPzZ3OV1FWYxJ8EA+kPD32VoOk1 cq6KsJy5OcdqAS20X7vBFCL7vnchcC2xaJWk6Xi20GwgVA1EA6AKW8XEpJhCHfFNn8HUv1IunRqVd P7+wi3hox5fsPW6aRxDGKyBjtVY56i7g5aAHdxQVkUpYidvr8ZcDdIcdB1+ZacEMv8i61gXnOwjJN GDknaJZZ9Ii1zRTvZ+TQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6h1j-00019J-TM; Tue, 25 Feb 2020 20:41:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6h1g-00018p-O7 for linux-arm-kernel@lists.infradead.org; Tue, 25 Feb 2020 20:41:58 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F88F20675; Tue, 25 Feb 2020 20:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582663315; bh=YYC4xaOlh2BnEG7cTijsktqQkfUcqWoUPp+Gy0hHL5U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oyQo5IPJ8L0EIKxeaAFS2wAcDllxRfr2eyVyy1hLk8AAcr8z8/gIQPFmVOAcK45// 0PSaDa7pEC5LX/x8Hl6kxwy8zvjscYilZIkwDkR1kel/bGuxKAII++UJ/QCGZ7bqbi CL+pgiEvxS2wgZ9W/4jpN7F68Cg0E7zmzKk678t0= Date: Tue, 25 Feb 2020 21:41:51 +0100 From: Greg Kroah-Hartman To: Geert Uytterhoeven Subject: Re: [PATCH 1/2] tty: serial: samsung_tty: build it for any platform Message-ID: <20200225204151.GA13254@kroah.com> References: <20200220102628.3371996-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200225_124156_807590_0C3D049E X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Donghoon Yu , linux-samsung-soc , Bartlomiej Zolnierkiewicz , Linux Kernel Mailing List , Krzysztof Kozlowski , Shinbeom Choi , Hyunki Koo , Kukjin Kim , HYUN-KI KOO , "open list:SERIAL DRIVERS" , Jiri Slaby , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 25, 2020 at 09:52:38AM +0100, Geert Uytterhoeven wrote: > On Thu, Feb 20, 2020 at 1:13 PM Bartlomiej Zolnierkiewicz > wrote: > > On 2/20/20 11:26 AM, Greg Kroah-Hartman wrote: > > > There is no need to tie this driver to only a specific SoC, or compile > > > test, so remove that dependancy from the Kconfig rules. > > > > samsung_tty driver is hardware specific driver so why should we > > build it for any platform? Why not? Seriously, this "only this one specific SoC is allowed to build this driver" is crazy. It prevents anyone from building a generic kernel with drivers as a module which are loaded as needed. That needs to be fixed, and removing this unneeded dependancy on this driver allows it to be build for any system and then only loaded when needed. > > This change seems to defeat the whole purpose behind COMPILE_TEST > > config option (which allows us to build hardware-specific drivers > > without needlessly presenting the user with tons of non-relevant > > config options). > > > > Please explain this change some more, are you planing to remove > > COMPILE_TEST config option? I want to get rid of this: > > > - depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST We should not need PLAT_SAMSUNG or ARCH_EXYNOS at all, we should be able to build an arm64 kernel for all platforms. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel