Re: [PATCH] mediatek: move MT8173 VPU FW to subfolder

gtk_ruiwang
2020-02-26T05:42:13Z

Dear Alex,

we have submit a new patch to linux-firmware, and update WHENCE file.

please kindly help to review it.

Thanks
Best Regards

On Wed, 2020-02-26 at 13:45 +0900, Alexandre Courbot wrote:
> On Wed, Feb 26, 2020 at 1:20 PM gtk_ruiwang <gtk_ruiwang@mediatek.com> wrote:
> >
> > Dear Alex,
> >
> > Do you mean to create two symbolic link?
> >
> > lrwxrwxrwx 1 gtk_ruiwang gtk_ruiwang 25 Feb 26 11:52 vpu_d.bin ->
> > mediatek/mt8173/vpu_d.bin
> > lrwxrwxrwx 1 gtk_ruiwang gtk_ruiwang 25 Feb 26 11:52 vpu_p.bin ->
> > mediatek/mt8173/vpu_p.bin
>
> Yes, otherwise older kernels will become unable to use the firmware. I
> don't know whether these are supposed to stay forever or whether we
> can remove them after a while... presumably the former.
>
> Also the WHENCE file should probably be updated to list the new files.
>
> >
> > we create them at the linux-firmware root folder.
> >
> > Thanks
> > Best Regards
> >
> > On Wed, 2020-02-26 at 12:41 +0900, Alexandre Courbot wrote:
> > > On Wed, Feb 26, 2020 at 12:38 PM <gtk_ruiwang@mediatek.com> wrote:
> > > >
> > > > From: gtk_ruiwang <gtk_ruiwang@mediatek.com>
> > > >
> > > > Currently vpu_d.bin and vpu_p.bin are at the root of
> > > > linux-firmware git tree, it's not appropriate so we move
> > > > them to subfolder mediatek/mt8173
> > > >
> > > > Release Version: 1.1.4
> > > >
> > > > Signed-off-by: Rui Wang <gtk_ruiwang@mediatek.com>
> > > > ---
> > > > vpu_d.bin => mediatek/mt8173/vpu_d.bin | Bin
> > > > vpu_p.bin => mediatek/mt8173/vpu_p.bin | Bin
> > > > 2 files changed, 0 insertions(+), 0 deletions(-)
> > > > rename vpu_d.bin => mediatek/mt8173/vpu_d.bin (100%)
> > > > rename vpu_p.bin => mediatek/mt8173/vpu_p.bin (100%)
> > >
> > > This is nice as it removes some stuff from the root, but for
> > > compatibility with older kernels that don't know about the new path
> > > shouldn't we at least temporarily create a symbolic link between the
> > > old location and the new one?