linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: i2c: Convert UniPhier I2C controller to json-schema
@ 2020-02-21  2:55 Masahiro Yamada
  2020-02-21  2:55 ` [PATCH 2/2] dt-bindings: i2c: Convert UniPhier FI2C " Masahiro Yamada
  2020-02-26 16:46 ` [PATCH 1/2] dt-bindings: i2c: Convert UniPhier I2C " Rob Herring
  0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2020-02-21  2:55 UTC (permalink / raw)
  To: devicetree, Rob Herring
  Cc: Mark Rutland, linux-kernel, Masahiro Yamada, linux-i2c,
	Frank Rowand, linux-arm-kernel

Convert the UniPhier I2C controller (FIFO-less) binding to DT schema
format.

There are two types of I2C controllers used on the UniPhier platform.
This is the legacy one without FIFO support, which is used on the
sLD8 SoC or older.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

When I search for a subsystem-common schema, I need to
look in both dt-schema project and the kernel tree.

For example,
the i2c-controller.yaml is located in the dt-schema project.
dt-schema/schemas/i2c/i2c-controller.yaml

The dma-controller.yaml is located in the kernel tree.
Documentation/devicetree/bindings/dma/dma-controller.yaml

I am still wondering about the policy...

As far as I understood, the schema written by Rob
tend to go in the dt-schma project. Is this correct?


 .../devicetree/bindings/i2c/i2c-uniphier.txt  | 25 ----------
 .../bindings/i2c/socionext,uniphier-i2c.yaml  | 50 +++++++++++++++++++
 2 files changed, 50 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-uniphier.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/socionext,uniphier-i2c.yaml

diff --git a/Documentation/devicetree/bindings/i2c/i2c-uniphier.txt b/Documentation/devicetree/bindings/i2c/i2c-uniphier.txt
deleted file mode 100644
index 26f9d95b3436..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-uniphier.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-UniPhier I2C controller (FIFO-less)
-
-Required properties:
-- compatible: should be "socionext,uniphier-i2c".
-- #address-cells: should be 1.
-- #size-cells: should be 0.
-- reg: offset and length of the register set for the device.
-- interrupts: a single interrupt specifier.
-- clocks: phandle to the input clock.
-
-Optional properties:
-- clock-frequency: desired I2C bus frequency in Hz.  The maximum supported
-  value is 400000.  Defaults to 100000 if not specified.
-
-Examples:
-
-	i2c0: i2c@58400000 {
-		compatible = "socionext,uniphier-i2c";
-		reg = <0x58400000 0x40>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-		interrupts = <0 41 1>;
-		clocks = <&i2c_clk>;
-		clock-frequency = <100000>;
-	};
diff --git a/Documentation/devicetree/bindings/i2c/socionext,uniphier-i2c.yaml b/Documentation/devicetree/bindings/i2c/socionext,uniphier-i2c.yaml
new file mode 100644
index 000000000000..ef998def554e
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/socionext,uniphier-i2c.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/socionext,uniphier-i2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: UniPhier I2C controller (FIFO-less)
+
+maintainers:
+  - Masahiro Yamada <yamada.masahiro@socionext.com>
+
+allOf:
+  - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+  compatible:
+    const: socionext,uniphier-i2c
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-frequency:
+    minimum: 100000
+    maximum: 400000
+
+required:
+  - compatible
+  - reg
+  - "#address-cells"
+  - "#size-cells"
+  - interrupts
+  - clocks
+
+examples:
+  - |
+    i2c0: i2c@58400000 {
+        compatible = "socionext,uniphier-i2c";
+        reg = <0x58400000 0x40>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+        interrupts = <0 41 1>;
+        clocks = <&i2c_clk>;
+        clock-frequency = <100000>;
+    };
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] dt-bindings: i2c: Convert UniPhier FI2C controller to json-schema
  2020-02-21  2:55 [PATCH 1/2] dt-bindings: i2c: Convert UniPhier I2C controller to json-schema Masahiro Yamada
@ 2020-02-21  2:55 ` Masahiro Yamada
  2020-02-26 16:46   ` Rob Herring
  2020-02-26 16:46 ` [PATCH 1/2] dt-bindings: i2c: Convert UniPhier I2C " Rob Herring
  1 sibling, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2020-02-21  2:55 UTC (permalink / raw)
  To: devicetree, Rob Herring
  Cc: Mark Rutland, linux-kernel, Masahiro Yamada, linux-i2c,
	Frank Rowand, linux-arm-kernel

Convert the UniPhier FIFO-builtin I2C (a.k.a. FIFO) controller binding
to DT schema format.

There are two types of I2C controllers used on the UniPhier platform.
This is the new one with FIFO support, which is used on the Pro4 SoC
or newer.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 .../bindings/i2c/i2c-uniphier-f.txt           | 25 ----------
 .../bindings/i2c/socionext,uniphier-fi2c.yaml | 50 +++++++++++++++++++
 2 files changed, 50 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-uniphier-f.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/socionext,uniphier-fi2c.yaml

diff --git a/Documentation/devicetree/bindings/i2c/i2c-uniphier-f.txt b/Documentation/devicetree/bindings/i2c/i2c-uniphier-f.txt
deleted file mode 100644
index 27fc6f8c798b..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-uniphier-f.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-UniPhier I2C controller (FIFO-builtin)
-
-Required properties:
-- compatible: should be "socionext,uniphier-fi2c".
-- #address-cells: should be 1.
-- #size-cells: should be 0.
-- reg: offset and length of the register set for the device.
-- interrupts: a single interrupt specifier.
-- clocks: phandle to the input clock.
-
-Optional properties:
-- clock-frequency: desired I2C bus frequency in Hz.  The maximum supported
-  value is 400000.  Defaults to 100000 if not specified.
-
-Examples:
-
-	i2c0: i2c@58780000 {
-		compatible = "socionext,uniphier-fi2c";
-		reg = <0x58780000 0x80>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-		interrupts = <0 41 4>;
-		clocks = <&i2c_clk>;
-		clock-frequency = <100000>;
-	};
diff --git a/Documentation/devicetree/bindings/i2c/socionext,uniphier-fi2c.yaml b/Documentation/devicetree/bindings/i2c/socionext,uniphier-fi2c.yaml
new file mode 100644
index 000000000000..15abc022968e
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/socionext,uniphier-fi2c.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/socionext,uniphier-fi2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: UniPhier I2C controller (FIFO-builtin)
+
+maintainers:
+  - Masahiro Yamada <yamada.masahiro@socionext.com>
+
+allOf:
+  - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+  compatible:
+    const: socionext,uniphier-fi2c
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-frequency:
+    minimum: 100000
+    maximum: 400000
+
+required:
+  - compatible
+  - reg
+  - "#address-cells"
+  - "#size-cells"
+  - interrupts
+  - clocks
+
+examples:
+  - |
+    i2c0: i2c@58780000 {
+        compatible = "socionext,uniphier-fi2c";
+        reg = <0x58780000 0x80>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+        interrupts = <0 41 4>;
+        clocks = <&i2c_clk>;
+        clock-frequency = <100000>;
+    };
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] dt-bindings: i2c: Convert UniPhier I2C controller to json-schema
  2020-02-21  2:55 [PATCH 1/2] dt-bindings: i2c: Convert UniPhier I2C controller to json-schema Masahiro Yamada
  2020-02-21  2:55 ` [PATCH 2/2] dt-bindings: i2c: Convert UniPhier FI2C " Masahiro Yamada
@ 2020-02-26 16:46 ` Rob Herring
  1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-02-26 16:46 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Mark Rutland, devicetree, linux-kernel, Masahiro Yamada,
	linux-i2c, Frank Rowand, linux-arm-kernel

On Fri, 21 Feb 2020 11:55:33 +0900, Masahiro Yamada wrote:
> Convert the UniPhier I2C controller (FIFO-less) binding to DT schema
> format.
> 
> There are two types of I2C controllers used on the UniPhier platform.
> This is the legacy one without FIFO support, which is used on the
> sLD8 SoC or older.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
> When I search for a subsystem-common schema, I need to
> look in both dt-schema project and the kernel tree.
> 
> For example,
> the i2c-controller.yaml is located in the dt-schema project.
> dt-schema/schemas/i2c/i2c-controller.yaml
> 
> The dma-controller.yaml is located in the kernel tree.
> Documentation/devicetree/bindings/dma/dma-controller.yaml
> 
> I am still wondering about the policy...
> 
> As far as I understood, the schema written by Rob
> tend to go in the dt-schma project. Is this correct?
> 
> 
>  .../devicetree/bindings/i2c/i2c-uniphier.txt  | 25 ----------
>  .../bindings/i2c/socionext,uniphier-i2c.yaml  | 50 +++++++++++++++++++
>  2 files changed, 50 insertions(+), 25 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-uniphier.txt
>  create mode 100644 Documentation/devicetree/bindings/i2c/socionext,uniphier-i2c.yaml
> 

Applied, thanks.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] dt-bindings: i2c: Convert UniPhier FI2C controller to  json-schema
  2020-02-21  2:55 ` [PATCH 2/2] dt-bindings: i2c: Convert UniPhier FI2C " Masahiro Yamada
@ 2020-02-26 16:46   ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-02-26 16:46 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Mark Rutland, devicetree, linux-kernel, Masahiro Yamada,
	linux-i2c, Frank Rowand, linux-arm-kernel

On Fri, 21 Feb 2020 11:55:34 +0900, Masahiro Yamada wrote:
> Convert the UniPhier FIFO-builtin I2C (a.k.a. FIFO) controller binding
> to DT schema format.
> 
> There are two types of I2C controllers used on the UniPhier platform.
> This is the new one with FIFO support, which is used on the Pro4 SoC
> or newer.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  .../bindings/i2c/i2c-uniphier-f.txt           | 25 ----------
>  .../bindings/i2c/socionext,uniphier-fi2c.yaml | 50 +++++++++++++++++++
>  2 files changed, 50 insertions(+), 25 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-uniphier-f.txt
>  create mode 100644 Documentation/devicetree/bindings/i2c/socionext,uniphier-fi2c.yaml
> 

Applied, thanks.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-02-26 16:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-21  2:55 [PATCH 1/2] dt-bindings: i2c: Convert UniPhier I2C controller to json-schema Masahiro Yamada
2020-02-21  2:55 ` [PATCH 2/2] dt-bindings: i2c: Convert UniPhier FI2C " Masahiro Yamada
2020-02-26 16:46   ` Rob Herring
2020-02-26 16:46 ` [PATCH 1/2] dt-bindings: i2c: Convert UniPhier I2C " Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).