From: Peter Chen <peter.chen@nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jun.li@freescale.com" <jun.li@freescale.com>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/3] USB IMX Chipidea fix gpio vbus control
Date: Thu, 27 Feb 2020 11:18:36 +0000 [thread overview]
Message-ID: <20200227111838.GA24071@b29397-desktop> (raw)
In-Reply-To: <20200227104212.12562-1-m.felsch@pengutronix.de>
On 20-02-27 11:42:09, Marco Felsch wrote:
> Hi,
>
> the gpio-based port power is broken since commit [1,2]. I changed the
> core behaviour to to cleanup the code and avoid local workaround fixes.
Many i.mx series evk boards work well for gpio-based port power control,
what problem you have found, would you please list it detail?
Peter
>
> With this series and [3] I'am now able to disable the port completely
> after I disbaled the pm_qos_no_power_off flag.
>
> [1] 6adb9b7b5fb6 ("usb: chipidea: add a flag for turn on vbus early for host")
> [2] 659459174188 ("usb: chipidea: host: turn on vbus before add hcd if early vbus on is required")
> [3] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.org%2Flkml%2F2020%2F2%2F27%2F198&data=02%7C01%7Cpeter.chen%40nxp.com%7Cc1b3094e826b49b572cb08d7bb71b6bc%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637183969379126557&sdata=i7O7vBqiVCb2opVNva7ffxIdqFb%2BvGzV5Qsy5wwarbQ%3D&reserved=0
>
> Regards,
> Marco
>
> Marco Felsch (3):
> USB: ehci-hub: let port_power() override the ehci_port_power()
> Partially Revert "usb: chipidea: host: turn on vbus before add hcd if
> early vbus on is required"
> Revert "usb: chipidea: add a flag for turn on vbus early for host"
>
> drivers/usb/chipidea/ci_hdrc_imx.c | 10 ++--------
> drivers/usb/chipidea/host.c | 31 ++++++++++--------------------
> drivers/usb/host/ehci-hub.c | 6 +++---
> include/linux/usb/chipidea.h | 17 ++++++++--------
> 4 files changed, 23 insertions(+), 41 deletions(-)
>
> --
> 2.20.1
>
--
Thanks,
Peter Chen
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-27 11:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 10:42 [PATCH 0/3] USB IMX Chipidea fix gpio vbus control Marco Felsch
2020-02-27 10:42 ` [PATCH 1/3] USB: ehci-hub: let port_power() override the ehci_port_power() Marco Felsch
2020-02-27 10:42 ` [PATCH 2/3] Partially Revert "usb: chipidea: host: turn on vbus before add hcd if early vbus on is required" Marco Felsch
2020-02-27 10:42 ` [PATCH 3/3] Revert "usb: chipidea: add a flag for turn on vbus early for host" Marco Felsch
2020-02-27 11:18 ` Peter Chen [this message]
2020-02-27 11:35 ` [PATCH 0/3] USB IMX Chipidea fix gpio vbus control Marco Felsch
2020-02-27 12:20 ` Peter Chen
2020-02-27 12:44 ` Marco Felsch
2020-02-27 13:30 ` Peter Chen
2020-02-27 13:59 ` Peter Chen
2020-02-27 14:39 ` Marco Felsch
2020-02-28 2:51 ` Peter Chen
2020-02-28 7:48 ` Marco Felsch
2020-02-28 9:40 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227111838.GA24071@b29397-desktop \
--to=peter.chen@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox