From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CBBFC4BA24 for ; Thu, 27 Feb 2020 12:20:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07FAE24695 for ; Thu, 27 Feb 2020 12:20:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cgzDq1ur"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="UKONwOfU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07FAE24695 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zoHJN2ez9g9m/TuszX5Ty2tFxVnrGM7cwx9a0ab2ClE=; b=cgzDq1urT4k/0h f48jY6LmSsMNHfbs4UDyMHlco5vJnqmytc3bwxTuycg/uG5nMVGfgmqONXpZviP08RxTuAGzju6kJ cX2pstPYf2sxj0Sr3hPEMGW/x3e/Er4lBcdt0K1l28dhu/ITAohVOuF28hd8fjbOySgQcJXvx3lEU S3U+8bp8c8ieKyowRNUHrn79/+OlMKEBGXEodTfEAClFf2Vr3sSWwFquVFn8qvZUiZnmY5bvCR8rf etZtQMT0/BHy0nEjVBcmpXQLVeGl4cExXgsblclQhRKVy88kDo7+YwsSHHD6IEoK6lAdiXE3mVKkf LzSFRzVZsFxC1onBlwVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7I9p-0001Be-Tb; Thu, 27 Feb 2020 12:20:49 +0000 Received: from mail-eopbgr30066.outbound.protection.outlook.com ([40.107.3.66] helo=EUR03-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7I9m-0001B5-I7 for linux-arm-kernel@lists.infradead.org; Thu, 27 Feb 2020 12:20:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JfsvwFX4fYxZgJL60OuGF5eXgL0gKo8iWLBMxP5m6ZAgtMfqdYgalOhowckflBAsoV7jKCn5UT6iVgaryKZrCOrk6t1+F4aG5DFAC6G8IV1lGqFBJ4FdQ3HRzfMt/lk1QX3nf5Rdm2Qjjo9O8/tIuEBCjMUhX3Zt6RRAALvnUrVDrYTxy6rFfuPFLh1GRoUiC1E9YjpwiQ/BvPTE0XyCBELfvbRS79iMgNhdB51dUoIKA/RObuaRlmztXE/n7nmbfX+6bNlH7QXE2+/uM5xHzlKJvbW9YiXWAS+fMDtMq1nhWraFCb+tymfE98LK3UEpdzCg50JDzBrpmx6ALsGDaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6BQJVqsz3e00yKFGoZDmnfBlC5Nup2boO0cg5JBoVrk=; b=dUqgF60fH8XJPs1c81ZFkTdGI5k0aX6TKQfQDGwLodW0iW9tq89iSc+oX2B1sOXqod1Qa2eoIQsYssQsh+LP4yoiJDLwAUpVYeGoKVIig5M3uB+xffNBQbA6vY1tvLVWioTPizVKutiStlhT70jgCcCmC8jqT9ahNnrcoBKYo5IoucY2YFMMlEl8p9JyIgfRq3hbSp3mONAaWpk2Lc5cr8C5kp1G39MTeH8OObFzMPU4P5Lv5mNhmerEpF4kAxS/356dRCns1f6tUV+IGmbe1nKlCynjM+ib9UFZzO+J6Ncrb2pdCzWYGFicnyNy2rt9rejvxn71e5ev90vCy5vbGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6BQJVqsz3e00yKFGoZDmnfBlC5Nup2boO0cg5JBoVrk=; b=UKONwOfUe8BxNLeY0PjHGZu+f1Cqv4ttzKCYOEgBa0ES/yZy/zB6iGEWyAUQLvVYKiMl10PGlqgDQxoEiXfy5ooOwsEYVQrtVUG1HG6+WeANDIm6el34a+whNqxYrrHfQcDaG7Qznl8o4UcQSFs5/QndkiMQd+o722Ifg0RSxUg= Received: from VI1PR04MB5327.eurprd04.prod.outlook.com (20.177.51.23) by VI1PR04MB4350.eurprd04.prod.outlook.com (52.134.31.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.18; Thu, 27 Feb 2020 12:20:43 +0000 Received: from VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::9547:9dfa:76b8:71b1]) by VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::9547:9dfa:76b8:71b1%7]) with mapi id 15.20.2750.021; Thu, 27 Feb 2020 12:20:43 +0000 From: Peter Chen To: Marco Felsch Subject: Re: [PATCH 0/3] USB IMX Chipidea fix gpio vbus control Thread-Topic: [PATCH 0/3] USB IMX Chipidea fix gpio vbus control Thread-Index: AQHV7VqVZ4BeDr6e5UuTM5ZPfBO9kqgu5JsAgAAEwYCAAAyagA== Date: Thu, 27 Feb 2020 12:20:43 +0000 Message-ID: <20200227122045.GB24071@b29397-desktop> References: <20200227104212.12562-1-m.felsch@pengutronix.de> <20200227111838.GA24071@b29397-desktop> <20200227113539.gcx3nfwm2fbm3ukv@pengutronix.de> In-Reply-To: <20200227113539.gcx3nfwm2fbm3ukv@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2357cc92-6458-458b-60fe-08d7bb7f774e x-ms-traffictypediagnostic: VI1PR04MB4350:|VI1PR04MB4350:|VI1PR04MB4350: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 03264AEA72 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(7916004)(396003)(366004)(346002)(376002)(39860400002)(136003)(199004)(189003)(2906002)(186003)(53546011)(6506007)(5660300002)(33656002)(9686003)(54906003)(33716001)(6512007)(6916009)(26005)(66476007)(76116006)(66446008)(64756008)(8936002)(66556008)(316002)(478600001)(8676002)(81166006)(81156014)(91956017)(4326008)(6486002)(1076003)(71200400001)(66946007)(44832011)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4350; H:VI1PR04MB5327.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cremqyKllvYH0gjyiBjGGLYytaW36zadaqEfhQ9dDn85Nqr7Suea4yP4cTOzVlGtYcaEIAWpK2zjJtE3mG9vZQXYUReVrrVwtlddo87HS5yZCwlIoZej9LQqrBpWPHdJbKA6FTkhQuq/s7cg9xvzbUtXQSqbTjupRTTvvKNQmGtnO5dulK6gS5v4fwETyLTgCYDKopRx2Id7dJLmT5v5Q8yUkECQPvMaoDcBN7WNz1Xgw/Srh87ZwTURzOYgL/wUKhmkqOO6C5SXO+P9Ts/nT97kvfWOhDAfvRNL/EYLM5UCjXKzPjjDbPDqTL2codnK6TrwxRGTGd6Yj3XN7gj63+0F41R0C9LGvF5CHZ6a2nftczPMfwQDfWafscu0W6ET/+D9NGsvNCkcEs5tsD8nFqG73nbU/jvi2Te0olVSUS7OYgEsrIKd9GgVdc/Rn/DK x-ms-exchange-antispam-messagedata: dvA0DjgW3M8VLUkniWNK2hj0GBupT1WAIUwc4n0EKBOuAa350qHPf3RpdQsQA8aIN/WAXyY2GKsrBagET3z3+xYRZLb51LKl2oMPTB5bM3Kb1edVEjqxMB4Tsq13OPDgKeMFA4VNGTsE3TnxeAVE7Q== Content-ID: <93E4892C75ED5E4AAFD5E6C3D473D9B4@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2357cc92-6458-458b-60fe-08d7bb7f774e X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2020 12:20:43.1541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bsDAPnGhp+uRd0aeZ1VaPBXBMITYA7Ke3F8Yg9vT/rLklpwQ0wKs61GveXFHiKJLQOphNIRjt8RSQaVsvj5rCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4350 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200227_042046_709587_FBB0D093 X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "jun.li@freescale.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "stern@rowland.harvard.edu" , dl-linux-imx , "kernel@pengutronix.de" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20-02-27 12:35:39, Marco Felsch wrote: > Hi Peter, > > thanks for your fast reply :) > > On 20-02-27 11:18, Peter Chen wrote: > > On 20-02-27 11:42:09, Marco Felsch wrote: > > > Hi, > > > > > > the gpio-based port power is broken since commit [1,2]. I changed the > > > core behaviour to to cleanup the code and avoid local workaround fixes. > > > > Many i.mx series evk boards work well for gpio-based port power control, > > what problem you have found, would you please list it detail? > > Hm.. who could that work? I picked the important parts: > > static int ehci_ci_portpower(struct usb_hcd *hcd, int portnum, bool enable) > { > ... > > if (priv->reg_vbus && enable != priv->enabled) { > > ... > > if (enable) > ret = regulator_enable(priv->reg_vbus); > else > ret = regulator_disable(priv->reg_vbus); > > ... > } > > ... > } > > static int host_start(struct ci_hdrc *ci) > { > ... > > priv->reg_vbus = NULL; > > if (ci->platdata->reg_vbus && !ci_otg_is_fsm_mode(ci)) { > if (ci->platdata->flags & CI_HDRC_TURN_VBUS_EARLY_ON) { > ret = regulator_enable(ci->platdata->reg_vbus); > if (ret) { > dev_err(ci->dev, > "Failed to enable vbus regulator, ret=%d\n", > ret); > goto put_hcd; > } > } else { > priv->reg_vbus = ci->platdata->reg_vbus; > } > } > > ... > } > > Note, I'm using a imx6q which has the CI_HDRC_TURN_VBUS_EARLY_ON set. > Do you have a VBUS regulator at your dts, and add it at controller's node? See: arch/arm/boot/dts/imx6qdl-sabresd.dtsi as an example please? If you have set CI_HDRC_TURN_VBUS_EARLY_ON, the VBUS is controlled by chipidea driver, not by USB core through PORTSC.PP (ehci_ci_portpower). -- Thanks, Peter Chen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel