From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBB0C4BA24 for ; Thu, 27 Feb 2020 13:00:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11CEA24693 for ; Thu, 27 Feb 2020 13:00:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="elvlMwB2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="IARaMUZP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11CEA24693 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V9YhaXUSQbjp/AvPvTnNzNek5jr9QxpyNBxRc/9CdWs=; b=elvlMwB2664Bwh KbhbzLR3Z8FZn/CvpiAkryQvADHzfonpIPoyOCzHp1epP9XHrVNHt7EYy3WpHPBaFeRATJltleUmK 84XYUXoHkvES8T6i6Smg7mTtxuul6f/t8kTvPTHN0vaq2EQzpmSlEirMJk50PSRIbcpt8C7IaMOnz 4kyERt6r8DmLW5KwZl/XOCipLqX+POU0How7o1j5oWpUUfQPyVyNQbcCpdidkozNFNnyVXaDjIfv2 7PP2/6hihFjVrWk5TvA7REwOtoN/fFjz0fO9i8IU5bm7zIlfdRpTsDmYbrJm96BU9HmaHHNMdTlQW veqAZmJ24uSNNmul/4pg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7Ilx-0008Ak-Ea; Thu, 27 Feb 2020 13:00:13 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7Ilt-0007Ul-PL for linux-arm-kernel@lists.infradead.org; Thu, 27 Feb 2020 13:00:11 +0000 Received: by mail-wm1-x342.google.com with SMTP id c84so3305082wme.4 for ; Thu, 27 Feb 2020 05:00:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lF1WpNMmDIC+u5WUFqN6XI3/wXMvIRCjntbaMdrFGfg=; b=IARaMUZPJiCDFrzzJwyWb6YRob1J06IUMUj73rqLrl3Ppn2wS5eJPgwlML7IHofhy/ 2vf5hO+Nxf4m1l3oC4JUcc7Hycie16A5bdmxyzvR8ybGG19Vv74J/0OdSSzOtXAIAtFm hMdlDcz5qhKEWvM924Bb6wqORS+DdqDMMh0H5v7DlndWs3/uUJKmmlF5c7Pnu8OdtuG1 VApamd3WADlVVWGzYbr2a6BxRq5U34ILOaDQhh/SURP7x9fisOuMZn2MG+h5CFPxnUuh Za4SaJk52aI2JKEpRn4Fpd6QCc2qeQcY9u1+vXWi/UPTVb7jpQ1tclDVVaEd2hmdcgV6 5/9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lF1WpNMmDIC+u5WUFqN6XI3/wXMvIRCjntbaMdrFGfg=; b=ME4OAy0eRm9T3RSG8YdN/lPyNCm1aKfhNI6CCqDRf/dTrf2B5Y9atLxrtyEe1/KxMD 0RmXIHBzFgO9NQUC8+JlGYeh14sK8Gih/MvAU+kOwOKG115HW/vMXMJ5IBJMV/0cxmMm 3UHmfcsOJvfmI3IAt4FMC9p+IeOg34p2WFwtWY/NuWnpzi5n0/Y2YgxMm8THvlQJBg+b SaXQI5f7rYmz6HlCuXCcmMj6EGyU/56osgjIesZOq+uUcpkCXQenyutjt+e6+wRQsPdk 5VslBXU2ALlTqBXexlGcFbWyIT4Pn+gTVWEX4AqzPSTvOSuYyCwBaoaB74+e1xZ8VKeR nPUQ== X-Gm-Message-State: APjAAAWAKlU593jncigDflMZ50vJsqE+3XTL7+fsskGopJhotQbHTu98 q2fMcNn33Ocg5k/W3iaajpG15w== X-Google-Smtp-Source: APXvYqyJc8z85FxR6Y8xbHanOXMr3EKjgHVQ0zhtwSRKjHALBfFlCDS/ccmFZBafwRz3YaXDguz5LA== X-Received: by 2002:a7b:c119:: with SMTP id w25mr5324707wmi.116.1582808405179; Thu, 27 Feb 2020 05:00:05 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id e18sm8033429wrw.70.2020.02.27.05.00.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 05:00:04 -0800 (PST) Date: Thu, 27 Feb 2020 13:00:01 +0000 From: Quentin Perret To: Valentin Schneider Subject: Re: [PATCH 1/2] sched/topology: Don't enable EAS on SMT systems Message-ID: <20200227130001.GA107011@google.com> References: <20200226164118.6405-1-valentin.schneider@arm.com> <20200226164118.6405-2-valentin.schneider@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200226164118.6405-2-valentin.schneider@arm.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200227_050009_852983_383CEE10 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: morten.rasmussen@arm.com, Mark Rutland , kernel-team@android.com, Peter Zijlstra , Catalin Marinas , linux-kernel@vger.kernel.org, Ingo Molnar , Will Deacon , Dietmar Eggemann , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 26 Feb 2020 at 16:41:17 (+0000), Valentin Schneider wrote: > EAS already requires asymmetric CPU capacities to be enabled, and mixing > this with SMT is an aberration, but better be safe than sorry. > > Signed-off-by: Valentin Schneider Acked-by: Quentin Perret Thanks, Quentin > --- > kernel/sched/topology.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index 00911884b7e7..76cd0a370b9a 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -360,6 +360,10 @@ static bool build_perf_domains(const struct cpumask *cpu_map) > goto free; > } > > + /* EAS definitely does *not* handle SMT */ > + if (sched_smt_active()) > + goto free; > + > for_each_cpu(i, cpu_map) { > /* Skip already covered CPUs. */ > if (find_pd(pd, i)) > -- > 2.24.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel