From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77973C11D3D for ; Thu, 27 Feb 2020 17:26:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A36524691 for ; Thu, 27 Feb 2020 17:26:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PIk4ebhd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="FsHxrqEQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A36524691 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0PcWrOnbSXiY4B4gMy3DaPHWwrchjMRtI8NB39e0krU=; b=PIk4ebhd6lco5j ZW2/D3EUhIMaBLeurkm/i/3BfJvaPRwBSsDCqrhiqmxVtJckuy7tb7ioWAaPMzr9PZ5drtaZ2fm4X nSwS/m2GIEr/vuCrovuRkLwl6lOo2QWbeiomeby9mZTrpcMn1Z63a6qiK+8wSjIbN6mrI5zroPdKT +5xJ4XdlXCX4xvUhLb65hATITafCvcLdWseD4nmpQhts1Zc0Fu1n0j/OraqhSsJn3xUJAXJ8QzKCu HAxx7Q3GeOKoVLB9sSgjZTtoobVir41YGn+betO6/ocIKPXJxwAL9BBMKgaTFDVrPecP+/m+3r4NV A1JjheYk26ebfg0ujLOw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7MvY-0001Lm-Tb; Thu, 27 Feb 2020 17:26:24 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7MvW-0001Kd-2a for linux-arm-kernel@lists.infradead.org; Thu, 27 Feb 2020 17:26:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rV0yWDS028EyWe+FVKxyqef5iqunBgE96eEFUfnUJg0=; b=FsHxrqEQKZ1XG1e6Z9ClQ7uES mGZ0Xq59EIhuvKGUh/Gu31A6oI7Y0Y7z8OwZfy3BRBhedPjIbzYW4h3EsQxccGYVf0tkLGtf99fxN SdZtb5z3GiM2WjXx/2ZaGxHALijVbLSmfxZ9Tv7OjuI9zS9P23kfyjKKxVEIz9RrLP3dB6sm0kdkf Mph5NmgVVOnXJ2q0JN8Lb1/sYVDVcCRmTmWn08cDjSNsKuuTB26NnZZaH4YFt7WBbzIc8RdgFWYnl FmwtJYqlPdzvQKuLaTAI5iJNDLdaDET+UowN1Ar+b/5NqNGjcPfO8hFMztg9/g4k1EnDZ55uYnlN0 xfIQHndBA==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:53558) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j7MvK-0006xK-KA; Thu, 27 Feb 2020 17:26:10 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j7MvI-00019B-Fg; Thu, 27 Feb 2020 17:26:08 +0000 Date: Thu, 27 Feb 2020 17:26:08 +0000 From: Russell King - ARM Linux admin To: Rob Herring Subject: Re: [PATCH net-next 1/3] dt-bindings: net: add dt bindings for marvell10g driver Message-ID: <20200227172608.GO25745@shell.armlinux.org.uk> References: <20200227095159.GJ25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200227_092622_121917_EA9C71C2 X-CRM114-Status: GOOD ( 17.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Florian Fainelli , Jason Cooper , devicetree@vger.kernel.org, netdev , Sebastian Hesselbarth , "David S. Miller" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 27, 2020 at 11:13:41AM -0600, Rob Herring wrote: > On Thu, Feb 27, 2020 at 3:52 AM Russell King wrote: > > > > Add a DT bindings document for the Marvell 10G driver, which will > > augment the generic ethernet PHY binding by having LED mode > > configuration. > > > > Signed-off-by: Russell King > > --- > > .../devicetree/bindings/net/marvell,10g.yaml | 31 +++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/marvell,10g.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/marvell,10g.yaml b/Documentation/devicetree/bindings/net/marvell,10g.yaml > > new file mode 100644 > > index 000000000000..da597fc5314d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/marvell,10g.yaml > > @@ -0,0 +1,31 @@ > > +# SPDX-License-Identifier: GPL-2.0+ > > Dual license new bindings please: > > (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/marvell,10g.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Marvell Alaska X family Ethernet PHYs > > + > > +maintainers: > > + - Russell King > > + > > +allOf: > > + - $ref: ethernet-phy.yaml# > > + > > +properties: > > + marvell,led-mode: > > + description: | > > + An array of one to four 16-bit integers to write to the PHY LED > > + configuration registers. > > This is for what to blink or turn on for? I thought we had something > generic for configuring PHY LEDs specifically? I see nothing in ethernet-phy.yaml. Yes, it configures which conditions cause the LED to illuminate and/or blink, what blink rate and polarity of the pin. > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint16-array > > + - minItems: 1 > > + maxItems: 4 > > + > > +examples: > > + - | > > + ethernet-phy@0 { > > + reg = <0>; > > This needs to be under an 'mdio' node with #address-cells and > #size-cells set correctly. I wish these things were documented somewhere... I'm pretty sure this passed validation when I wrote it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel