From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C42CC3F2D1 for ; Fri, 28 Feb 2020 10:50:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2E66246AA for ; Fri, 28 Feb 2020 10:50:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LJD01Bok"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="z+RrJqqR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2E66246AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PjJzI+ognaRZVO18t9FF8QEozeoVFY6VzXhpYjaXcc8=; b=LJD01BokozBjJ5 uTpvXn2ptJtM++XTVhVL3Aw7j6x6ymHYhI3meCJHN/03iL8FwBJvjFJ1QK8o8HC03RIWhq0Z1qufe aFbGSATBCYve/7pm2SnCxai8OqenB6BI95J4ywq+7GHgnRCuIjLFjVYvJHj67hBPfylSz/I+LTPUx MocStexk6fj++b9eE5ZAPGpkXzijb0Fb8xSzErrFq2ffCAI4n9oSjU0D8xrsa/qodZdXmKemNkFCp Gi3wSThVmEzBKXjfztTbLzGjxuR/D8U2+5G5pMY2Njdi+Qohkxk3snziXTVars3Xa34Pa2xE4uxZ5 D3Nnwmkw/N70G9LMQoCw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7dE4-0005tY-Os; Fri, 28 Feb 2020 10:50:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7dE1-0005tF-GS for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2020 10:50:34 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20828246A8; Fri, 28 Feb 2020 10:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582887033; bh=Bbgf5LWzwoyyN8sRPGs+DRNqC78Z9PpvNOKHlpYOuuY=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=z+RrJqqRtVGq9XfqtRw9QpSXbUASWNcXI/tfse0Sc/IM6Lxf9lx6pMA0oirj8lTKl h8CJkGoAIzMi7dfqp1Okh0a+WgaLv+aWJ83Vji5BUFGibpT6zuUmElpzm2ARQnrxn2 jtaOyTvkzqcVrgV8nfhA2AzeOrZn4B/PQAFNxHXw= Date: Fri, 28 Feb 2020 10:50:25 +0000 From: Will Deacon To: Andre Przywara Subject: Re: [RFC PATCH 06/11] iommu: arm-smmu: Remove Calxeda secure mode quirk Message-ID: <20200228105024.GC2395@willie-the-truck> References: <20200218171321.30990-1-robh@kernel.org> <20200218171321.30990-7-robh@kernel.org> <20200218172000.GF1133@willie-the-truck> <20200228100446.GA2395@willie-the-truck> <20200228102556.1dde016e@donnerap.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200228102556.1dde016e@donnerap.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200228_025033_590252_163BAB7D X-CRM114-Status: GOOD ( 26.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: Mark Langsdorf , kvm@vger.kernel.org, Viresh Kumar , "open list:LIBATA SUBSYSTEM \(Serial and Parallel ATA drivers\)" , linux-clk , Rob Herring , soc@kernel.org, Joerg Roedel , Daniel Lezcano , devicetree@vger.kernel.org, Jon Loeliger , "open list:THERMAL" , Eric Auger , Alex Williamson , Tony Luck , Alexander Graf , Mauro Carvalho Chehab , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-edac , Jens Axboe , Matthias Brugger , Stephen Boyd , netdev , Cornelia Huck , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Linux IOMMU , Robert Richter , James Morse , Borislav Petkov , Robin Murphy , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 28, 2020 at 10:25:56AM +0000, Andre Przywara wrote: > On Fri, 28 Feb 2020 10:04:47 +0000 > Will Deacon wrote: > > Hi, > > > On Tue, Feb 25, 2020 at 04:01:54PM -0600, Rob Herring wrote: > > > On Tue, Feb 18, 2020 at 11:20 AM Will Deacon wrote: > > > > > > > > On Tue, Feb 18, 2020 at 11:13:16AM -0600, Rob Herring wrote: > > > > > Cc: Will Deacon > > > > > Cc: Robin Murphy > > > > > Cc: Joerg Roedel > > > > > Cc: iommu@lists.linux-foundation.org > > > > > Signed-off-by: Rob Herring > > > > > --- > > > > > Do not apply yet. > > > > > > > > Pleeeeease? ;) > > > > > > > > > drivers/iommu/arm-smmu-impl.c | 43 ----------------------------------- > > > > > 1 file changed, 43 deletions(-) > > > > > > > > Yes, I'm happy to get rid of this. Sadly, I don't think we can remove > > > > anything from 'struct arm_smmu_impl' because most implementations fall > > > > just short of perfect. > > > > > > > > Anyway, let me know when I can push the button and I'll queue this in > > > > the arm-smmu tree. > > > > > > Seems we're leaving the platform support for now, but I think we never > > > actually enabled SMMU support. It's not in the dts either in mainline > > > nor the version I have which should be close to what shipped in > > > firmware. So as long as Andre agrees, this one is good to apply. > > > > Andre? Can I queue this one for 5.7, please? > > I was wondering how much of a pain it is to keep it in? AFAICS there are > other users of the "impl" indirection. If those goes away, I would be > happy to let Calxeda go. The impl stuff is new, so we'll keep it around. The concern is more about testing (see below). > But Eric had the magic DT nodes to get the SMMU working, and I used that > before, with updating the DT either on flash or dynamically via U-Boot. What did you actually use the SMMU for, though? The 'arm_iommu_create_mapping()' interface isn't widely used and, given that highbank doesn't support KVM, the use-cases for VFIO are pretty limited too. > So I don't know exactly *how* desperate you are with removing this, or if > there are other reasons than "negative diffstat", but if possible I would > like to keep it in. It's more that we *do* make quite a lot of changes to the arm-smmu driver and it's never tested with this quirk. If you're stepping up to run smmu tests on my queue for each release on highbank, then great, but otherwise I'd rather not carry the code for fun. The change in diffstat is minimal (we're going to need to hooks for nvidia, who broke things in a different way). Also, since the hooks aren't going away, if you /do/ end up using the SMMU in future, then we could re-add the driver quirk without any fuss. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel