From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7093C3F2CD for ; Fri, 28 Feb 2020 16:49:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8138824697 for ; Fri, 28 Feb 2020 16:49:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CWVDmxl5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8138824697 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=diidhEYBiFPKEJteBO9mXOY9Np155j8MwNC6vvgXSVQ=; b=CWVDmxl5bIi+2L 5Sj3WHdXchviEMAH31R1Q5DJQ7Bz5jo3tCvotrubZtj1L73Qu6XEpB1YAOrmAomyx+j5U27Qw+G3J sgkbJi+RTVZd8uQmdoxTqY59Rpn5GdPoeV9rR/k1v+P3t85f5JCQTkX4lp6XGFc2nswpghvJm8JbD ZlHZNsfl/bWpUFjmUBhmizZPUqDfjSkURtKB8qLu2rt6ZfikSBTXB0cmz4gn4fyzFyykB3VUYWsk2 9cNV6EyJGSTzcSJxIAE16yazymQN4/xISOy/F0BNUw/seLBC2lUH+CK2+XPmvsb3eIcOQ9pjUSCiR TKjMTIP9c2dHIgbafFsw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7ioq-0000Zy-KG; Fri, 28 Feb 2020 16:48:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7ion-0000ZY-Uy; Fri, 28 Feb 2020 16:48:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6113031B; Fri, 28 Feb 2020 08:48:53 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D5E293F73B; Fri, 28 Feb 2020 08:48:50 -0800 (PST) Date: Fri, 28 Feb 2020 16:48:48 +0000 From: Catalin Marinas To: Macpaul Lin Subject: Re: [PATCH v4] usb: gadget: f_fs: try to fix AIO issue under ARM 64 bit TAGGED mode Message-ID: <20200228164848.GH4019108@arrakis.emea.arm.com> References: <1582627315-21123-1-git-send-email-macpaul.lin@mediatek.com> <1582718512-28923-1-git-send-email-macpaul.lin@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1582718512-28923-1-git-send-email-macpaul.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200228_084854_290909_38FBA502 X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Shen Jing , CC Hwang , Peter Chen , Mediatek WSD Upstream , Jerry Zhang , andreyknvl@google.com, linux-usb@vger.kernel.org, Loda Chou , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andrzej Pietrasiewicz , Miles Chen , eugenis@google.com, John Stultz , Al Viro , Vincent Pelletier , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 26, 2020 at 08:01:52PM +0800, Macpaul Lin wrote: > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index ce1d023..192935f 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -715,7 +715,20 @@ static void ffs_epfile_io_complete(struct usb_ep *_ep, struct usb_request *req) > > static ssize_t ffs_copy_to_iter(void *data, int data_len, struct iov_iter *iter) > { > - ssize_t ret = copy_to_iter(data, data_len, iter); > + ssize_t ret; > + > +#if defined(CONFIG_ARM64) > + /* > + * Replace tagged address passed by user space application before > + * copying. > + */ > + if (IS_ENABLED(CONFIG_ARM64_TAGGED_ADDR_ABI) && > + (iter->type == ITER_IOVEC)) { > + *(unsigned long *)&iter->iov->iov_base = > + (unsigned long)untagged_addr(iter->iov->iov_base); > + } > +#endif > + ret = copy_to_iter(data, data_len, iter); > if (likely(ret == data_len)) > return ret; I had forgotten that we discussed a similar case already a few months ago (thanks to Evgenii for pointing out). Do you have this commit applied to your tree: df325e05a682 ("arm64: Validate tagged addresses in access_ok() called from kernel threads")? -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel