From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E134CC3F2CD for ; Tue, 3 Mar 2020 07:38:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B630D20842 for ; Tue, 3 Mar 2020 07:38:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C9azZRec"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N2hhA1DH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B630D20842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UnUoA4z0uN3S2HatAM17gR0pzrlIBrSSN51WjV389vQ=; b=C9azZRecfLZbzA ub/AVJjQ70sKKXnJIO0tS3uVYWQxBzG7xgZSMI2oW7wEGJOUTlmwbXhCzDBn3IasfUJPwnl4c/tK9 8LgrNDs277yAnSH4QXUmECMxlrjxsVlBwGt0BrEWKeUugk0IFLVfDF2R5xHGp4aFE0q/CZgSwqjJH ckTUt+q31tkTQvz2/S6Y5zCReIk6XX5sPz4snbggGlDsAM4d1kr+0aoGm7e+K9PTRxJKxGsa5+gSP Cv1xPSF/aTBFgIzIBDAB8XKhRVipIrXQyBE10B18+APDhevhu9sR5iQs2ZViuXHwfe88OHLPpw/Si d8UT0W5Z0JYdJSbLZVVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9285-0006aa-Eo; Tue, 03 Mar 2020 07:38:13 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9281-0006a4-Ib for linux-arm-kernel@lists.infradead.org; Tue, 03 Mar 2020 07:38:10 +0000 Received: by mail-pf1-x442.google.com with SMTP id p14so1038982pfn.4 for ; Mon, 02 Mar 2020 23:38:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lp++SjSydgt9rFdJFF3CB/lDlkmkywlwzPGaMF0zRlA=; b=N2hhA1DHJRr48b03MdRwK7wZT+y/IIbu0elhvz7gKyVzfWBwfAl0mdXhHechKW3w5h wBxpbplnqcGuRCe2aCyqhLZ2wpo+o2zcRsqCG1KdGYHdSJxY32PohGGlo4aMczuoJHna CMWMl9Exwvu57I8hyLPt/3Q4RBQTH5w67lBRMPCFvGriXxlrcvaH322RGt4kpMoBHUxh 3E4JEzdChP8g3QMeRMTmn351CirQyx390iw1AbTyvsytm9dZSNigQYXyPmQAa74sAYIC Pj+UjOdxqIfBRBpzjWssycX5jwrJViK8MAIoJf3vZquhGT10/uKK0BZsNZxEY15fRJdw 35Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lp++SjSydgt9rFdJFF3CB/lDlkmkywlwzPGaMF0zRlA=; b=Kr5FsHWO9tYIk4c58p/wLJNtcSd9tGeHY8JcH1PD03MGChs2K3KSypJ1bSA5pP+B65 lUyyiy+QoExKu3C/B79JWYlbjruh+/gB6psH5mYMQF+oFEiryYkt8lkWkCLoDU84pybY YHCnV4ttyG+bLd9sjhs3bzRIccMwyZLM8oRG6GgziV1emF67qHuC1SKl85jF6OQ3mErl Ok/ppeSeKAB8f3gzZFAVjppmEn7aNNXrdyECs5/q9WB31MSTQAI2HNxlFR6oe5flIKBV eJdfa08gDN+J37opdveVEEeHVtZ9sw8y8xchzKypcK0lmwOzKtAyFAvuQAvPSvnu6jJX Dg7Q== X-Gm-Message-State: ANhLgQ0WW0X2eCoBw/P1753Rs6KRKPA+WKXs0Q0cTOVQTig7k/Ila8zv 1Q3mseXEqQ4V23WMdJP+6Io= X-Google-Smtp-Source: ADFU+vvzwWp+30x2055lNCAa+QhYWY8R2yyZZoSUjWYJZln5Koehw7RijTiQ1fkyuH3SDxsLzC7qTQ== X-Received: by 2002:aa7:8582:: with SMTP id w2mr2820931pfn.89.1583221088207; Mon, 02 Mar 2020 23:38:08 -0800 (PST) Received: from Asurada (c-73-162-191-63.hsd1.ca.comcast.net. [73.162.191.63]) by smtp.gmail.com with ESMTPSA id p94sm1516093pjp.15.2020.03.02.23.38.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Mar 2020 23:38:07 -0800 (PST) Date: Mon, 2 Mar 2020 23:37:46 -0800 From: Nicolin Chen To: Shengjiu Wang Subject: Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format Message-ID: <20200303073745.GA2868@Asurada> References: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com> <20200303014133.GA24596@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200302_233809_617308_92C00CBA X-CRM114-Status: GOOD ( 23.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Linux-ALSA , Liam Girdwood , Timur Tabi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , shawnguo@kernel.org, Shengjiu Wang , Xiubo Li , linux-kernel , Takashi Iwai , Mark Brown , linux-imx@nxp.com, kernel@pengutronix.de, Fabio Estevam , linuxppc-dev@lists.ozlabs.org, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 03, 2020 at 11:59:30AM +0800, Shengjiu Wang wrote: > Hi > > On Tue, Mar 3, 2020 at 9:43 AM Rob Herring wrote: > > > > On Sun, Mar 01, 2020 at 01:24:12PM +0800, Shengjiu Wang wrote: > > > asrc_format is more inteligent, which is align with the alsa > > > definition snd_pcm_format_t, we don't need to convert it to > > > format in driver, and it can distinguish S24_LE & S24_3LE. > > > > > > Signed-off-by: Shengjiu Wang > > > --- > > > Documentation/devicetree/bindings/sound/fsl,asrc.txt | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > > index cb9a25165503..0cbb86c026d5 100644 > > > --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > > +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > > @@ -38,7 +38,9 @@ Required properties: > > > > > > - fsl,asrc-rate : Defines a mutual sample rate used by DPCM Back Ends. > > > > > > - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends. > > > + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back > > > + Ends. The value is one of SNDRV_PCM_FORMAT_XX in > > > + "include/uapi/sound/asound.h" > > > > You can't just change properties. They are an ABI. > > I have updated all the things related with this ABI in this patch series. > What else should I do? You probably should add one beside the old one. And all the existing drivers would have to continue to support "fsl,asrc-width", even if they start to support the new "fsl,asrc-format". The ground rule here is that a newer kernel should be able to work with an old DTB, IIRC. One more concern here is about the format value. Though I don't think those values, defined in asound.h, would be changed, yet I am not sure if it's legit to align DT bindings to a subsystem header file -- I only know that usually we keep shared macros under include/dt-bindings folder. I won't have any problem, if either Rob or Mark has no objection. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel