From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB46C3F2D1 for ; Tue, 3 Mar 2020 17:02:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FF892083E for ; Tue, 3 Mar 2020 17:02:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H4kPeyI4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FF892083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y3mp696BatUzQIIaChMEs3C8TvtQUFxM2kwj4Y1vyIM=; b=H4kPeyI4i087PW 7f4aqjSRdUmMNWTxeIaJha1l0cszOuv/mlPZ5vYV3fW6XON/Fk6bNURibhTJJnU/y9c22Q3p4lKmQ W3aajjfb5tmI2NTp7XBj4ex6QTNgNin6Nh4+4T6127XAqa9I5JvrzgUwwBWgawXrDvLtLXtIdKa0k 3wRXFQl+mBZyk0M+mlkbrMZizOhBldpFGM+BubFi0lW1fiwPk4iOwZSm/Hxjc6AxwlrCR2rVO/BL4 icV6KQ4eHNF3pXv7FR7Cx9X+7ZhZJQid6HGub7g65Gjnq9DhGK38ULKvNPmjnbWw6XTQMxJfm7V/R ItIfIrUqkEf8Soe1PwDw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9AwN-0000BH-Jm; Tue, 03 Mar 2020 17:02:43 +0000 Received: from mail-oi1-f196.google.com ([209.85.167.196]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9AwK-0000AH-Ed for linux-arm-kernel@lists.infradead.org; Tue, 03 Mar 2020 17:02:42 +0000 Received: by mail-oi1-f196.google.com with SMTP id j80so3735494oih.7 for ; Tue, 03 Mar 2020 09:02:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8kKpSbpaA0ng8YEkQSINQ3r4/4jqo4CKQTEPdV6/BRw=; b=cwO3hiLXQ42NFON5TZqAJsS7XYH7WVS0jQ/fNpDbfAh84vOqY9kEGY6l3GDX5yAP1R topdpJkY6GmvY+cOk1jmY6xQqIGBMoFnDt3QzoKMMDsncfUzqlggNmJZmGOZQI58U2s3 S5nwmA28JdCvBKO7cgv2ieT/3oRa0Sf3GXem/7enBHUkenOtG9UXgGL+DYbnKyFuD81c dMjVoYN34p9DVhtaAHWyzHEXxrqvNNCs22OrE4YPbkckSpST8b1012SWf0udh96Z6RdI 8S6tkF/9QQwBbNTf29ixCLCSi7lMCSDIeP4KKD57x3gdF1zh/KT+XPhUgRX2NEwgYt8d cFvw== X-Gm-Message-State: ANhLgQ05wOrXBQMDJJC9Uh0NOGdfWfBmqVWxEAnP66UVkqXCwOwifQDI IP4Aq3Z3vsCr+Hau6V81xw== X-Google-Smtp-Source: ADFU+vvEQfPygs1sXv3/t9WnuW0flPvlY/t1wIiM5OQ2yzNmdPGlR0ZW8uthJFyAM3EtuYBRj4z0cg== X-Received: by 2002:aca:1c01:: with SMTP id c1mr3164809oic.18.1583254957380; Tue, 03 Mar 2020 09:02:37 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id a14sm8080946otr.54.2020.03.03.09.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2020 09:02:35 -0800 (PST) Received: (nullmailer pid 6336 invoked by uid 1000); Tue, 03 Mar 2020 17:02:32 -0000 Date: Tue, 3 Mar 2020 11:02:32 -0600 From: Rob Herring To: Ulf Hansson Subject: Re: [PATCH 3/7] dt-bindings: power: Convert domain-idle-states bindings to json-schema Message-ID: <20200303170232.GA26191@bogus> References: <20200303150749.30566-1-ulf.hansson@linaro.org> <20200303150749.30566-4-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200303150749.30566-4-ulf.hansson@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200303_090240_494013_F2C444DC X-CRM114-Status: GOOD ( 20.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Benjamin Gaignard , linux-pm@vger.kernel.org, Stephen Boyd , Daniel Lezcano , "Rafael J . Wysocki" , Lina Iyer , Bjorn Andersson , Sudeep Holla , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 03, 2020 at 04:07:45PM +0100, Ulf Hansson wrote: > While converting to the json-schema, let's also take the opportunity to > further specify/clarify some more details about the DT binding. > > For example, let's define the label where to put the states nodes, set a > pattern for nodename of the state nodes and finally add an example. > > Fixes: a3f048b5424e ("dt: psci: Update DT bindings to support hierarchical PSCI states") > Signed-off-by: Ulf Hansson > --- > .../devicetree/bindings/arm/psci.yaml | 2 +- > .../bindings/power/domain-idle-state.txt | 33 --------- > .../bindings/power/domain-idle-state.yaml | 67 +++++++++++++++++++ > .../bindings/power/power-domain.yaml | 22 +++--- > .../bindings/power/power_domain.txt | 2 +- > 5 files changed, 79 insertions(+), 47 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/power/domain-idle-state.txt > create mode 100644 Documentation/devicetree/bindings/power/domain-idle-state.yaml > > diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml > index 540211a080d4..0bc3c43a525a 100644 > --- a/Documentation/devicetree/bindings/arm/psci.yaml > +++ b/Documentation/devicetree/bindings/arm/psci.yaml > @@ -123,7 +123,7 @@ properties: > to mandate it. > > [3] Documentation/devicetree/bindings/power/power_domain.txt > - [4] Documentation/devicetree/bindings/power/domain-idle-state.txt > + [4] Documentation/devicetree/bindings/power/domain-idle-state.yaml > > power-domains: > $ref: '/schemas/types.yaml#/definitions/phandle-array' > diff --git a/Documentation/devicetree/bindings/power/domain-idle-state.txt b/Documentation/devicetree/bindings/power/domain-idle-state.txt > deleted file mode 100644 > index eefc7ed22ca2..000000000000 > --- a/Documentation/devicetree/bindings/power/domain-idle-state.txt > +++ /dev/null > @@ -1,33 +0,0 @@ > -PM Domain Idle State Node: > - > -A domain idle state node represents the state parameters that will be used to > -select the state when there are no active components in the domain. > - > -The state node has the following parameters - > - > -- compatible: > - Usage: Required > - Value type: > - Definition: Must be "domain-idle-state". > - > -- entry-latency-us > - Usage: Required > - Value type: > - Definition: u32 value representing worst case latency in > - microseconds required to enter the idle state. > - The exit-latency-us duration may be guaranteed > - only after entry-latency-us has passed. > - > -- exit-latency-us > - Usage: Required > - Value type: > - Definition: u32 value representing worst case latency > - in microseconds required to exit the idle state. > - > -- min-residency-us > - Usage: Required > - Value type: > - Definition: u32 value representing minimum residency duration > - in microseconds after which the idle state will yield > - power benefits after overcoming the overhead in entering > -i the idle state. > diff --git a/Documentation/devicetree/bindings/power/domain-idle-state.yaml b/Documentation/devicetree/bindings/power/domain-idle-state.yaml > new file mode 100644 > index 000000000000..27da43076b85 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/domain-idle-state.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/domain-idle-state.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: PM Domain Idle States binding description > + > +maintainers: > + - Ulf Hansson > + > +description: > + A domain idle state node represents the state parameters that will be used to > + select the state when there are no active components in the PM domain. > + > +properties: > + $nodename: > + const: domain-idle-states > + > +patternProperties: > + "^(cpu|cluster|domain)-": > + type: object > + description: > + Each state node represents a domain idle state description. > + > + properties: > + compatible: > + const: domain-idle-state > + > + entry-latency-us: > + $ref: /schemas/types.yaml#/definitions/uint32 You don't need a type because the core schema defines it for all standard units. > + description: > + The worst case latency in microseconds required to enter the idle > + state. Note that, the exit-latency-us duration may be guaranteed only > + after the entry-latency-us has passed. > + > + exit-latency-us: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The worst case latency in microseconds required to exit the idle > + state. > + > + min-residency-us: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The minimum residency duration in microseconds after which the idle > + state will yield power benefits, after overcoming the overhead while > + entering the idle state. > + > + required: > + - compatible > + - entry-latency-us > + - exit-latency-us > + - min-residency-us additionalProperties: false Do we have cases of adding additional properties? I can fix these up when applying. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel