From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E390C3F2CD for ; Wed, 4 Mar 2020 14:53:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E149B21741 for ; Wed, 4 Mar 2020 14:53:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NniOLFj9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E149B21741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YeWfjO3sMbJQcEXgTIAMFlfnvTZ2MJ4g7dwKQ5d/Phc=; b=NniOLFj97G8d7+ DETQDkO/7/PPMf99w/V/13I06mnmLDe8EavktCPltclQNL2K7SGMwz8bH6q1lAGSp5juxjMyXoXFd ITLpCciEIDpp1syzfkJ92P0YTNK0MP2m5RIK16AZHYGE67P9+TAEw3jLOtfpHYYTeobCYL8QCXrrL rs1/HHQ2m4hWqYE/v2svwUbTj7aNsRC9Vmdwf+jmDpny/jI5CEJIsyCwcPTxnxmQvbSHQqPjNvOGE Vn4OWQsriCpyLLuo7eLNACgWvtFGrjqQlHNlUYANfxVkgN6uQ4G8E4KjyYTVLdFAIa7+AMiPCEtKm rOmjPSXN0WiCswyfKnag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9VOh-0001OG-R6; Wed, 04 Mar 2020 14:53:19 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9VOe-0001Nb-NN for linux-arm-kernel@lists.infradead.org; Wed, 04 Mar 2020 14:53:18 +0000 Received: by mail-oi1-f194.google.com with SMTP id r16so2330025oie.6 for ; Wed, 04 Mar 2020 06:53:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wWNZFP6/iHI5zwSuapXSuHRqaFrcN8o+uRdRQNE6Nug=; b=ieLB5r1nPFrUkW7EoiAW34QzepU5f5/QCdyKcVtezbaEu6sLVBAeZzdg0pJz5iARQC AIxKPh93gsGmu76SQCUOiLRtK8a2j9Tp/abTZbAtpNmXRVXNOumC9hT4GceBubXJ7Pcn r3tqzJ0Jg1/QOok361wrQCdkGgFZrum7yiQ6TM4+zxOJp5Em5m+u8K4KB63pnd+JGooS +d4hq5tphrgtS4Wona6aAiRGkaBiOvR7dz93irgLK1lXsD54xcmM1xJo4LDsbGylEcF3 OYWngwnPFwAzzQF+ouszfqaCfc0h5E1uoukarGmnNqs5B1jVDljrh8ygkqojzubTOET6 p95g== X-Gm-Message-State: ANhLgQ1USI6VKQ3F8eEZ1XFSVnI+OSszuReDwTI7YHqMArPA9gvUE+l9 9Edy13zF6e+FKwIn85u1iA== X-Google-Smtp-Source: ADFU+vvKzwypp2GuEEpFsHUpxfgMYMkh8H1PZfC99qYfauXsjPgXUgqA1o3iAvtOokU+XCndhZucXQ== X-Received: by 2002:a54:4099:: with SMTP id i25mr2045874oii.129.1583333595329; Wed, 04 Mar 2020 06:53:15 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id t21sm6032597otk.13.2020.03.04.06.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 06:53:14 -0800 (PST) Received: (nullmailer pid 7126 invoked by uid 1000); Wed, 04 Mar 2020 14:53:14 -0000 Date: Wed, 4 Mar 2020 08:53:14 -0600 From: Rob Herring To: Ulf Hansson Subject: Re: [PATCH 5/7] dt-bindings: arm: Fixup the DT bindings for hierarchical PSCI states Message-ID: <20200304145313.GA5144@bogus> References: <20200303150749.30566-1-ulf.hansson@linaro.org> <20200303150749.30566-6-ulf.hansson@linaro.org> <20200303170641.GC26191@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200304_065316_764101_8C0830B3 X-CRM114-Status: GOOD ( 20.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Lorenzo Pieralisi , Benjamin Gaignard , Linux PM , Stephen Boyd , Daniel Lezcano , "Rafael J . Wysocki" , Lina Iyer , Bjorn Andersson , Sudeep Holla , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 03, 2020 at 09:50:08PM +0100, Ulf Hansson wrote: > On Tue, 3 Mar 2020 at 18:06, Rob Herring wrote: > > > > On Tue, Mar 03, 2020 at 04:07:47PM +0100, Ulf Hansson wrote: > > > The hierarchical topology with power-domain should be described through > > > child nodes, rather than as currently described in the PSCI root node. Fix > > > this by adding a patternProperties with a corresponding reference to the > > > power-domain DT binding. > > > > > > Additionally, update the example to conform to the new pattern, but also to > > > the adjusted domain-idle-state DT binding. > > > > > > Fixes: a3f048b5424e ("dt: psci: Update DT bindings to support hierarchical PSCI states") > > > Signed-off-by: Ulf Hansson > > > --- > > > .../devicetree/bindings/arm/psci.yaml | 33 +++++++++---------- > > > 1 file changed, 15 insertions(+), 18 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml > > > index 0bc3c43a525a..cae668b61265 100644 > > > --- a/Documentation/devicetree/bindings/arm/psci.yaml > > > +++ b/Documentation/devicetree/bindings/arm/psci.yaml > > > @@ -102,11 +102,15 @@ properties: > > > [1] Kernel documentation - ARM idle states bindings > > > Documentation/devicetree/bindings/arm/idle-states.yaml > > > > > > - "#power-domain-cells": > > > - description: > > > - The number of cells in a PM domain specifier as per binding in [3]. > > > - Must be 0 as to represent a single PM domain. > > > +required: > > > + - compatible > > > + - method > > > > No need to move this. > > Okay. > > > > > > > > > +patternProperties: > > > + "^(power-controller|power-domain)([@-].*)?$": > > > + $ref: "../power/power-domain.yaml#" > > > > This has to be under an 'allOf' or the rest of the properties are > > ignored. > > Sure, I had the feeling that something was missing. Thanks for reviewing! > > [...] > > Looks like I should a v2 of the series, or do you prefer to apply some > of the patches before I resend? Applied 1-3. I'll wait for v2 of 4 and 5. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel