Re: [PATCH v1 1/1] sched/fair: do not preempt current task if it is going to call schedule()

From: kbuild test robot <lkp@intel.com>
To: cl@rock-chips.com
Cc: juri.lelli@redhat.com, mark.rutland@arm.com, heiko@sntech.de,
	geert+renesas@glider.be, peterz@infradead.org,
	catalin.marinas@arm.com, bsegall@google.com, will@kernel.org,
	mpe@ellerman.id.au, linux@armlinux.org.uk,
	dietmar.eggemann@arm.com, ben.dooks@codethink.co.uk,
	mgorman@suse.de, Liang Chen <cl@rock-chips.com>,
	huangtao@rock-chips.com, keescook@chromium.org,
	anshuman.khandual@arm.com, rostedt@goodmis.org, wad@chromium.org,
	tglx@linutronix.de, surenb@google.com, mingo@redhat.com,
	allison@lohutok.net, linux-arm-kernel@lists.infradead.org,
	kbuild-all@lists.01.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, luto@amacapital.net,
	george_davis@mentor.com, sudeep.holla@arm.com,
	akpm@linux-foundation.org, info@metux.net,
	kstewart@linuxfoundation.org
Subject: Re: [PATCH v1 1/1] sched/fair: do not preempt current task if it is going to call schedule()
Date: Thu, 5 Mar 2020 21:33:47 +0800	[thread overview]
Message-ID: <202003052150.GVufrWpz%lkp@intel.com> (raw)
In-Reply-To: <20200305081611.29323-2-cl@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 3944 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on arm64/for-next/core tip/auto-latest linus/master v5.6-rc4 next-20200305]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/cl-rock-chips-com/wait_task_inactive-spend-too-much-time-on-system-startup/20200305-201639
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a0f03b617c3b2644d3d47bf7d9e60aed01bd5b10
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES
   Depends on DISCONTIGMEM || NUMA
   Selected by
   - SINGLE_MEMORY_CHUNK && MMU
   In file included from arch/m68k/kernel/asm-offsets.c:15:0:
   include/linux/sched.h: In function 'set_tsk_going_to_sched':
>> include/linux/sched.h:1776:27: error: 'TIF_GOING_TO_SCHED' undeclared (first use in this function); did you mean
   set_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED);
   ^~~~~~~~~~~~~~~~~~
   TIF_NEED_RESCHED
   include/linux/sched.h:1776:27: note: each undeclared identifier is reported only once for each function it appears in
   include/linux/sched.h: In function 'clear_tsk_going_to_sched':
   include/linux/sched.h:1781:29: error: 'TIF_GOING_TO_SCHED' undeclared (first use in this function); did you mean
   clear_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED);
   ^~~~~~~~~~~~~~~~~~
   TIF_NEED_RESCHED
   In file included from include/linux/kernel.h:11:0,
   from include/linux/list.h:9,
   from include/linux/rculist.h:10,
   from include/linux/pid.h:5,
   from include/linux/sched.h:14,
   from arch/m68k/kernel/asm-offsets.c:15:
   include/linux/sched.h: In function 'test_tsk_going_to_sched':
   include/linux/sched.h:1786:44: error: 'TIF_GOING_TO_SCHED' undeclared (first use in this function); did you mean
   return unlikely(test_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED));
   ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
   # define unlikely(x) 0)
   ^
   Makefile Module.symvers System.map arch block certs crypto drivers fs include init ipc kernel lib mm modules.builtin modules.builtin.modinfo modules.order net scripts security sound source usr virt vmlinux vmlinux.gz vmlinux.o [scripts/Makefile.build:101: arch/m68k/kernel/asm-offsets.s] Error 1
   Target '__build' not remade because of errors.
   Makefile Module.symvers System.map arch block certs crypto drivers fs include init ipc kernel lib mm modules.builtin modules.builtin.modinfo modules.order net scripts security sound source usr virt vmlinux vmlinux.gz vmlinux.o [Makefile:1112: prepare0] Error 2
   Target 'prepare' not remade because of errors.
   make: Makefile Module.symvers System.map arch block certs crypto drivers fs include init ipc kernel lib mm modules.builtin modules.builtin.modinfo modules.order net scripts security sound source usr virt vmlinux vmlinux.gz vmlinux.o [Makefile:179: sub-make] Error 2
   20 real 6 user 7 sys 67.16% cpu make prepare

vim +/TIF_GOING_TO_SCHED +1776 include/linux/sched.h

  1773	
  1774	static inline void set_tsk_going_to_sched(struct task_struct *tsk)
  1775	{
> 1776		set_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED);
  1777	}
  1778	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52798 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel