From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D8DC10DCE for ; Fri, 6 Mar 2020 13:39:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6ACEF208CD for ; Fri, 6 Mar 2020 13:39:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FgcIf5Nv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="mVevxdRo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6ACEF208CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FeVF0d1o+uqdmPDpz5djescgnOEirR+ftkPaNmlZ1yM=; b=FgcIf5NvGkixyC P37p6sb37p7ZDNPBOkRCch1Vkx6IF1OuZ2sF4i1L+VrPSXlldjqKiOCw45QjgXoCc5hQCbflTtE4N tDB4k4yrNFuM0+mLY//RDH+KOdEGj4pbKw8tWTvSbPTuWtp8j5lA7UG/OtzMZiqo2lZ4iVMk0F/Bc IS6QL1F4lY8FOEP50lwU/EnaRZqGBRu5EZl/NX2mbK1EzkIa0sMPWOSuIAUjji/AUcNu7qEnewuhd BIRkJNLpJc/9UnJsqLao/i9re5LTNHpM5q+3fEx0CVj5Q8uT/edAYjnYny52mjZjyKytjBauCPOvz 0/vjDICnR3fHxNpT8DiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jADC9-00033w-RU; Fri, 06 Mar 2020 13:39:17 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jADC1-0002xi-ST for linux-arm-kernel@lists.infradead.org; Fri, 06 Mar 2020 13:39:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SMdbthzv3TX7S1U2DSWTkquAEKDYnwquXKKkz97UBdo=; b=mVevxdRoYevK+SpcVyNNWfMuUt c/62GzTNWFUryEFoFm1VRfCjAZeAz86XA44dOrcJ5d4Gsdvo6NZSGvmMQVMa3NxHCg415gFTS5QdN 5+bK1tJ2mwZm+W300PDhoQm4TI95F+rx+yKfcYBq8SH5mV7c5IpflwvPMSc6eI8Ic9So=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jADBg-00051y-7e; Fri, 06 Mar 2020 14:38:48 +0100 Date: Fri, 6 Mar 2020 14:38:48 +0100 From: Andrew Lunn To: Ahmad Fatoum Subject: Re: [PATCH] ARM: mach-imx6q: add ksz9131rn_phy_fixup Message-ID: <20200306133848.GB18310@lunn.ch> References: <20200305134928.19775-1-philippe.schenker@toradex.com> <20200305143805.dk7fndblnqjnwxu6@pengutronix.de> <20200305165145.GA25183@lunn.ch> <7191ffe6-642a-477c-ec37-e37dc9be4bf8@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7191ffe6-642a-477c-ec37-e37dc9be4bf8@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200306_053909_959357_3570251E X-CRM114-Status: UNSURE ( 8.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , Philippe Schenker , Greg Kroah-Hartman , Sascha Hauer , Russell King , linux-kernel@vger.kernel.org, Oleksij Rempel , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , Thomas Gleixner , Fabio Estevam , Allison Randal , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > It probably does not even need that. Just > > > > phy-mode = > > Looks to me like this isn't supported by the Micrel PHY driver or am > I missing something? Ah, you are correct. It just has: if (of_node) { ksz9021_load_values_from_of(phydev, of_node, MII_KSZPHY_CLK_CONTROL_PAD_SKEW, "txen-skew-ps", "txc-skew-ps", "rxdv-skew-ps", "rxc-skew-ps"); ksz9021_load_values_from_of(phydev, of_node, MII_KSZPHY_RX_DATA_PAD_SKEW, "rxd0-skew-ps", "rxd1-skew-ps", "rxd2-skew-ps", "rxd3-skew-ps"); ksz9021_load_values_from_of(phydev, of_node, MII_KSZPHY_TX_DATA_PAD_SKEW, "txd0-skew-ps", "txd1-skew-ps", "txd2-skew-ps", "txd3-skew-ps"); } and no support for phydev->interface. At minimum, you should use these DT properties, not a platform fixup. If you want to, you can add support for rgmii-id, etc. There are five modes you need to support: PHY_INTERFACE_MODE_NA, PHY_INTERFACE_MODE_RGMII, PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID, PHY_INTERFACE_MODE_RGMII_TXID, NA means "don't touch". Leave the RGMII delays alone, as configured by hardware default, strapping, bootloader, etc. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel