From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B7CC10DCE for ; Fri, 6 Mar 2020 14:23:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50BB22070E for ; Fri, 6 Mar 2020 14:23:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T7MaK6UA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50BB22070E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EU+/2SKQhw1IMF2pvfvBnblhd1dmPtwNsQjIIcOBfOc=; b=T7MaK6UAxuHRwY 3NPabC/l+ZIK75iUAzPBdEUnqdfmzgK7D0REuC9HBLWQjxkVIhgbuXlxwS1N24a3O/A3ZhEDWURdR udbd8KxK6izpB2Sxo6lFxBr+mwRMUvJh1lLhKeLmZgiXq9D8fKcGIwZ2hqE2TxiZnq0hHIkkdzETl QQHI3/ZUbT9JywhkMT4C7F1dmGPgpbCieCMd5Of7MffieY1a0eQ+YGvV1pwYqgbqzTy1gyxIMcVx5 Pn1cu9Z2q2Zg+KYkEERcXqH6cMmWJukXJFsFrviFxKSjDOBFmxIajh/tcjb8OVt2pyOstrcJwfMXx kN4FZw+fwPHvpPnHprCg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jADtA-00051T-DC; Fri, 06 Mar 2020 14:23:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jADt0-0004uk-Fm for linux-arm-kernel@lists.infradead.org; Fri, 06 Mar 2020 14:23:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9797031B; Fri, 6 Mar 2020 06:23:33 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 137363F534; Fri, 6 Mar 2020 06:23:31 -0800 (PST) Date: Fri, 6 Mar 2020 14:23:30 +0000 From: Sudeep Holla To: Benjamin Gaignard Subject: Re: [PATCH v2 4/4] cpuidle: psci: Allow WFI to be the only state for the hierarchical topology Message-ID: <20200306134119.GB47929@bogus> References: <20200303203559.23995-1-ulf.hansson@linaro.org> <20200303203559.23995-5-ulf.hansson@linaro.org> <20200304122312.GE25004@bogus> <20200305162321.GB53631@bogus> <20200306100431.GA16541@bogus> <20200306120646.GB44221@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200306_062334_614806_CF4CC6CC X-CRM114-Status: GOOD ( 13.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Lorenzo Pieralisi , Benjamin Gaignard , Linux PM , Stephen Boyd , Daniel Lezcano , "Rafael J . Wysocki" , Lina Iyer , Bjorn Andersson , Sudeep Holla , Linux ARM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 06, 2020 at 01:32:59PM +0100, Benjamin Gaignard wrote: > Le ven. 6 mars 2020 =E0 13:06, Sudeep Holla a =E9c= rit : > > [...] > > Sure, please create a deeper CPU state than WFI and enter so that the C= PU > > state is saved and restored correctly. What is the problem doing that ? > > This state stop the clocks for all the hardware blocks and not only the C= PUs > so we can't go on it while devices aren't suspended. > I may have missed something but I don't believe that I could add this kin= d of > conditions in a cpu idle state, right ? > In this state I need to be able to enable the wake up sources because > it is the only > for hardware block used as broadcast timer to wake up the system. > We have discussed this in past in the thread I mentioned and may be others too. It sounds like a broken hardware, sorry if I am wrong. But this $subject patch is a hack to solve that and I am NACK-ing this now. Please fix it adding another CPU level idle state, we are not supporting without that and there is absolutely no need to. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel