From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44108C10DCE for ; Sat, 7 Mar 2020 02:58:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12855206D5 for ; Sat, 7 Mar 2020 02:58:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uMWflD2y"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="0nNKKNRh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12855206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5TDdEuK01PcMSsChjjbaEvJStPpzl53UXqRBNRJO+DM=; b=uMWflD2yiesOS4 JqJDSWPomhiAIlF8n/1IzqXKDFp+Avp0jZ0VuzBKsfIbLtWSDieJZrthftgsAst6OnjRIi5GljvfQ vDnD2z3R5RqeeMlE8Aq6MEXkSlDHJ4D2AiZAxWbjCtA1Se9An92M4jGfxcBVtrwaw5tnrVrnO2lr4 9ilfVN9eoR5UIN0rk2reH5IsS/m84KzgezfN2BGCyE9i0pEMzzY3SE+yVmV7frl+DYk+VsLL8hLXg ExCJp4bJHYEUGyZd7vbp0WGvUt64tAqmNXlf7q0PUnyLPFL04sskfhrZxNr921h/AICWxSVeQ3+re t7oCKPUjIl690DztShGQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAPfE-0000vD-Ri; Sat, 07 Mar 2020 02:58:08 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAPfD-0000v5-L1 for linux-arm-kernel@bombadil.infradead.org; Sat, 07 Mar 2020 02:58:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oNocI03EYs1Z+pGvwVoMrM4xrMbRGicYCCbHzVDgI7M=; b=0nNKKNRhhM2jfNWckowCqdVcCK N++fCSv1ixpFrfyUQXythe7twzL8WVzusDxseU53ZvduFun2oolGUOwUXlNO4R5HVPWf1J/ErTd7z ob6gfmlTDQFdQULfbQkh/7ryGSJw6fZhcl38PZBjZXhDsxliXV+fp5km/Ql97syTWHllmVKil6UcE rPH+ZpF6FZxD4NfavrwOLAhYd55V2Eh+OEaXlV5b237D8gpcIBXs1zoNwu425M8mNGpSWzwvOC33C lvc4SLyazUGatLZcLStoazfBjvADNEw+Q5xn6KfZh4t6bcpia/KWyNd0A0CAqowKnv5DeCNxjQrwQ WRX/5K0A==; Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAPf9-0007YL-I2 for linux-arm-kernel@lists.infradead.org; Sat, 07 Mar 2020 02:58:04 +0000 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id E1D1F200002; Sat, 7 Mar 2020 02:57:20 +0000 (UTC) Date: Sat, 7 Mar 2020 03:57:20 +0100 From: Alexandre Belloni To: Anson Huang Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY Message-ID: <20200307025720.GA52231@piout.net> References: <1583509356-8265-1-git-send-email-Anson.Huang@nxp.com> <1583509356-8265-3-git-send-email-Anson.Huang@nxp.com> <20200306193310.GI217608@dtor-ws> <20200306211538.GA8060@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marco Felsch , Fabio Estevam , "linux-rtc@vger.kernel.org" , "amit.kucheria@verdurent.com" , "wim@linux-watchdog.org" , Daniel Lezcano , Krzysztof Kozlowski , dl-linux-imx , "linux-input@vger.kernel.org" , Zhang Rui , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Guenter Roeck , LINUXWATCHDOG , Arnd Bergmann , Linux PM , Sascha Hauer , Thomas Gleixner , Andy Shevchenko , Daniel Baluta , linux-arm-kernel , Alessandro Zummo , Greg Kroah-Hartman , Dmitry Torokhov , lkml , Oleksij Rempel , Sascha Hauer , Enric Balletbo i Serra , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/03/2020 01:36:39+0000, Anson Huang wrote: > Hi, Alexandre > > > Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for > > KEYBOARD_IMX_SC_KEY > > > > On 06/03/2020 12:05:42-0800, Dmitry Torokhov wrote: > > > On Fri, Mar 6, 2020 at 11:33 AM Dmitry Torokhov > > > wrote: > > > > > > > > On Fri, Mar 06, 2020 at 11:42:34PM +0800, Anson Huang wrote: > > > > > Add COMPILE_TEST support to i.MX SC keyboard driver for better > > > > > compile testing coverage. > > > > > > > > > > Signed-off-by: Anson Huang > > > > > > > > Applied, thank you. > > > > > > Actually, not: > > > > > > ERROR: "imx_scu_irq_register_notifier" > > > [drivers/input/keyboard/imx_sc_key.ko] undefined! > > > ERROR: "imx_scu_get_handle" [drivers/input/keyboard/imx_sc_key.ko] > > undefined! > > > ERROR: "imx_scu_call_rpc" [drivers/input/keyboard/imx_sc_key.ko] > > undefined! > > > ERROR: "imx_scu_irq_unregister_notifier" > > > [drivers/input/keyboard/imx_sc_key.ko] undefined! > > > ERROR: "imx_scu_irq_group_enable" > > > [drivers/input/keyboard/imx_sc_key.ko] undefined! > > > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 > > > make: *** [Makefile:1282: modules] Error 2 > > > > > > If you want to enable compile test coverage you need to provide stubs > > > for the above functions. > > > > > > > or select IMX_SCU > > > > or leave out COMPILE_TEST from the individual drivers as having > > COMPILE_TEST for IMX_SCU is enough to be able to select the drivers. > > Thanks, I already added the COMPILE_TEST for IMX_SCU which is in this same patch series, > without that IMX_SCU COMPILE_TEST patch, the build will failed, so in V2, I also added > the stubs into those IMX SCU APIs to make sure even IMX_SCU is NOT enabled, modules > with COMPILE_TEST can still pass build, please help review V2 patch set. > My point is that there is no need for the stubs. Simply have COMPILE_TEST for IMX_SCU as this is enough to extend coverage to all the drivers and significantly reduces the code size versus what you did in v2. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel