From: Mark Brown <broonie@kernel.org>
To: Kevin Li <kevin-ke.li@broadcom.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Scott Branden <sbranden@broadcom.com>,
Liam Girdwood <lgirdwood@gmail.com>, Ray Jui <rjui@broadcom.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
bcm-kernel-feedback-list@broadcom.com,
Stephen Boyd <swboyd@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: brcm: Add DSL/PON SoC audio driver
Date: Tue, 10 Mar 2020 16:28:08 +0000 [thread overview]
Message-ID: <20200310162808.GI4106@sirena.org.uk> (raw)
In-Reply-To: <1165b736-d0fc-1247-6f46-94a51d392532@broadcom.com>
[-- Attachment #1.1: Type: text/plain, Size: 868 bytes --]
On Tue, Mar 10, 2020 at 08:49:08AM -0700, Kevin Li wrote:
> > This is not how any of this is supposed to work, it's unlikely to work
> > well with other devices. If the device supports both master and slave
> > operation then you should let the machine driver pick if the SoC or the
> > CODEC is master via set_fmt(), randomly varying this at runtime is not
> > going to be helpful.
> Maybe the name "master/slave" is confusing, these names come from internal
> chip signals and do not represent the state of the i2s bus master. Our SoC
> supports only master mode in the i2s bus. The Rx and Tx block each have an
> independent bit to indicate if it is generating the clock for the i2s bus.
> The i2s bus clocks need to be generated from either the Rx block or the Tx
> block, but not both.
Right, at the very least this needs to be better documented in the code.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-03-10 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 22:27 [PATCH] ASoC: brcm: Add DSL/PON SoC audio driver Kevin Li
2020-03-06 22:27 ` [PATCH] ASoC: brcm: DSL/PON SoC device tree bindings of " Kevin Li
2020-03-06 22:33 ` [PATCH] ASoC: brcm: Add DSL/PON SoC " Florian Fainelli
2020-03-06 22:50 ` Kevin Li
2020-03-06 23:02 ` Florian Fainelli
2020-03-09 12:33 ` Mark Brown
2020-03-09 17:33 ` Kevin Li
2020-03-09 17:52 ` Mark Brown
2020-03-09 18:14 ` Kevin Li
2020-03-09 19:18 ` Mark Brown
2020-03-10 15:49 ` Kevin Li
2020-03-10 16:28 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310162808.GI4106@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=kevin-ke.li@broadcom.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).