From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66BF9C1975A for ; Thu, 12 Mar 2020 06:04:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D91A20578 for ; Thu, 12 Mar 2020 06:04:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JinL+L2E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D91A20578 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: From:Subject:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9wQB70CLsJnPtAvOyZy0kT2kd2Rg7PfbzNf6YSSR2l4=; b=JinL+L2ER7YZC0 vk17Pa8gL+hlTWzmbjj2kcm3zaC8pCttTYmsA7db7JYyKPqZxUKQzG3tZOTA09BEksiLXLwdG6Mv0 kDD1SytCjr7Ai+OlW3Uk8B/UDEp456pd76/lqZ+kTnzECvy4RwNkLqS4Hdkphw24UJvvRf2/5IP1Z FVXeO0paow2oQ3nH2sKt3Y4keUQhHt5LdZfV/T37YzVQiCNkitO05xgfq4GRqwZ83FVTFAVNmsE0j JjfGfXFyZS1ExHFQvtQvGt/MG38ycaF/aCtFwRtgkNqYw31Cg+3K3IRend1Zy21qXfnNoYZakqXLU EsPcyb7R7S/2Ml/vnhSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCGx6-0002bf-8N; Thu, 12 Mar 2020 06:04:16 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCGx1-0002b5-C7 for linux-arm-kernel@lists.infradead.org; Thu, 12 Mar 2020 06:04:13 +0000 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A3A6C14CCCAE8; Wed, 11 Mar 2020 23:04:02 -0700 (PDT) Date: Wed, 11 Mar 2020 23:04:02 -0700 (PDT) Message-Id: <20200311.230402.1496009558967017193.davem@davemloft.net> To: mklntf@gmail.com Subject: Re: [PATCH] net: stmmac: platform: Fix misleading interrupt error msg From: David Miller In-Reply-To: <20200306163848.5910-1-mklntf@gmail.com> References: <20200306163848.5910-1-mklntf@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Mar 2020 23:04:03 -0700 (PDT) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_230411_413484_9F7A2314 X-CRM114-Status: UNSURE ( 8.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, peppe.cavallaro@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Markus Fuchs Date: Fri, 6 Mar 2020 17:38:48 +0100 > Not every stmmac based platform makes use of the eth_wake_irq or eth_lpi > interrupts. Use the platform_get_irq_byname_optional variant for these > interrupts, so no error message is displayed, if they can't be found. > Rather print an information to hint something might be wrong to assist > debugging on platforms which use these interrupts. > > Signed-off-by: Markus Fuchs What do you mean the error message is misleading right now? It isn't printing anything out at the moment in this situation. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel