From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD027C10F27 for ; Wed, 11 Mar 2020 07:14:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1C4C2192A for ; Wed, 11 Mar 2020 07:14:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IcNxHN+7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="u/KBCjFu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1C4C2192A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mS7tCZoIzcSbGRXHtyeGOMEiIvS3XxNWxgQvoSIir5k=; b=IcNxHN+79wBUul ikZFJU7TX75hRQOkgKMpC0g9AmmK3SFmWZ/plicIUxhyjhRO0mLmll43FwGNZHpS7EYRtCvuQdU2K iBmToODo5MIS9wSAdqhSsKVni6kY9LMgiOJlwIlQru3uqJMXarT7NCH5ACJ2FI8ODmurN2ndQf5Ab N282P4ME2anSny1zzJSiZNb3y29LalRggjBYyoMzaE6bv+CDA/+Gdr9hhCAb7hlXYFI66HC+T/CwP dxh347uG64q4+LhUi+DdOsOKKjMfTecWL6a0EzQgPoddvGKlDFmtN3GY7mMseYhQaocBIDAp0VM+9 YMJJU/H/6atYjCpO9r9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBvZl-00044G-8s; Wed, 11 Mar 2020 07:14:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBvZi-00043p-RL for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2020 07:14:44 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 03EDA21655; Wed, 11 Mar 2020 07:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583910882; bh=iXz4q2qWQPcHO89hOxSWWFxi1Lqa7VY6OPTeHFNILqs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u/KBCjFuijTc3Cdpw6UiQcYun3vjlUiGR+ejoZxaBVjoTMYTeIMD4zEYaxm+nH9DR BQUC1RgzZe28TJlhiBJEBHl6BvuE19pF7sTZXBJoVTnc5j1TvQWO42XYaS2iYQsPAo seiVA4zWvOHOWYZoHQhf61zJRzCdeVheTrLwHzi8= Date: Wed, 11 Mar 2020 15:14:36 +0800 From: Shawn Guo To: peng.fan@nxp.com Subject: Re: [PATCH] ARM64: dts: imx8m: fix aips dts node Message-ID: <20200311071435.GK29269@dragon> References: <1582602242-28577-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1582602242-28577-1-git-send-email-peng.fan@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_001442_925974_085920C3 X-CRM114-Status: GOOD ( 13.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Anson.Huang@nxp.com, daniel.baluta@nxp.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, leonard.crestez@nxp.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 25, 2020 at 11:44:02AM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > Per binding doc fsl,aips-bus.yaml, compatible and reg is > required. And for reg, the AIPS configuration space should be > used, not all the AIPS bus space. > > Signed-off-by: Peng Fan > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 12 ++++++++---- > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 16 ++++++++-------- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 12 ++++++++---- > 4 files changed, 30 insertions(+), 22 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index b3d0b29d7007..a4356d2047cd 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -227,7 +227,8 @@ > ranges = <0x0 0x0 0x0 0x3e000000>; > > aips1: bus@30000000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; The binding doc says "fsl,aips-bus", not "fsl,aips". Shawn > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30000000 0x30000000 0x400000>; > @@ -496,7 +497,8 @@ > }; > > aips2: bus@30400000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30400000 0x30400000 0x400000>; > @@ -555,7 +557,8 @@ > }; > > aips3: bus@30800000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30800000 0x30800000 0x400000>; > @@ -800,7 +803,8 @@ > }; > > aips4: bus@32c00000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x32df0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > index f2775724377f..4848ce82f083 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > @@ -203,8 +203,8 @@ > ranges = <0x0 0x0 0x0 0x3e000000>; > > aips1: bus@30000000 { > - compatible = "simple-bus"; > - reg = <0x30000000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -401,8 +401,8 @@ > }; > > aips2: bus@30400000 { > - compatible = "simple-bus"; > - reg = <0x30400000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -461,8 +461,8 @@ > }; > > aips3: bus@30800000 { > - compatible = "simple-bus"; > - reg = <0x30800000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -707,8 +707,8 @@ > }; > > aips4: bus@32c00000 { > - compatible = "simple-bus"; > - reg = <0x32c00000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x32df0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 71b0c8f23693..eb67f56cdfe2 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -144,8 +144,8 @@ > ranges = <0x0 0x0 0x0 0x3e000000>; > > aips1: bus@30000000 { > - compatible = "simple-bus"; > - reg = <0x30000000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -309,8 +309,8 @@ > }; > > aips2: bus@30400000 { > - compatible = "simple-bus"; > - reg = <0x30400000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x400000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -369,8 +369,8 @@ > }; > > aips3: bus@30800000 { > - compatible = "simple-bus"; > - reg = <0x30800000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x400000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 6a1e83922c71..07070464063d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -290,7 +290,8 @@ > dma-ranges = <0x40000000 0x0 0x40000000 0xc0000000>; > > bus@30000000 { /* AIPS1 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30000000 0x30000000 0x400000>; > @@ -692,7 +693,8 @@ > }; > > bus@30400000 { /* AIPS2 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30400000 0x30400000 0x400000>; > @@ -751,7 +753,8 @@ > }; > > bus@30800000 { /* AIPS3 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30800000 0x30800000 0x400000>, > @@ -1023,7 +1026,8 @@ > }; > > bus@32c00000 { /* AIPS4 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x32df0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > -- > 2.16.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel