From: Shawn Guo <shawnguo@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] arm64: dts: ls1028a: sl28: fix on-board EEPROMS
Date: Wed, 11 Mar 2020 15:16:14 +0800 [thread overview]
Message-ID: <20200311071613.GL29269@dragon> (raw)
In-Reply-To: <20200225175756.29508-2-michael@walle.cc>
On Tue, Feb 25, 2020 at 06:57:54PM +0100, Michael Walle wrote:
> The module itself has another EEPROM at 50h on I2C4. The EEPROM on the
> carriers is located at 57h on I2C3. Fix that in the device trees.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Doesn't apply to my branch.
Shawn
> ---
> .../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 6 +++---
> .../fsl-ls1028a-kontron-sl28-var3-ads2.dts | 14 ++++++++------
> .../dts/freescale/fsl-ls1028a-kontron-sl28.dts | 6 ++++++
> 3 files changed, 17 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> index aaf3c04771c3..32f6c80414bc 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> @@ -18,10 +18,10 @@
> "kontron,sl28", "fsl,ls1028a";
> };
>
> -&i2c4 {
> - eeprom@50 {
> +&i2c3 {
> + eeprom@57 {
> compatible = "atmel,24c32";
> - reg = <0x50>;
> + reg = <0x57>;
> pagesize = <32>;
> };
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> index 20fd86746f94..ff4a43986290 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> @@ -80,6 +80,14 @@
> };
> };
>
> +&i2c3 {
> + eeprom@57 {
> + compatible = "atmel,24c64";
> + reg = <0x57>;
> + pagesize = <32>;
> + };
> +};
> +
> &i2c4 {
> status = "okay";
>
> @@ -92,12 +100,6 @@
> assigned-clocks = <&mclk>;
> assigned-clock-rates = <1250000>;
> };
> -
> - eeprom@50 {
> - compatible = "atmel,24c32";
> - reg = <0x50>;
> - pagesize = <32>;
> - };
> };
>
> &sai5 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index c60a444ad09d..4ba6aae45ef1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -181,6 +181,12 @@
>
> &i2c4 {
> status = "okay";
> +
> + eeprom@50 {
> + compatible = "atmel,24c32";
> + reg = <0x50>;
> + pagesize = <32>;
> + };
> };
>
> &lpuart1 {
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-11 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 17:57 [PATCH 0/3] arm64: dts: ls1028a: various sl28 fixes/updates Michael Walle
2020-02-25 17:57 ` [PATCH 1/3] arm64: dts: ls1028a: sl28: fix on-board EEPROMS Michael Walle
2020-03-11 7:16 ` Shawn Guo [this message]
2020-03-11 7:28 ` Michael Walle
2020-02-25 17:57 ` [PATCH 2/3] arm64: dts: ls1028a: sl28: expose switch ports in KBox A-230-LS Michael Walle
2020-02-25 17:57 ` [PATCH 3/3] arm64: dts: ls1028a: sl28: add support for variant 2 Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311071613.GL29269@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).