From: Shawn Guo <shawnguo@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: s.riedmueller@phytec.de, chf.fritz@googlemail.com,
robh+dt@kernel.org, kernel@pengutronix.de, c.hemp@phytec.de,
contact@stefanchrist.eu, s.christ@phytec.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: imx6: phycore-som: add da9062 gpio support
Date: Wed, 11 Mar 2020 15:41:55 +0800 [thread overview]
Message-ID: <20200311074154.GR29269@dragon> (raw)
In-Reply-To: <20200227110605.22144-2-m.felsch@pengutronix.de>
On Thu, Feb 27, 2020 at 12:06:05PM +0100, Marco Felsch wrote:
> The pmic is a mfd device and supports gpios. Those gpios are not routed
> to the SoM baseboard pin header but they are connected to the i.MX6. We
> need the GPIO's to configure the pmic to select between the
> suspend/resume arm and soc voltages
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>
> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Not sure why this is here. I removed it and applied the patch.
Shawn
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> index 8b71bf33ba30..41ebe4599e43 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -88,7 +88,7 @@
> reg = <0x50>;
> };
>
> - pmic@58 {
> + pmic: pmic@58 {
> compatible = "dlg,da9062";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_pmic>;
> @@ -96,6 +96,8 @@
> interrupt-parent = <&gpio1>;
> interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> interrupt-controller;
> + gpio-controller;
> + #gpio-cells = <2>;
>
> da9062_rtc: rtc {
> compatible = "dlg,da9062-rtc";
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-11 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 11:06 [PATCH 1/2] ARM: dts: imx6: phycore-som: explicit disable pmic watchdog during suspend Marco Felsch
2020-02-27 11:06 ` [PATCH 2/2] ARM: dts: imx6: phycore-som: add da9062 gpio support Marco Felsch
2020-03-11 7:41 ` Shawn Guo [this message]
2020-03-11 7:37 ` [PATCH 1/2] ARM: dts: imx6: phycore-som: explicit disable pmic watchdog during suspend Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311074154.GR29269@dragon \
--to=shawnguo@kernel.org \
--cc=c.hemp@phytec.de \
--cc=chf.fritz@googlemail.com \
--cc=contact@stefanchrist.eu \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.christ@phytec.de \
--cc=s.riedmueller@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).