* [PATCH v4] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
@ 2020-02-27 11:02 Marco Felsch
2020-03-11 7:33 ` Shawn Guo
2020-03-11 8:28 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Marco Felsch @ 2020-02-27 11:02 UTC (permalink / raw)
To: robh+dt, shawnguo, chf.fritz, s.riedmueller, s.christ, c.hemp,
contact
Cc: kernel, linux-arm-kernel
The current set minimum voltage of 730000µV seems to be wrong. I don't
know the document which specifies that but the imx6qdl datasheets says
that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
v4:
- rebased ontop of v5.6-rc1
v3:
- fix commit message
v2:
- use ldo bypassed values
arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
index 4d18952658f8..77d871340eb7 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
@@ -112,7 +112,7 @@
regulators {
vdd_arm: buck1 {
regulator-name = "vdd_arm";
- regulator-min-microvolt = <730000>;
+ regulator-min-microvolt = <925000>;
regulator-max-microvolt = <1380000>;
regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
regulator-always-on;
@@ -120,7 +120,7 @@
vdd_soc: buck2 {
regulator-name = "vdd_soc";
- regulator-min-microvolt = <730000>;
+ regulator-min-microvolt = <1150000>;
regulator-max-microvolt = <1380000>;
regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
regulator-always-on;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v4] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
2020-02-27 11:02 [PATCH v4] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch
@ 2020-03-11 7:33 ` Shawn Guo
2020-03-11 8:18 ` Stefan Riedmüller
2020-03-11 8:28 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2020-03-11 7:33 UTC (permalink / raw)
To: Marco Felsch, Stefan Riedmueller
Cc: chf.fritz, robh+dt, kernel, c.hemp, contact, s.christ,
linux-arm-kernel
On Thu, Feb 27, 2020 at 12:02:46PM +0100, Marco Felsch wrote:
> The current set minimum voltage of 730000µV seems to be wrong. I don't
> know the document which specifies that but the imx6qdl datasheets says
> that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
> lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
Stefan,
Any comment on this change?
Shawn
>
> Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> v4:
> - rebased ontop of v5.6-rc1
> v3:
> - fix commit message
> v2:
> - use ldo bypassed values
>
> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> index 4d18952658f8..77d871340eb7 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -112,7 +112,7 @@
> regulators {
> vdd_arm: buck1 {
> regulator-name = "vdd_arm";
> - regulator-min-microvolt = <730000>;
> + regulator-min-microvolt = <925000>;
> regulator-max-microvolt = <1380000>;
> regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
> regulator-always-on;
> @@ -120,7 +120,7 @@
>
> vdd_soc: buck2 {
> regulator-name = "vdd_soc";
> - regulator-min-microvolt = <730000>;
> + regulator-min-microvolt = <1150000>;
> regulator-max-microvolt = <1380000>;
> regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
> regulator-always-on;
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v4] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
2020-03-11 7:33 ` Shawn Guo
@ 2020-03-11 8:18 ` Stefan Riedmüller
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Riedmüller @ 2020-03-11 8:18 UTC (permalink / raw)
To: Shawn Guo
Cc: Marco Felsch, chf.fritz, robh+dt, kernel, c.hemp, contact,
s.christ, linux-arm-kernel
Hi Shawn,
On 11.03.20 08:33, Shawn Guo wrote:
> On Thu, Feb 27, 2020 at 12:02:46PM +0100, Marco Felsch wrote:
>> The current set minimum voltage of 730000µV seems to be wrong. I don't
>> know the document which specifies that but the imx6qdl datasheets says
>> that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
>> lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
>
> Stefan,
>
> Any comment on this change?
looks good to me. Thanks for asking.
Reviewed-by: Stefan Riedmueller <s.riedmueller@phytec.de>
Regards,
Stefan
>
> Shawn
>
>>
>> Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>> ---
>> v4:
>> - rebased ontop of v5.6-rc1
>> v3:
>> - fix commit message
>> v2:
>> - use ldo bypassed values
>>
>> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> index 4d18952658f8..77d871340eb7 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> @@ -112,7 +112,7 @@
>> regulators {
>> vdd_arm: buck1 {
>> regulator-name = "vdd_arm";
>> - regulator-min-microvolt = <730000>;
>> + regulator-min-microvolt = <925000>;
>> regulator-max-microvolt = <1380000>;
>> regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
>> regulator-always-on;
>> @@ -120,7 +120,7 @@
>>
>> vdd_soc: buck2 {
>> regulator-name = "vdd_soc";
>> - regulator-min-microvolt = <730000>;
>> + regulator-min-microvolt = <1150000>;
>> regulator-max-microvolt = <1380000>;
>> regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
>> regulator-always-on;
>> --
>> 2.20.1
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
2020-02-27 11:02 [PATCH v4] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch
2020-03-11 7:33 ` Shawn Guo
@ 2020-03-11 8:28 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2020-03-11 8:28 UTC (permalink / raw)
To: Marco Felsch
Cc: s.riedmueller, chf.fritz, robh+dt, kernel, c.hemp, contact,
s.christ, linux-arm-kernel
On Thu, Feb 27, 2020 at 12:02:46PM +0100, Marco Felsch wrote:
> The current set minimum voltage of 730000µV seems to be wrong. I don't
> know the document which specifies that but the imx6qdl datasheets says
> that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
> lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
>
> Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-11 8:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-27 11:02 [PATCH v4] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch
2020-03-11 7:33 ` Shawn Guo
2020-03-11 8:18 ` Stefan Riedmüller
2020-03-11 8:28 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox