* [PATCH v1] ARM: dts: imx6q-marsboard: properly define rgmii PHY
@ 2020-03-06 8:03 Oleksij Rempel
2020-03-12 14:36 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Oleksij Rempel @ 2020-03-06 8:03 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
Rob Herring, Sascha Hauer, Shawn Guo
Cc: devicetree, netdev, Liam Girdwood, linux-kernel, Oleksij Rempel,
Mark Brown, NXP Linux Team, Pengutronix Kernel Team, Russell King,
Fabio Estevam, David S. Miller, linux-arm-kernel
The Atheros AR8035 PHY can be autodetected but can't use interrupt
support provided on this board. Define MDIO bus and the PHY node to make
it work properly.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6q-marsboard.dts | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6q-marsboard.dts b/arch/arm/boot/dts/imx6q-marsboard.dts
index 84b30bd6908f..019488aaa30b 100644
--- a/arch/arm/boot/dts/imx6q-marsboard.dts
+++ b/arch/arm/boot/dts/imx6q-marsboard.dts
@@ -111,8 +111,23 @@ &fec {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_enet>;
phy-mode = "rgmii-id";
- phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* Atheros AR8035 PHY */
+ rgmii_phy: ethernet-phy@4 {
+ reg = <4>;
+
+ interrupts-extended = <&gpio1 28 IRQ_TYPE_LEVEL_LOW>;
+
+ reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10000>;
+ reset-deassert-us = <1000>;
+ };
+ };
};
&hdmi {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] ARM: dts: imx6q-marsboard: properly define rgmii PHY
2020-03-06 8:03 [PATCH v1] ARM: dts: imx6q-marsboard: properly define rgmii PHY Oleksij Rempel
@ 2020-03-12 14:36 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2020-03-12 14:36 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Mark Rutland, Andrew Lunn, Florian Fainelli, devicetree,
Russell King, netdev, Sascha Hauer, Liam Girdwood, linux-kernel,
Rob Herring, Mark Brown, Pengutronix Kernel Team, NXP Linux Team,
Fabio Estevam, David S. Miller, linux-arm-kernel, Heiner Kallweit
On Fri, Mar 06, 2020 at 09:03:53AM +0100, Oleksij Rempel wrote:
> The Atheros AR8035 PHY can be autodetected but can't use interrupt
> support provided on this board. Define MDIO bus and the PHY node to make
> it work properly.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/arm/boot/dts/imx6q-marsboard.dts | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6q-marsboard.dts b/arch/arm/boot/dts/imx6q-marsboard.dts
> index 84b30bd6908f..019488aaa30b 100644
> --- a/arch/arm/boot/dts/imx6q-marsboard.dts
> +++ b/arch/arm/boot/dts/imx6q-marsboard.dts
> @@ -111,8 +111,23 @@ &fec {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_enet>;
> phy-mode = "rgmii-id";
> - phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> status = "okay";
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* Atheros AR8035 PHY */
> + rgmii_phy: ethernet-phy@4 {
> + reg = <4>;
> +
> + interrupts-extended = <&gpio1 28 IRQ_TYPE_LEVEL_LOW>;
> +
Drop these newlines.
Shawn
> + reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10000>;
> + reset-deassert-us = <1000>;
> + };
> + };
> };
>
> &hdmi {
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-12 14:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-06 8:03 [PATCH v1] ARM: dts: imx6q-marsboard: properly define rgmii PHY Oleksij Rempel
2020-03-12 14:36 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).